zoriya/react-native-web
1
0
Fork 0
mirror of https://github.com/zoriya/react-native-web.git synced 2026-06-04 11:04:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove '!important' check from setValueForStyles

Browse Source 
'!important' styles are no longer used internally and are not supported in the
public API.
This commit is contained in:
Nicolas Gallagher
2019-03-19 10:32:59 -07:00
parent 36dacb2052
commit c1459d7b21
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-web/src/vendor/react-dom/setValueForStyles/index.js
Vendored
+2 -9
View File
@@ -28,8 +28,6 @@ function setValueForStyles(node, styles, getStack) {
continue; continue;
} }
const isCustomProperty = styleName.indexOf('--') === 0; const isCustomProperty = styleName.indexOf('--') === 0;
const isImportant =
typeof styles[styleName] === 'string' && styles[styleName].indexOf('!important') > -1;
if (process.env.NODE_ENV !== 'production') { if (process.env.NODE_ENV !== 'production') {
if (!isCustomProperty) { if (!isCustomProperty) {
warnValidStyle(styleName, styles[styleName], getStack); warnValidStyle(styleName, styles[styleName], getStack);
@@ -39,14 +37,9 @@ function setValueForStyles(node, styles, getStack) {
if (styleName === 'float') { if (styleName === 'float') {
styleName = 'cssFloat'; styleName = 'cssFloat';
} }
if (isCustomProperty || isImportant) { if (isCustomProperty) {
const name = isCustomProperty ? styleName : hyphenateStyleName(styleName); const name = isCustomProperty ? styleName : hyphenateStyleName(styleName);
if (isImportant) { style.setProperty(name, styleValue);
const [value, priority] = styleValue.split('!');
style.setProperty(name, value, priority);
} else {
style.setProperty(name, styleValue);
}
} else { } else {
style[styleName] = styleValue; style[styleName] = styleValue;
} }