From d03e06632eb5b83d9b5e575674733dbc9c52b81a Mon Sep 17 00:00:00 2001 From: Nicolas Gallagher Date: Sun, 9 Jul 2017 17:47:19 -0700 Subject: [PATCH] [fix] remove Image styles not supported by View --- src/components/Image/__tests__/index-test.js | 6 ++++++ src/components/Image/index.js | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/components/Image/__tests__/index-test.js b/src/components/Image/__tests__/index-test.js index 1bf6a922..214353d8 100644 --- a/src/components/Image/__tests__/index-test.js +++ b/src/components/Image/__tests__/index-test.js @@ -139,6 +139,12 @@ describe('components/Image', () => { const component = render(); expect(component).toMatchSnapshot(); }); + + test('removes other unsupported View styles', () => { + const component = shallow(); + expect(component.props().style.overlayColor).toBeUndefined(); + expect(component.props().style.tintColor).toBeUndefined(); + }); }); test('prop "testID"', () => { diff --git a/src/components/Image/index.js b/src/components/Image/index.js index 69bc1be1..93bd0dfb 100644 --- a/src/components/Image/index.js +++ b/src/components/Image/index.js @@ -184,8 +184,10 @@ class Image extends Component { this.context.isInAParentText && styles.inline, backgroundImage && { backgroundImage } ]); - // View doesn't support 'resizeMode' as a style + // View doesn't support these styles + delete style.overlayColor; delete style.resizeMode; + delete style.tintColor; // Allows users to trigger the browser's image context menu const hiddenImage = displayImage