[fix] accessibilityLiveRegion values

This commit is contained in:
Nicolas Gallagher
2017-03-30 09:55:02 -07:00
parent 1b172319b9
commit d6854abd7d
5 changed files with 6 additions and 6 deletions
@@ -8,7 +8,7 @@ exports[`modules/createDOMElement prop "accessibilityLabel" 1`] = `
exports[`modules/createDOMElement prop "accessibilityLiveRegion" 1`] = ` exports[`modules/createDOMElement prop "accessibilityLiveRegion" 1`] = `
<span <span
aria-live="polite" aria-live="off"
/> />
`; `;
@@ -18,7 +18,7 @@ describe('modules/createDOMElement', () => {
}); });
test('prop "accessibilityLiveRegion"', () => { test('prop "accessibilityLiveRegion"', () => {
const accessibilityLiveRegion = 'polite'; const accessibilityLiveRegion = 'none';
const component = renderer.create(createDOMElement('span', { accessibilityLiveRegion })); const component = renderer.create(createDOMElement('span', { accessibilityLiveRegion }));
expect(component.toJSON()).toMatchSnapshot(); expect(component.toJSON()).toMatchSnapshot();
}); });
+1 -1
View File
@@ -57,7 +57,7 @@ const getAccessibilityComponent = (props = emptyObject) => {
const level = props['aria-level'] || 1; const level = props['aria-level'] || 1;
return `h${level}`; return `h${level}`;
} }
return roleComponents[role] return roleComponents[role];
}; };
const createDOMElement = (component, rnProps) => { const createDOMElement = (component, rnProps) => {
+2 -2
View File
@@ -45,8 +45,8 @@ const createDOMProps = (rnProps, resolveStyle) => {
if (accessibilityLabel) { if (accessibilityLabel) {
domProps['aria-label'] = accessibilityLabel; domProps['aria-label'] = accessibilityLabel;
} }
if (accessibilityLiveRegion) { if (typeof accessibilityLiveRegion === 'string') {
domProps['aria-live'] = accessibilityLiveRegion; domProps['aria-live'] = accessibilityLiveRegion === 'none' ? 'off' : accessibilityLiveRegion;
} }
if (className && className !== '') { if (className && className !== '') {
domProps.className = domProps.className ? `${domProps.className} ${className}` : className; domProps.className = domProps.className ? `${domProps.className} ${className}` : className;
+1 -1
View File
@@ -3,7 +3,7 @@ const { array, bool, number, object, oneOf, oneOfType, string } = PropTypes;
const BaseComponentPropTypes = { const BaseComponentPropTypes = {
accessibilityLabel: string, accessibilityLabel: string,
accessibilityLiveRegion: oneOf(['assertive', 'off', 'polite']), accessibilityLiveRegion: oneOf(['assertive', 'none', 'polite']),
accessibilityRole: string, accessibilityRole: string,
accessible: bool, accessible: bool,
style: oneOfType([array, number, object]), style: oneOfType([array, number, object]),