From e82648562240345084c53f3b2a600403650af31b Mon Sep 17 00:00:00 2001 From: Elliot Dickison Date: Fri, 30 Apr 2021 11:28:33 -0700 Subject: [PATCH] [fix] Use of process.env.NODE_ENV Corrects misspelling in a few locations and adds tests for the Platform module. Close #2006 --- .../src/domEnvironment.js | 2 +- .../exports/Platform/__tests__/index-test.js | 18 ++++++++++++++++++ .../src/exports/Platform/index.js | 2 +- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/packages/dom-event-testing-library/src/domEnvironment.js b/packages/dom-event-testing-library/src/domEnvironment.js index 5d19dab7..8771cbd1 100644 --- a/packages/dom-event-testing-library/src/domEnvironment.js +++ b/packages/dom-event-testing-library/src/domEnvironment.js @@ -22,7 +22,7 @@ export function hasPointerEvent() { export function setPointerEvent(bool) { const pointerCaptureFn = (name) => (id) => { if (typeof id !== 'number') { - if (process.env.NODE_DEV !== 'production') { + if (process.env.NODE_ENV !== 'production') { console.error('A pointerId must be passed to "%s"', name); } } diff --git a/packages/react-native-web/src/exports/Platform/__tests__/index-test.js b/packages/react-native-web/src/exports/Platform/__tests__/index-test.js index 6feb981e..a2b34dfe 100644 --- a/packages/react-native-web/src/exports/Platform/__tests__/index-test.js +++ b/packages/react-native-web/src/exports/Platform/__tests__/index-test.js @@ -14,4 +14,22 @@ describe('apis/Platform', () => { ).toEqual('web'); }); }); + + describe('isTesting', () => { + const NODE_ENV_BACKUP = process.env.NODE_ENV; + + afterEach(() => { + process.env.NODE_ENV = NODE_ENV_BACKUP; + }); + + test('true when NODE_ENV is "test"', () => { + process.env.NODE_ENV = 'test'; + expect(Platform.isTesting).toEqual(true); + }); + + test('false when NODE_ENV is not "test"', () => { + process.env.NODE_ENV = 'development'; + expect(Platform.isTesting).toEqual(false); + }); + }); }); diff --git a/packages/react-native-web/src/exports/Platform/index.js b/packages/react-native-web/src/exports/Platform/index.js index 7fd45ef2..d688cc76 100644 --- a/packages/react-native-web/src/exports/Platform/index.js +++ b/packages/react-native-web/src/exports/Platform/index.js @@ -12,7 +12,7 @@ const Platform = { OS: 'web', select: (obj: Object): any => ('web' in obj ? obj.web : obj.default), get isTesting(): boolean { - if (process.env.NODE_DEV === 'test') { + if (process.env.NODE_ENV === 'test') { return true; } return false;