diff --git a/site/src/components/docs/FrameworkCase.astro b/site/src/components/docs/FrameworkCase.astro index 5d43425e..c078ed95 100644 --- a/site/src/components/docs/FrameworkCase.astro +++ b/site/src/components/docs/FrameworkCase.astro @@ -3,15 +3,9 @@ import type { SupportedFramework } from '@/types/docs'; interface Props { frameworks?: SupportedFramework[]; - /** - * I'm running into some crazy problems with hydration. - * Putting client:load in one of these conditionals causes Astro to just give up hydrating the whole app for some reason. - * If you're running into that, too, this prop may be for you. - */ - withHydrationWorkaround?: boolean; } -const { frameworks, withHydrationWorkaround } = Astro.props; +const { frameworks } = Astro.props; const { framework } = Astro.params; // Only render if current framework matches, or if no frameworks specified (all frameworks) @@ -19,11 +13,19 @@ const shouldRender = !frameworks || frameworks.includes(framework as SupportedFr --- { - withHydrationWorkaround ? ( - - ) : ( - shouldRender && - ) + /* + What I WANT to do is + ``` + {shouldRender && } + ``` + + But I'm running into some crazy problems with hydration. + Putting client:load in one of these conditionals causes Astro to just give up hydrating the whole app for some reason. + TODO: fix this + + So, while I debug those... let's do this + */ } + diff --git a/site/src/components/docs/StyleCase.astro b/site/src/components/docs/StyleCase.astro index 0afb4c2c..5c5b8ffc 100644 --- a/site/src/components/docs/StyleCase.astro +++ b/site/src/components/docs/StyleCase.astro @@ -3,15 +3,9 @@ import type { AnySupportedStyle } from '@/types/docs'; interface Props { styles?: AnySupportedStyle[]; - /** - * I'm running into some crazy problems with hydration. - * Putting client:load in one of these conditionals causes Astro to just give up hydrating the whole app for some reason. - * If you're running into that, too, this prop may be for you. - */ - withHydrationWorkaround?: boolean; } -const { styles, withHydrationWorkaround } = Astro.props; +const { styles } = Astro.props; const { style } = Astro.params; // Only render if current style matches, or if no styles specified (all styles) @@ -19,11 +13,19 @@ const shouldRender = !styles || styles.includes(style as AnySupportedStyle); --- { - withHydrationWorkaround ? ( - - ) : ( - shouldRender && - ) + /* + What I WANT to do is + ``` + {shouldRender && } + ``` + + But I'm running into some crazy problems with hydration. + Putting client:load in one of these conditionals causes Astro to just give up hydrating the whole app for some reason. + TODO: fix this + + So, while I debug those... let's do this + */ } + diff --git a/site/src/content/docs/concepts/architecture.mdx b/site/src/content/docs/concepts/architecture.mdx index 327bc7bc..40360ef1 100644 --- a/site/src/content/docs/concepts/architecture.mdx +++ b/site/src/content/docs/concepts/architecture.mdx @@ -92,7 +92,7 @@ function Player() { ``` - + + - + + - + + - + + - + - + - + diff --git a/site/src/content/docs/reference/play-button.mdx b/site/src/content/docs/reference/play-button.mdx index 9f31601e..321e3537 100644 --- a/site/src/content/docs/reference/play-button.mdx +++ b/site/src/content/docs/reference/play-button.mdx @@ -24,7 +24,7 @@ import { TabsRoot, TabsPanel } from '@/components/Tabs'; ## Example - + - + + - + + - +