mirror of
https://github.com/zoriya/v10.git
synced 2026-08-16 02:45:09 +00:00
refactor(packages): move slider throttle from commit to change (#1219)
This commit is contained in:
@@ -28,7 +28,7 @@ describe('TimeSliderElement', () => {
|
||||
it('initializes with default property values', () => {
|
||||
const slider = createElement(TimeSliderElement);
|
||||
expect(slider.label).toBe('Seek');
|
||||
expect(slider.commitThrottle).toBe(100);
|
||||
expect(slider.changeThrottle).toBe(100);
|
||||
expect(slider.step).toBe(1);
|
||||
expect(slider.largeStep).toBe(10);
|
||||
expect(slider.orientation).toBe('horizontal');
|
||||
|
||||
@@ -24,7 +24,7 @@ export class TimeSliderElement extends MediaElement {
|
||||
|
||||
static override properties = {
|
||||
label: { type: String },
|
||||
commitThrottle: { type: Number, attribute: 'commit-throttle' },
|
||||
changeThrottle: { type: Number, attribute: 'change-throttle' },
|
||||
step: { type: Number },
|
||||
largeStep: { type: Number, attribute: 'large-step' },
|
||||
orientation: { type: String },
|
||||
@@ -33,7 +33,7 @@ export class TimeSliderElement extends MediaElement {
|
||||
} satisfies PropertyDeclarationMap<Exclude<keyof TimeSliderCore.Props, 'value' | 'min' | 'max'>>;
|
||||
|
||||
label = TimeSliderCore.defaultProps.label;
|
||||
commitThrottle = TimeSliderCore.defaultProps.commitThrottle;
|
||||
changeThrottle = TimeSliderCore.defaultProps.changeThrottle;
|
||||
step = TimeSliderCore.defaultProps.step;
|
||||
largeStep = TimeSliderCore.defaultProps.largeStep;
|
||||
orientation = TimeSliderCore.defaultProps.orientation;
|
||||
@@ -68,11 +68,15 @@ export class TimeSliderElement extends MediaElement {
|
||||
},
|
||||
getStepPercent: () => this.#core.getStepPercent(),
|
||||
getLargeStepPercent: () => this.#core.getLargeStepPercent(),
|
||||
onValueChange: (percent) => {
|
||||
const media = this.#timeState.value;
|
||||
if (media) media.seek(this.#core.rawValueFromPercent(percent));
|
||||
},
|
||||
onValueCommit: (percent) => {
|
||||
const media = this.#timeState.value;
|
||||
if (media) media.seek(this.#core.rawValueFromPercent(percent));
|
||||
},
|
||||
commitThrottle: this.commitThrottle,
|
||||
changeThrottle: this.changeThrottle,
|
||||
onDragStart: () => {
|
||||
this.dispatchEvent(new CustomEvent('drag-start', { bubbles: true }));
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user