refactor(packages): move slider throttle from commit to change (#1219)

This commit is contained in:
rahim
2026-04-05 22:19:11 -07:00
committed by GitHub
parent d75cd82ef8
commit 0c95ab4109
10 changed files with 423 additions and 150 deletions
+2 -2
View File
@@ -22,7 +22,7 @@ export interface UseSliderOptions<State extends SliderState = SliderState>
| 'getPercent'
| 'getStepPercent'
| 'getLargeStepPercent'
| 'commitThrottle'
| 'changeThrottle'
| 'onValueChange'
| 'onValueCommit'
| 'onDragStart'
@@ -74,7 +74,7 @@ export function useSlider<State extends SliderState = SliderState>(
getPercent: () => optionsRef.current.getPercent(),
getStepPercent: () => optionsRef.current.getStepPercent(),
getLargeStepPercent: () => optionsRef.current.getLargeStepPercent(),
commitThrottle: optionsRef.current.commitThrottle,
changeThrottle: optionsRef.current.changeThrottle,
adjustPercent: optionsRef.current.adjustPercent,
onValueChange: (percent) => optionsRef.current.onValueChange?.(percent),
onValueCommit: (percent) => optionsRef.current.onValueCommit?.(percent),
@@ -26,7 +26,7 @@ export const TimeSliderRoot = forwardRef<HTMLDivElement, TimeSliderRootProps>(
className,
style,
label,
commitThrottle = TimeSliderCore.defaultProps.commitThrottle,
changeThrottle = TimeSliderCore.defaultProps.changeThrottle,
step = TimeSliderCore.defaultProps.step,
largeStep = TimeSliderCore.defaultProps.largeStep,
orientation,
@@ -71,10 +71,14 @@ export const TimeSliderRoot = forwardRef<HTMLDivElement, TimeSliderRootProps>(
getLargeStepPercent: () => core.getLargeStepPercent(),
orientation,
disabled,
commitThrottle,
changeThrottle,
adjustPercent: (rawPercent, thumbSize, trackSize) =>
core.adjustPercentForAlignment(rawPercent, thumbSize, trackSize),
getCSSVars: getTimeSliderCSSVars,
onValueChange: (percent) => {
const media = mediaRef.current;
if (media) media.seek(core.rawValueFromPercent(percent));
},
onValueCommit: (percent) => {
const media = mediaRef.current;
if (media) media.seek(core.rawValueFromPercent(percent));