feat(site): list required css imports per skin in preset reference (#1521)

This commit is contained in:
Renzo Delfino
2026-06-12 14:57:42 -03:00
committed by GitHub
parent 4a81e048a1
commit 1145f09e52
9 changed files with 34 additions and 20 deletions
@@ -549,6 +549,7 @@ export { generateFeatureReferences } from './feature-handler.js';
export interface PresetSkinDef {
name: string;
tagName?: string;
cssImport?: string;
}
export interface PresetReference {
@@ -384,7 +384,7 @@ function scanHtmlDirectory(scanDir: string): { skins: PresetSkinDef[]; mediaElem
return { skins, mediaElement };
}
function scanReactDirectory(scanDir: string, barrelPath: string): PresetSkinDef[] {
function scanReactDirectory(scanDir: string, barrelPath: string, presetName: string): PresetSkinDef[] {
const skins: PresetSkinDef[] = [];
if (!fs.existsSync(scanDir)) return skins;
@@ -397,11 +397,16 @@ function scanReactDirectory(scanDir: string, barrelPath: string): PresetSkinDef[
for (const file of files) {
const filePath = path.join(scanDir, file);
const exports = extractValueExports(filePath);
const basename = path.basename(file, path.extname(file));
const cssFile = path.join(scanDir, `${basename}.css`);
const cssImport = fs.existsSync(cssFile) ? `@videojs/react/${presetName}/${basename}.css` : undefined;
for (const name of exports) {
if (isFeatureBundle(name)) continue;
if (isReactSkin(name)) {
skins.push({ name });
const skin: PresetSkinDef = { name };
if (cssImport) skin.cssImport = cssImport;
skins.push(skin);
}
}
}
@@ -426,7 +431,7 @@ function buildPresetReference(preset: PresetInfo, featureBundleMap: Map<string,
// Scan React directory for skins, read barrel for media element
const reactSkins = preset.react
? scanReactDirectory(preset.react.scanDir, preset.react.barrelPath)
? scanReactDirectory(preset.react.scanDir, preset.react.barrelPath, preset.name)
: ([] as PresetSkinDef[]);
const reactMediaElement = preset.react ? findReactMediaElement(preset.react.barrelPath) : undefined;
@@ -940,9 +940,14 @@ describe('Preset pipeline (end-to-end)', () => {
expect(ref.html.mediaElement).toBeUndefined();
});
it('detects React skins', () => {
it('detects React skins with CSS imports', () => {
const skins = findPreset('video')!.reference.react.skins;
expect(skins).toEqual(expect.arrayContaining([{ name: 'VideoSkin' }, { name: 'MinimalVideoSkin' }]));
expect(skins).toEqual(
expect.arrayContaining([
{ name: 'VideoSkin', cssImport: '@videojs/react/video/skin.css' },
{ name: 'MinimalVideoSkin', cssImport: '@videojs/react/video/minimal-skin.css' },
])
);
});
it('excludes React tailwind skins', () => {
@@ -981,9 +986,9 @@ describe('Preset pipeline (end-to-end)', () => {
expect(ref.html.mediaElement).toBeUndefined();
});
it('detects single React skin', () => {
it('detects single React skin with CSS import', () => {
const skins = findPreset('audio')!.reference.react.skins;
expect(skins).toEqual([{ name: 'AudioSkin' }]);
expect(skins).toEqual([{ name: 'AudioSkin', cssImport: '@videojs/react/audio/skin.css' }]);
});
it('detects React media element', () => {
@@ -1022,7 +1027,7 @@ describe('Preset pipeline (end-to-end)', () => {
expect(skinNames).not.toContain('BackgroundVideoPlayerElement');
});
it('detects React skin', () => {
it('detects React skin without CSS import when no CSS file exists', () => {
const skins = findPreset('background')!.reference.react.skins;
expect(skins).toEqual([{ name: 'BackgroundVideoSkin' }]);
});