refactor(packages): dry up core, html, and react UI architecture (#699)

This commit is contained in:
rahim
2026-03-03 23:27:53 -08:00
committed by GitHub
parent 8bdd4ce7fa
commit 1edeadefed
110 changed files with 1349 additions and 1359 deletions
@@ -1,51 +1,20 @@
'use client';
import { PiPButtonCore, PiPButtonDataAttrs } from '@videojs/core';
import { logMissingFeature, selectPiP } from '@videojs/core/dom';
import type { ForwardedRef } from 'react';
import { forwardRef, useState } from 'react';
import { selectPiP } from '@videojs/core/dom';
import { usePlayer } from '../../player/context';
import type { UIComponentProps } from '../../utils/types';
import { renderElement } from '../../utils/use-render';
import { useButton } from '../hooks/use-button';
import { createMediaButton } from '../create-media-button';
export interface PiPButtonProps extends UIComponentProps<'button', PiPButtonCore.State>, PiPButtonCore.Props {}
export const PiPButton = forwardRef(function PiPButton(
componentProps: PiPButtonProps,
forwardedRef: ForwardedRef<HTMLButtonElement>
) {
const { render, className, style, label, disabled, ...elementProps } = componentProps;
const pip = usePlayer(selectPiP);
const [core] = useState(() => new PiPButtonCore());
core.setProps({ label, disabled });
const { getButtonProps, buttonRef } = useButton({
displayName: 'PiPButton',
onActivate: () => core.toggle(pip!),
isDisabled: () => disabled || !pip,
});
if (!pip) {
if (__DEV__) logMissingFeature('PiPButton', 'pip');
return null;
}
const state = core.getState(pip);
return renderElement(
'button',
{ render, className, style },
{
state,
stateAttrMap: PiPButtonDataAttrs,
ref: [forwardedRef, buttonRef],
props: [core.getAttrs(state), elementProps, getButtonProps()],
}
);
/** A button that toggles picture-in-picture. */
export const PiPButton = createMediaButton<PiPButtonCore, PiPButtonProps>({
displayName: 'PiPButton',
core: PiPButtonCore,
stateAttrMap: PiPButtonDataAttrs,
selector: selectPiP,
action: (core, state) => core.toggle(state),
});
export namespace PiPButton {