zoriya/v10
1
0
Fork 0
mirror of https://github.com/zoriya/v10.git synced 2026-08-16 02:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(packages): simplify createPlayer type signatures (#477)

Browse Source
This commit is contained in:
rahim
2026-02-09 16:10:25 +11:00
committed by GitHub
parent 7cc9a76e93
commit 221bd0922f
8 changed files with 248 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/html/src/player/create-player.ts
+22 -11
View File
@@ -1,4 +1,12 @@
import type { AnyPlayerFeature, PlayerStore, PlayerTarget } from '@videojs/core/dom';
import type {
AnyPlayerFeature,
AudioFeatures,
AudioPlayerStore,
PlayerStore,
PlayerTarget,
VideoFeatures,
VideoPlayerStore,
} from '@videojs/core/dom';
import { combine, createStore } from '@videojs/store';
import { type ContainerMixin, createContainerMixin } from '../store/container-mixin';
@@ -45,7 +53,7 @@ export interface CreatePlayerResult<Store extends PlayerStore> {
* import { createPlayer, MediaElement } from '@videojs/html';
*
* const { PlayerElement, PlayerController, context } = createPlayer({
* features: [...features.video],
* features: features.video,
* });
*
* // Simple: register pre-composed PlayerElement
@@ -60,23 +68,26 @@ export interface CreatePlayerResult<Store extends PlayerStore> {
* }
* ```
*/
export function createPlayer(config: CreatePlayerConfig<VideoFeatures>): CreatePlayerResult<VideoPlayerStore>;
export function createPlayer(config: CreatePlayerConfig<AudioFeatures>): CreatePlayerResult<AudioPlayerStore>;
export function createPlayer<const Features extends AnyPlayerFeature[]>(
config: CreatePlayerConfig<Features>
): CreatePlayerResult<PlayerStore<Features>> {
type Store = PlayerStore<Features>;
): CreatePlayerResult<PlayerStore<Features>>;
const slice = combine<PlayerTarget, Features>(...config.features);
export function createPlayer(config: CreatePlayerConfig<AnyPlayerFeature[]>): CreatePlayerResult<PlayerStore> {
const slice = combine<PlayerTarget, AnyPlayerFeature[]>(...config.features);
function create(): Store {
function create(): PlayerStore {
return createStore<PlayerTarget>()(slice);
}
const ctx = playerContext as PlayerContext<Store>;
const PlayerMixin = createPlayerMixin<Store>(ctx, create);
const ctx = playerContext;
const PlayerMixin = createPlayerMixin<PlayerStore>(ctx, create);
const PlayerElement = PlayerMixin(MediaElement);
const ProviderMixin = createProviderMixin<Store>(ctx, create);
const ContainerMixin = createContainerMixin<Store>(ctx);
const ProviderMixin = createProviderMixin<PlayerStore>(ctx, create);
const ContainerMixin = createContainerMixin<PlayerStore>(ctx);
return {
context: ctx,