From 5734c4ad3c3a33e2b3a8aa06fbe908157e6b934e Mon Sep 17 00:00:00 2001 From: rahim Date: Fri, 3 Apr 2026 01:25:33 -0700 Subject: [PATCH] fix(site): remove default attr from storyboard track elements (#1211) --- apps/sandbox/app/shared/html/storyboard.ts | 2 +- apps/sandbox/app/shared/react/storyboard.tsx | 2 +- packages/core/src/dom/store/features/text-track.ts | 1 + .../components/docs/demos/thumbnail/html/css/BasicUsage.html | 1 - .../components/docs/demos/thumbnail/react/css/BasicUsage.tsx | 2 +- site/src/components/home/HeroVideo.tsx | 1 - site/src/content/docs/reference/thumbnail.mdx | 2 -- 7 files changed, 4 insertions(+), 7 deletions(-) diff --git a/apps/sandbox/app/shared/html/storyboard.ts b/apps/sandbox/app/shared/html/storyboard.ts index e0debf8a..12f32b2d 100644 --- a/apps/sandbox/app/shared/html/storyboard.ts +++ b/apps/sandbox/app/shared/html/storyboard.ts @@ -1,3 +1,3 @@ export function renderStoryboard(src?: string | undefined): string { - return src ? `` : ''; + return src ? `` : ''; } diff --git a/apps/sandbox/app/shared/react/storyboard.tsx b/apps/sandbox/app/shared/react/storyboard.tsx index 2cb024ff..c6ead425 100644 --- a/apps/sandbox/app/shared/react/storyboard.tsx +++ b/apps/sandbox/app/shared/react/storyboard.tsx @@ -4,5 +4,5 @@ type StoryboardProps = { export function Storyboard({ src }: StoryboardProps) { if (!src) return null; - return ; + return ; } diff --git a/packages/core/src/dom/store/features/text-track.ts b/packages/core/src/dom/store/features/text-track.ts index 4b7d7353..b7ea47ed 100644 --- a/packages/core/src/dom/store/features/text-track.ts +++ b/packages/core/src/dom/store/features/text-track.ts @@ -16,6 +16,7 @@ export const textTrackFeature = definePlayerFeature({ target().media, (track) => track.kind === 'subtitles' || track.kind === 'captions' ); + if (!subtitlesTracks.length) return false; const showing = subtitlesTracks.some((track: TextTrack) => track.mode === 'showing'); diff --git a/site/src/components/docs/demos/thumbnail/html/css/BasicUsage.html b/site/src/components/docs/demos/thumbnail/html/css/BasicUsage.html index 0de7658a..286ccc33 100644 --- a/site/src/components/docs/demos/thumbnail/html/css/BasicUsage.html +++ b/site/src/components/docs/demos/thumbnail/html/css/BasicUsage.html @@ -13,7 +13,6 @@ kind="metadata" label="thumbnails" src="/docs/demos/thumbnail/basic.vtt" - default /> diff --git a/site/src/components/docs/demos/thumbnail/react/css/BasicUsage.tsx b/site/src/components/docs/demos/thumbnail/react/css/BasicUsage.tsx index 61634751..698915c1 100644 --- a/site/src/components/docs/demos/thumbnail/react/css/BasicUsage.tsx +++ b/site/src/components/docs/demos/thumbnail/react/css/BasicUsage.tsx @@ -17,7 +17,7 @@ export default function TextTrackUsage() { playsInline crossOrigin="anonymous" > - + diff --git a/site/src/components/home/HeroVideo.tsx b/site/src/components/home/HeroVideo.tsx index f8c25713..0ba173b4 100644 --- a/site/src/components/home/HeroVideo.tsx +++ b/site/src/components/home/HeroVideo.tsx @@ -39,7 +39,6 @@ export default function HeroVideo({ kind="metadata" label="thumbnails" src={`https://image.mux.com/${VJS10_DEMO_VIDEO.id}/storyboard.vtt`} - default /> diff --git a/site/src/content/docs/reference/thumbnail.mdx b/site/src/content/docs/reference/thumbnail.mdx index 33dd75cb..37805cd9 100644 --- a/site/src/content/docs/reference/thumbnail.mdx +++ b/site/src/content/docs/reference/thumbnail.mdx @@ -46,7 +46,6 @@ import jsonSpriteHtmlTs from "@/components/docs/demos/thumbnail/html/css/JsonSpr kind="metadata" label="thumbnails" src="https://image.mux.com/BV3YZtogl89mg9VcNBhhnHm02Y34zI1nlMuMQfAbl3dM/storyboard.vtt" - default /> @@ -60,7 +59,6 @@ import jsonSpriteHtmlTs from "@/components/docs/demos/thumbnail/html/css/JsonSpr kind="metadata" label="thumbnails" src="https://image.mux.com/BV3YZtogl89mg9VcNBhhnHm02Y34zI1nlMuMQfAbl3dM/storyboard.vtt" - default />