zoriya/v10
1
0
Fork 0
mirror of https://github.com/zoriya/v10.git synced 2026-08-16 02:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): update e2e menu selectors (#1674)

Browse Source
This commit is contained in:
Sam Potts
2026-06-11 12:29:59 +10:00
committed by GitHub
parent f90a700a00
commit 6b0d3b6b2f
4 changed files with 27 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/e2e/page-objects/player.ts
+3 -11
View File
@@ -166,7 +166,7 @@ export class PlayerPage {
await this.settingsButton.click();
await expect(this.settingsSpeedItem).toBeVisible();
await this.settingsSpeedItem.click();
await expect(this.page.locator(`${SELECTORS.activeMenuPanel} [role="menuitemradio"]`).first()).toBeVisible();
await expect(this.page.locator(SELECTORS.activeMenuOptions).first()).toBeVisible();
}
async openCaptionsSettings(): Promise<void> {
@@ -174,7 +174,7 @@ export class PlayerPage {
await this.settingsButton.click();
await expect(this.settingsCaptionsItem).toBeVisible();
await this.settingsCaptionsItem.click();
await expect(this.page.locator(SELECTORS.activeMenuRadioItems).first()).toBeVisible();
await expect(this.page.locator(SELECTORS.activeMenuOptions).first()).toBeVisible();
}
async getPlaybackRate(): Promise<number> {
@@ -236,16 +236,8 @@ export class PlayerPage {
await this.playbackRateButton.click();
}
const uncheckedPlaybackRateOptions = SELECTORS.openPlaybackRateMenuRadioItems
.split(', ')
.map((selector) => `${selector.trim()}[aria-checked="false"]`)
.join(', ');
const option = this.page
.locator(
usesSettingsMenu
? `${SELECTORS.activeMenuPanel} [role="menuitemradio"][aria-checked="false"]`
: uncheckedPlaybackRateOptions
)
.locator(usesSettingsMenu ? SELECTORS.activeMenuUncheckedOptions : SELECTORS.playbackRateUncheckedOptions)
.first();
await expect(option).toBeVisible({ timeout: 5_000 });
// Menu popovers can intercept pointer events on nested radio items.