zoriya/v10
1
0
Fork 0
mirror of https://github.com/zoriya/v10.git synced 2026-08-16 02:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): update e2e menu selectors (#1674)

Browse Source
This commit is contained in:
Sam Potts
2026-06-11 12:29:59 +10:00
committed by GitHub
parent f90a700a00
commit 6b0d3b6b2f
4 changed files with 27 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/e2e/tests/captions.spec.ts
+5 -4
View File
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { SELECTORS } from '../fixtures/selectors';
import { DATA_ATTRS, SELECTORS } from '../fixtures/selectors';
import { PlayerPage } from '../page-objects/player';
test.describe('Captions', () => {
@@ -11,10 +11,11 @@ test.describe('Captions', () => {
await player.waitForMediaReady();
});
test('captions settings hidden without subtitle tracks', async () => {
test('captions settings are unavailable without subtitle tracks', async () => {
await player.showControls();
await player.settingsButton.click();
await expect(player.settingsCaptionsItem).toBeHidden();
await expect(player.settingsCaptionsItem).toHaveAttribute(DATA_ATTRS.availability, 'unavailable');
await expect(player.settingsCaptionsItem).toHaveAttribute('aria-disabled', 'true');
});
test('captions settings lists tracks when subtitle track is added', async ({ page }) => {
@@ -33,7 +34,7 @@ test.describe('Captions', () => {
await player.showControls();
await player.openCaptionsSettings();
const options = page.locator(SELECTORS.activeMenuRadioItems);
const options = page.locator(SELECTORS.activeMenuOptions);
await expect(options).toHaveCount(2, { timeout: 5_000 });
});
});
apps/e2e/tests/visual/video-skin.spec.ts
+2 -2
View File
@@ -67,8 +67,8 @@ test.describe('Visual — Captions', () => {
await player.showControls();
await player.openCaptionsSettings();
await expect(page.locator(SELECTORS.activeMenuRadioItems)).toHaveCount(2);
await page.locator(SELECTORS.activeMenuRadioItems).nth(1).dispatchEvent('click');
await expect(page.locator(SELECTORS.activeMenuOptions)).toHaveCount(2);
await page.locator(SELECTORS.activeMenuOptions).nth(1).dispatchEvent('click');
// Play briefly so the caption cue at 0:00 activates, then pause
await player.play();