mirror of
https://github.com/zoriya/v10.git
synced 2026-08-16 02:45:09 +00:00
refactor: move time formatting logic to platform components
Move time formatting responsibility from core component state definition to platform-specific components for better separation of concerns: - Core state definition now only provides raw duration value - HTML component calls formatDuration() in _update() method - React component calls formatDuration() in render function - Maintains same functionality with cleaner architecture This approach gives platforms more control over formatting and reduces the responsibility of the core state abstraction. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
committed by
Christian Pillsbury
co-authored by
Claude
parent
2ed219158d
commit
6db4c3c4b8
@@ -3,7 +3,7 @@ import {
|
||||
StateHook,
|
||||
PropsHook,
|
||||
} from '../utils/component-factory';
|
||||
import { durationDisplayStateDefinition } from '@vjs-10/media-store';
|
||||
import { durationDisplayStateDefinition, formatDuration } from '@vjs-10/media-store';
|
||||
import { namedNodeMapToObject } from '../utils/element-utils.js';
|
||||
|
||||
export function getTemplateHTML(
|
||||
@@ -25,9 +25,6 @@ export class DurationDisplayBase extends HTMLElement {
|
||||
_state:
|
||||
| {
|
||||
duration: number | undefined;
|
||||
isValidDuration: boolean;
|
||||
formattedDuration: string;
|
||||
durationPhrase: string;
|
||||
}
|
||||
| undefined;
|
||||
|
||||
@@ -54,21 +51,13 @@ export class DurationDisplayBase extends HTMLElement {
|
||||
return this._state?.duration;
|
||||
}
|
||||
|
||||
get formattedDuration() {
|
||||
return this._state?.formattedDuration || '--:--';
|
||||
}
|
||||
|
||||
get durationPhrase() {
|
||||
return this._state?.durationPhrase || 'Duration unknown';
|
||||
}
|
||||
|
||||
_update(_props: any, state: any) {
|
||||
this._state = state;
|
||||
|
||||
// Update the span content
|
||||
// Update the span content with formatted duration
|
||||
const spanElement = this.shadowRoot?.querySelector('span') as HTMLElement;
|
||||
if (spanElement) {
|
||||
spanElement.textContent = state.formattedDuration;
|
||||
spanElement.textContent = formatDuration(state.duration);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -79,9 +68,6 @@ export class DurationDisplayBase extends HTMLElement {
|
||||
*/
|
||||
export const useDurationDisplayState: StateHook<{
|
||||
duration: number | undefined;
|
||||
isValidDuration: boolean;
|
||||
formattedDuration: string;
|
||||
durationPhrase: string;
|
||||
}> = {
|
||||
keys: [...durationDisplayStateDefinition.keys],
|
||||
transform: (rawState, _mediaStore) => ({
|
||||
@@ -96,9 +82,6 @@ export const useDurationDisplayState: StateHook<{
|
||||
*/
|
||||
export const useDurationDisplayProps: PropsHook<{
|
||||
duration: number | undefined;
|
||||
isValidDuration: boolean;
|
||||
formattedDuration: string;
|
||||
durationPhrase: string;
|
||||
}> = (_state, _element) => {
|
||||
const baseProps: Record<string, any> = {};
|
||||
return baseProps;
|
||||
|
||||
Reference in New Issue
Block a user