From a74b8c09939fe065e9996f628b92e8ba797b50f2 Mon Sep 17 00:00:00 2001 From: Santiago Puppo Date: Wed, 24 Jun 2026 11:09:20 -0300 Subject: [PATCH] refactor: Rename SPF background-looping-video into background-video (#1731) --- .claude/skills/spf-document-use-case/SKILL.md | 8 +-- .../index.html | 4 +- .../main.ts | 16 ++--- .../design/spf/features/buffer-management.md | 2 +- internal/design/spf/features/clusters.md | 2 +- internal/design/spf/use-cases/README.md | 2 +- .../spf/use-cases/audio-only-mode-override.md | 4 +- ...d-looping-video.md => background-video.md} | 14 ++--- .../spf/use-cases/video-only-mode-override.md | 22 +++---- packages/spf/package.json | 8 +-- .../engines/background-looping-video/index.ts | 13 ---- .../adapter.ts | 58 +++++++++--------- .../engine.ts | 42 ++++++------- .../engines/background-video/index.ts | 13 ++++ .../tests/adapter.test.ts | 60 +++++++++---------- .../tests/engine.test.ts | 18 +++--- packages/spf/tsdown.config.ts | 2 +- 17 files changed, 144 insertions(+), 144 deletions(-) rename apps/sandbox/templates/{spf-background-looping-video => spf-background-video}/index.html (98%) rename apps/sandbox/templates/{spf-background-looping-video => spf-background-video}/main.ts (93%) rename internal/design/spf/use-cases/{background-looping-video.md => background-video.md} (95%) delete mode 100644 packages/spf/src/playback/engines/background-looping-video/index.ts rename packages/spf/src/playback/engines/{background-looping-video => background-video}/adapter.ts (78%) rename packages/spf/src/playback/engines/{background-looping-video => background-video}/engine.ts (81%) create mode 100644 packages/spf/src/playback/engines/background-video/index.ts rename packages/spf/src/playback/engines/{background-looping-video => background-video}/tests/adapter.test.ts (83%) rename packages/spf/src/playback/engines/{background-looping-video => background-video}/tests/engine.test.ts (91%) diff --git a/.claude/skills/spf-document-use-case/SKILL.md b/.claude/skills/spf-document-use-case/SKILL.md index f2e552b7..6ffd7905 100644 --- a/.claude/skills/spf-document-use-case/SKILL.md +++ b/.claude/skills/spf-document-use-case/SKILL.md @@ -133,11 +133,11 @@ actual use. consolidate into a single use-case doc with a *Variant-decision signal source* section covering both paths. The Case-1 feature doc does not exist separately in those cases. Not every use case has a Case-1 - sibling — `background-looping-video` has constituent features but no + sibling — `background-video` has constituent features but no single Case-1 axis-counterpart. - **Conflating sibling use cases** — e.g., `video-only-mode-override` and - `background-looping-video` both touch the video-only delivery + `background-video` both touch the video-only delivery composition but address different delivery scenarios (video-without-audio delivery vs Mux background-video product). Check at Step 5: distinct customer story? distinct composition specifics? If yes, separate docs @@ -207,7 +207,7 @@ Common shapes: video-only-mode-override) → constituent features include the parallel Case-1 source-shape feature plus the baseline playback / buffer / selection features. -- Product-scenario use cases (background-looping-video, shorts-player) → +- Product-scenario use cases (background-video, shorts-player) → constituent features include multiple capability features the variant assembles. @@ -404,7 +404,7 @@ phases in, ask: is this really one use case, or is the variant actually a decomposition into multiple use cases? Heuristic: a slice belongs in its own doc if it has (a) a distinct customer story, (b) distinct composition specifics, or (c) independent timeline. Worked example: -`video-only-mode-override` vs `background-looping-video` — both +`video-only-mode-override` vs `background-video` — both exercise video-only delivery composition, distinct customer stories, distinct composition specifics. diff --git a/apps/sandbox/templates/spf-background-looping-video/index.html b/apps/sandbox/templates/spf-background-video/index.html similarity index 98% rename from apps/sandbox/templates/spf-background-looping-video/index.html rename to apps/sandbox/templates/spf-background-video/index.html index afccca25..7b4c4677 100644 --- a/apps/sandbox/templates/spf-background-looping-video/index.html +++ b/apps/sandbox/templates/spf-background-video/index.html @@ -4,7 +4,7 @@ - Sandbox — SPF Background Looping Video + Sandbox — SPF Background Video