diff --git a/.claude/skills/README.md b/.claude/skills/README.md index 72c17d18..2fba165b 100644 --- a/.claude/skills/README.md +++ b/.claude/skills/README.md @@ -16,20 +16,25 @@ Specialized knowledge for AI agents working on Video.js 10. | Reviewing components | `component` → `review/workflow.md` | | Reviewing accessibility | `aria` → `review/workflow.md` | | Accessibility audit | `aria` | -| Committing / creating PRs | `git` | -| Updating AI docs | `claude-update` | +| Committing / creating PRs | `git` or `/commit-pr` | +| Reviewing branch changes | `/review-branch` | +| Analyzing GitHub issues | `/gh-issue` | +| Updating AI docs | `/claude-update` | ## Skills -| Skill | Purpose | Has Review? | -| ------------------------------- | ---------------------------------------------------------------------- | ----------- | -| [api](api/SKILL.md) | API design and DX — extensibility, type safety, progressive disclosure | Yes | -| [aria](aria/SKILL.md) | Accessibility patterns — ARIA, keyboard, focus, media player a11y | Yes | -| [claude-update](claude-update/SKILL.md) | Update CLAUDE.md and skills when introducing new patterns | No | -| [component](component/SKILL.md) | Build headless UI components — compound patterns, state, styling | Yes | -| [docs](docs/SKILL.md) | Write Video.js 10 documentation | Yes | -| [git](git/SKILL.md) | Git workflow — commit messages, PRs, branch naming, scope inference | No | -| [rfc](rfc/SKILL.md) | Write RFCs — design docs, architecture proposals, component specs | No | +| Skill | Purpose | Has Review? | +| --------------------------------------- | ---------------------------------------------------------------------- | ----------- | +| [api](api/SKILL.md) | API design and DX — extensibility, type safety, progressive disclosure | Yes | +| [aria](aria/SKILL.md) | Accessibility patterns — ARIA, keyboard, focus, media player a11y | Yes | +| [claude-update](claude-update/SKILL.md) | Update CLAUDE.md and skills when introducing new patterns | No | +| [commit-pr](commit-pr/SKILL.md) | Commit changes and create/update PRs with conventions | No | +| [component](component/SKILL.md) | Build headless UI components — compound patterns, state, styling | Yes | +| [docs](docs/SKILL.md) | Write Video.js 10 documentation | Yes | +| [gh-issue](gh-issue/SKILL.md) | Analyze GitHub issues and create implementation plans | No | +| [git](git/SKILL.md) | Git workflow — commit messages, PRs, branch naming, scope inference | No | +| [review-branch](review-branch/SKILL.md) | Review branch changes and suggest improvements | No | +| [rfc](rfc/SKILL.md) | Write RFCs — design docs, architecture proposals, component specs | No | ## Review Workflows diff --git a/.claude/skills/claude-update/SKILL.md b/.claude/skills/claude-update/SKILL.md index fc97f3cc..9c7add78 100644 --- a/.claude/skills/claude-update/SKILL.md +++ b/.claude/skills/claude-update/SKILL.md @@ -3,7 +3,6 @@ name: claude-update description: Update CLAUDE.md and skills when introducing new patterns or conventions context: fork disable-model-invocation: true -agent: general-purpose --- # Claude Update diff --git a/.claude/commands/commit-pr.md b/.claude/skills/commit-pr/SKILL.md similarity index 92% rename from .claude/commands/commit-pr.md rename to .claude/skills/commit-pr/SKILL.md index b5a558b8..39a3dd76 100644 --- a/.claude/commands/commit-pr.md +++ b/.claude/skills/commit-pr/SKILL.md @@ -1,6 +1,10 @@ --- -allowed-tools: Bash(git:*), Bash(gh:*), Glob, Grep, Read, question, mcp__github__*, skill -description: Commit all changes and create or update a PR following project conventions +name: commit-pr +description: >- + Commit all changes and create or update a PR following project conventions. + Triggers: "commit and pr", "push changes", "create pull request". +allowed-tools: Bash(git:*), Bash(gh:*), Glob, Grep, Read, question, mcp__github__* +context: fork --- # Commit & PR diff --git a/.claude/commands/gh-issue.md b/.claude/skills/gh-issue/SKILL.md old mode 100755 new mode 100644 similarity index 83% rename from .claude/commands/gh-issue.md rename to .claude/skills/gh-issue/SKILL.md index 229d9fcf..6fb032f1 --- a/.claude/commands/gh-issue.md +++ b/.claude/skills/gh-issue/SKILL.md @@ -1,42 +1,48 @@ --- -allowed-tools: Bash(git:*), Bash(gh:*), Glob, Grep, Read, mcp__github__*, skill -description: Analyze a GitHub issue and create a comprehensive plan to solve it +name: gh-issue +description: >- + Analyze GitHub issues and create a comprehensive plan to solve them. + Triggers: "analyze issue", "plan issue", "investigate issue". +allowed-tools: Bash(git:*), Bash(gh:*), Glob, Grep, Read, mcp__github__* +agent: plan --- # GitHub Issue Analysis -Deep-dive on a GitHub issue. Find the problem and generate a plan. +Deep-dive on one or more GitHub issues. Find the problem and generate a plan. Do not write code. Explain the problem clearly and propose a comprehensive plan to solve it. ## Usage ``` -/gh-issue +/gh-issue ``` -- `issue` (required): GitHub issue number (assumes videojs/v10 repo) or full GitHub issue URL +- `issues` (required): One or more GitHub issue numbers (assumes videojs/v10 repo) or full GitHub issue URLs ### Examples ``` /gh-issue 123 +/gh-issue 123 456 789 /gh-issue https://github.com/videojs/v10/issues/123 +/gh-issue 123 https://github.com/other/repo/issues/456 ``` -## Issue +## Issues $ARGUMENTS -Fetch the issue details using GitHub tools. The argument above can be an issue number (assumes videojs/v10 repo) or a full GitHub issue URL. +Fetch details for each issue using GitHub tools. Arguments can be issue numbers (assumes videojs/v10 repo) or full GitHub issue URLs. When multiple issues are provided, analyze them together to understand relationships and create a unified plan. ## Your Tasks You are an experienced software developer tasked with diagnosing issues. -### Step 1: Fetch and Analyze Issue Type +### Step 1: Fetch and Analyze Issue Types -1. Fetch the issue details using GitHub tools -2. Identify the issue type by examining: +1. Fetch details for each issue using GitHub tools +2. For each issue, identify the type by examining: **Labels** — Look for: @@ -76,7 +82,7 @@ Based on detected type, load the relevant skill for domain expertise: | UI component implementation | `component` | Compound components, polymorphism, styling patterns | | Bug/Feature (general) | `api` | General principles apply | -**Load the skill using the skill tool before proceeding to analysis.** +**Load the skill before proceeding to analysis.** **Notes:** @@ -155,8 +161,8 @@ For **UI Component** issues (with `component` skill): Include: -- Link to the source issue +- Links to all source issues - Related discussions or issues - Relevant skill principles applied -**ONLY CREATE A PLAN. DO NOT WRITE ANY CODE.** Your task is to create a thorough, comprehensive strategy for understanding and resolving the issue. +**ONLY CREATE A PLAN. DO NOT WRITE ANY CODE.** Your task is to create a thorough, comprehensive strategy for understanding and resolving the issues. diff --git a/.claude/commands/review-branch.md b/.claude/skills/review-branch/SKILL.md old mode 100755 new mode 100644 similarity index 96% rename from .claude/commands/review-branch.md rename to .claude/skills/review-branch/SKILL.md index f2958738..6c752629 --- a/.claude/commands/review-branch.md +++ b/.claude/skills/review-branch/SKILL.md @@ -1,6 +1,10 @@ --- -allowed-tools: Bash(git:*), Bash(gh:*), Glob, Grep, Read, mcp__github__*, skill -description: Review changes in the current Git branch and suggest improvements +name: review-branch +description: >- + Review changes in the current Git branch and suggest improvements. + Triggers: "review branch", "review changes", "code review". +allowed-tools: Bash(git:*), Bash(gh:*), Glob, Grep, Read, mcp__github__* +agent: plan --- # Branch Review @@ -60,7 +64,7 @@ Categorize the changed files to determine which review criteria apply: ### Step 3: Load Skills (Optional) -For deeper domain-specific review, load the relevant skill using the skill tool: +For deeper domain-specific review, load the relevant skill: | Category | Load Skill | For Deeper Review | | ------------- | ----------- | ------------------------------ |