zoriya/v10
1
0
Fork 0
mirror of https://github.com/zoriya/v10.git synced 2026-08-16 02:45:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: destroy hls.js instance on media unmount (#749)

Browse Source
This commit is contained in:
Wesley Luyten
2026-03-06 11:30:48 +11:00
committed by GitHub
parent 5fc52aa969
commit c4e8bbd3a2
4 changed files with 21 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react/src/media/hls-video/index.tsx
+4 -3
View File
@@ -1,10 +1,11 @@
import { HlsMedia } from '@videojs/core/dom/media/hls';
import type { PropsWithChildren, VideoHTMLAttributes } from 'react';
import { forwardRef, useEffect, useMemo } from 'react';
import { forwardRef, useMemo } from 'react';
import { useMediaRegistration } from '../../player/context';
import { attachMediaElement } from '../../utils/attach-media-element';
import { mediaProps } from '../../utils/media-props';
import { useComposedRefs } from '../../utils/use-composed-refs';
import { useDestroy } from '../../utils/use-destroy';
export type HlsVideoProps = PropsWithChildren<VideoHTMLAttributes<HTMLVideoElement>>;
@@ -12,9 +13,9 @@ export const HlsVideo = forwardRef<HTMLVideoElement, HlsVideoProps>(({ children,
const mediaApi = useMemo(() => new HlsMedia(), []);
const setMedia = useMediaRegistration();
useEffect(() => {
useDestroy(mediaApi, () => {
setMedia?.(mediaApi);
}, [mediaApi, setMedia]);
});
const composedRef = useComposedRefs(attachMediaElement(mediaApi), ref);
return (