From d8809c5abe066a39a14b423be239fe7c0c234632 Mon Sep 17 00:00:00 2001 From: Christian Pillsbury Date: Mon, 8 Sep 2025 20:17:52 -0700 Subject: [PATCH] fix(media-store): resolve TypeScript declaration generation build issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Switch from pure tsup to hybrid tsup + tsc approach for declaration generation - Update build script to use 'tsup && tsc --emitDeclarationOnly' - Disable tsup's DTS generation to avoid conflicts with TypeScript composite projects - Ensure all component state definitions have proper .d.ts files generated - Fix build pipeline that was requiring manual dist file modifications This resolves the fundamental build system issue where TypeScript declarations weren't being properly generated, eliminating the need for manual dist file edits. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- packages/core/media-store/package.json | 2 +- packages/core/media-store/tsup.config.ts | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/core/media-store/package.json b/packages/core/media-store/package.json index eee29c2c..0ac91677 100644 --- a/packages/core/media-store/package.json +++ b/packages/core/media-store/package.json @@ -16,7 +16,7 @@ "dist" ], "scripts": { - "build": "tsup", + "build": "tsup && tsc --emitDeclarationOnly", "test": "echo \"No tests yet\"", "clean": "rm -rf dist" }, diff --git a/packages/core/media-store/tsup.config.ts b/packages/core/media-store/tsup.config.ts index 108499a4..826c997b 100644 --- a/packages/core/media-store/tsup.config.ts +++ b/packages/core/media-store/tsup.config.ts @@ -11,11 +11,6 @@ export default defineConfig({ /^@vjs-10\//, /^[^.]/, ], - // Generate TypeScript declarations with custom config - dts: { - compilerOptions: { - composite: false, - incremental: false, - }, - }, + // Disable tsup's dts generation - we'll use tsc directly + dts: false, }); \ No newline at end of file