zoriya/EntityFrameworkCore.Projectables
1
0
Fork 0
mirror of https://github.com/zoriya/EntityFrameworkCore.Projectables.git synced 2025-12-06 05:56:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #61 from koenbeuk/issue-53

Browse Source 
Simplified type resolution
This commit is contained in:
Koen
2023-03-09 19:24:47 +00:00
committed by GitHub
parent 6de068b2c8 220fe4f58b
commit 88cebbcabc
3 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/EntityFrameworkCore.Projectables.Generator/ExpressionSyntaxRewriter.cs
View File

@@ -214,14 +214,9 @@ namespace EntityFrameworkCore.Projectables.Generator
// if this node refers to a named type which is not yet fully qualified, we want to fully qualify it
if (symbol.Kind is SymbolKind.NamedType && node.Parent?.Kind() is not SyntaxKind.QualifiedName)
{
var typeInfo = _semanticModel.GetTypeInfo(node);
if (typeInfo.Type is not null)
{
return SyntaxFactory.ParseTypeName(
typeInfo.Type.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat)
).WithLeadingTrivia(node.GetLeadingTrivia());
}
return SyntaxFactory.ParseTypeName(
symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat)
).WithLeadingTrivia(node.GetLeadingTrivia());
}
}

2
tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.MixPrimaryConstructorAndProperties.verified.txt
View File

@@ -7,7 +7,7 @@ namespace EntityFrameworkCore.Projectables.Generated
{
static global::System.Linq.Expressions.Expression<global::System.Func<global::Foo.EntityExtensions.Entity, global::Foo.EntityExtensions.Entity>> Expression()
{
return (global::Foo.EntityExtensions.Entity entity) => new Entity(entity.Id)
return (global::Foo.EntityExtensions.Entity entity) => new global::Foo.EntityExtensions.Entity(entity.Id)
{FullName = entity.FullName};
}
}

1
tests/EntityFrameworkCore.Projectables.Generator.Tests/ProjectionExpressionGeneratorTests.cs
View File

@@ -1615,7 +1615,6 @@ class EntityBase<TId> where TId : ICloneable, new() {
return Verifier.Verify(result.GeneratedTrees[0].ToString());
}
#region Helpers
Compilation CreateCompilation(string source, bool expectedToCompile = true)