zoriya/go-astisub
1
0
Fork 0
mirror of https://github.com/zoriya/go-astisub.git synced 2026-08-16 02:33:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Not returning error on .srt positions

Browse Source
This commit is contained in:
Quentin Renard
2020-11-25 09:35:50 +01:00
parent a792156893
commit 0e2e94aea6
2 changed files with 15 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
srt.go
+14 -6
View File
@@ -75,14 +75,22 @@ func ReadFromSRT(i io.Reader) (o *Subtitles, err error) {
// Fetch Index
s.Index, _ = strconv.Atoi(index.String())
// Fetch time boundaries
boundaries := strings.Split(line, srtTimeBoundariesSeparator)
if s.StartAt, err = parseDurationSRT(boundaries[0]); err != nil {
err = fmt.Errorf("astisub: line %d: parsing srt duration %s failed: %w", lineNum, boundaries[0], err)
// Extract time boundaries
s1 := strings.Split(line, srtTimeBoundariesSeparator)
if l := len(s1); l < 2 {
err = fmt.Errorf("astisub: line %d: time boundaries has only %d element(s)", lineNum, l)
return
}
if s.EndAt, err = parseDurationSRT(boundaries[1]); err != nil {
err = fmt.Errorf("astisub: line %d: parsing srt duration %s failed: %w", lineNum, boundaries[1], err)
// We do this to eliminate extra stuff like positions which are not documented anywhere
s2 := strings.Split(s1[1], " ")
// Parse time boundaries
if s.StartAt, err = parseDurationSRT(s1[0]); err != nil {
err = fmt.Errorf("astisub: line %d: parsing srt duration %s failed: %w", lineNum, s1[0], err)
return
}
if s.EndAt, err = parseDurationSRT(s2[0]); err != nil {
err = fmt.Errorf("astisub: line %d: parsing srt duration %s failed: %w", lineNum, s2[0], err)
return
}
testdata/example-in.srt
Vendored
+1 -1
View File
@@ -3,7 +3,7 @@
(deep rumbling)
2
00:02:04,08 --> 00:02:07,12
00:02:04,08 --> 00:02:07,12 X1:40 X2:600 Y1:20 Y2:50
MAN:
How did we end up here?