zoriya/go-astisub
1
0
Fork 0
mirror of https://github.com/zoriya/go-astisub.git synced 2026-08-16 02:33:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix vertical position conversion from stl teletext to webvtt (#88)

Browse Source 
* fix vertical position conversion from stl teletext to webvtt

* add comments to teletext vertical position conversion to vtt
This commit is contained in:
David Le Corfec
2023-06-23 09:06:54 +02:00
committed by GitHub
parent 5214480cf0
commit 9f9e6a8f36
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
subtitles.go
+9
View File
@@ -261,8 +261,17 @@ func (sa *StyleAttributes) propagateSTLAttributes() {
sa.WebVTTAlign = "left"
}
}
// converts STL vertical position (row number) to WebVTT line percentage
if sa.STLPosition != nil && sa.STLPosition.MaxRows > 0 {
// in-vision vertical position ranges from 0 to maxrows (maxrows <= 99)
sa.WebVTTLine = fmt.Sprintf("%d%%", sa.STLPosition.VerticalPosition*100/sa.STLPosition.MaxRows)
// teletext vertical position ranges from 1 to 23; as webvtt line percentage starts
// from the top at 0%, substract 1 to the stl position to get a better conversion.
// Especially apparent on Shaka player, where a single line at vp 22 would be half
// out of bounds at 95% (22*100/23), and fine at 91% (21*100/23)
if sa.STLPosition.MaxRows == 23 && sa.STLPosition.VerticalPosition > 0 {
sa.WebVTTLine = fmt.Sprintf("%d%%", (sa.STLPosition.VerticalPosition-1)*100/sa.STLPosition.MaxRows)
}
}
}