use IReadOnlyList as return type

This commit is contained in:
lbargaoanu
2014-01-20 10:48:06 +02:00
parent 7af19ab319
commit 1d6729f6c6
4 changed files with 4 additions and 5 deletions
@@ -115,7 +115,6 @@ public class UsersClientTests
Assert.NotEmpty(emails);
var email = emails.First();
Assert.True(email.Primary);
Assert.False(email.Verified);
}
}
}
+1 -1
View File
@@ -40,6 +40,6 @@ namespace Octokit
/// </summary>
/// <returns></returns>
[SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
Task<IReadOnlyCollection<EmailAddress>> GetEmails();
Task<IReadOnlyList<EmailAddress>> GetEmails();
}
}
+2 -2
View File
@@ -64,9 +64,9 @@ namespace Octokit
/// Returns emails for the current user.
/// </summary>
/// <returns></returns>
public Task<IReadOnlyCollection<EmailAddress>> GetEmails()
public Task<IReadOnlyList<EmailAddress>> GetEmails()
{
return ApiConnection.Get<IReadOnlyCollection<EmailAddress>>(ApiUrls.Emails(), null);
return ApiConnection.GetAll<EmailAddress>(ApiUrls.Emails(), null);
}
}
}
+1 -1
View File
@@ -1638,7 +1638,7 @@ namespace Octokit
Type genericDefinition = type.GetGenericTypeDefinition();
return genericDefinition == typeof(IList<>) || genericDefinition == typeof(ICollection<>) || genericDefinition == typeof(IEnumerable<>) || genericDefinition == typeof(IReadOnlyCollection<>);
return genericDefinition == typeof(IList<>) || genericDefinition == typeof(ICollection<>) || genericDefinition == typeof(IEnumerable<>);
}
public static bool IsAssignableFrom(Type type1, Type type2)