ApiConnection, Connection

This commit is contained in:
Mordechai Zuber
2015-05-19 09:28:52 +03:00
parent c8a7cd8c17
commit 347da7b938
2 changed files with 39 additions and 39 deletions
+23 -23
View File
@@ -51,8 +51,8 @@ namespace Octokit.Tests.Http
{
var getUri = new Uri("anything", UriKind.Relative);
var client = new ApiConnection(Substitute.For<IConnection>());
await AssertEx.Throws<ArgumentNullException>(async () => await client.Get<object>(null));
await AssertEx.Throws<ArgumentNullException>(async () => await client.Get<object>(getUri, new Dictionary<string, string>(), null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Get<object>(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Get<object>(getUri, new Dictionary<string, string>(), null));
}
}
@@ -77,7 +77,7 @@ namespace Octokit.Tests.Http
public async Task EnsuresArgumentNotNull()
{
var client = new ApiConnection(Substitute.For<IConnection>());
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetHtml(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetHtml(null));
}
}
@@ -106,14 +106,14 @@ namespace Octokit.Tests.Http
var client = new ApiConnection(Substitute.For<IConnection>());
// One argument
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll<object>(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAll<object>(null));
// Two argument
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await client.GetAll<object>(null, new Dictionary<string, string>()));
// Three arguments
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await client.GetAll<object>(null, new Dictionary<string, string>(), "accepts"));
}
}
@@ -158,9 +158,9 @@ namespace Octokit.Tests.Http
{
var connection = new ApiConnection(Substitute.For<IConnection>());
var patchUri = new Uri("", UriKind.Relative);
await AssertEx.Throws<ArgumentNullException>(async () => await connection.Patch<object>(null, new object()));
await AssertEx.Throws<ArgumentNullException>(async () => await connection.Patch<object>(patchUri, null));
await AssertEx.Throws<ArgumentNullException>(async () => await connection.Patch<object>(patchUri, new object(), null));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Patch<object>(null, new object()));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Patch<object>(patchUri, null));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Patch<object>(patchUri, new object(), null));
}
}
@@ -219,15 +219,15 @@ namespace Octokit.Tests.Http
var connection = new ApiConnection(Substitute.For<IConnection>());
// 1 parameter overload
await Assert.ThrowsAsync<ArgumentNullException>(async () => await connection.Post(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Post(null));
// 2 parameter overload
await Assert.ThrowsAsync<ArgumentNullException>(async () => await connection.Post<object>(null, new object()));
await Assert.ThrowsAsync<ArgumentNullException>(async () => await connection.Post<object>(postUri, null));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Post<object>(null, new object()));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Post<object>(postUri, null));
// 3 parameters
await Assert.ThrowsAsync<ArgumentNullException>(async () => await connection.Post<object>(null, new MemoryStream(), "anAccept", "some-content-type"));
await Assert.ThrowsAsync<ArgumentNullException>(async () => await connection.Post<object>(postUri, null, "anAccept", "some-content-type"));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Post<object>(null, new MemoryStream(), "anAccept", "some-content-type"));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Post<object>(postUri, null, "anAccept", "some-content-type"));
}
}
@@ -272,19 +272,19 @@ namespace Octokit.Tests.Http
var connection = new ApiConnection(Substitute.For<IConnection>());
// 2 parameter overload
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await connection.Put<object>(null, new object()));
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await connection.Put<object>(putUri, null));
// 3 parameters
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await connection.Put<object>(null, new MemoryStream(), "two-factor"));
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await connection.Put<object>(putUri, null, "two-factor"));
await AssertEx.Throws<ArgumentNullException>(async () =>
await Assert.ThrowsAsync<ArgumentNullException>(async () =>
await connection.Put<object>(putUri, new MemoryStream(), null));
await AssertEx.Throws<ArgumentException>(async () =>
await Assert.ThrowsAsync<ArgumentException>(async () =>
await connection.Put<object>(putUri, new MemoryStream(), ""));
}
}
@@ -309,7 +309,7 @@ namespace Octokit.Tests.Http
public async Task EnsuresArgumentNotNull()
{
var connection = new ApiConnection(Substitute.For<IConnection>());
await AssertEx.Throws<ArgumentNullException>(async () => await connection.Delete(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.Delete(null));
}
}
@@ -342,7 +342,7 @@ namespace Octokit.Tests.Http
connection.GetResponse<object>(queuedOperationUrl, Args.CancellationToken).Returns(Task.FromResult(response));
var apiConnection = new ApiConnection(connection);
await AssertEx.Throws<ApiException>(async () => await apiConnection.GetQueuedOperation<object>(queuedOperationUrl, Args.CancellationToken));
await Assert.ThrowsAsync<ApiException>(() => apiConnection.GetQueuedOperation<object>(queuedOperationUrl, Args.CancellationToken));
}
[Fact]
@@ -413,7 +413,7 @@ namespace Octokit.Tests.Http
public async Task EnsuresArgumentNotNull()
{
var connection = new ApiConnection(Substitute.For<IConnection>());
await AssertEx.Throws<ArgumentNullException>(async () => await connection.GetQueuedOperation<object>(null, CancellationToken.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => connection.GetQueuedOperation<object>(null, CancellationToken.None));
}
}
+16 -16
View File
@@ -97,8 +97,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<AuthorizationException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<AuthorizationException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.NotNull(exception);
}
@@ -121,8 +121,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<AuthorizationException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<AuthorizationException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal(HttpStatusCode.Unauthorized, exception.StatusCode);
}
@@ -148,8 +148,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<TwoFactorRequiredException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<TwoFactorRequiredException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal(expectedFactorType, exception.TwoFactorType);
}
@@ -172,8 +172,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<ApiValidationException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<ApiValidationException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal("Validation Failed", exception.Message);
Assert.Equal("key is already in use", exception.ApiError.Errors[0].Message);
@@ -196,8 +196,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<RateLimitExceededException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<RateLimitExceededException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal("API rate limit exceeded. See http://developer.github.com/v3/#rate-limiting for details.",
exception.Message);
@@ -220,8 +220,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<LoginAttemptsExceededException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<LoginAttemptsExceededException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal("Maximum number of login attempts exceeded", exception.Message);
Assert.Equal("http://developer.github.com/v3", exception.ApiError.DocumentationUrl);
@@ -244,8 +244,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<NotFoundException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<NotFoundException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal("GONE BYE BYE!", exception.Message);
}
@@ -266,8 +266,8 @@ namespace Octokit.Tests.Http
httpClient,
Substitute.For<IJsonSerializer>());
var exception = await AssertEx.Throws<ForbiddenException>(
async () => await connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
var exception = await Assert.ThrowsAsync<ForbiddenException>(
() => connection.GetResponse<string>(new Uri("endpoint", UriKind.Relative)));
Assert.Equal("YOU SHALL NOT PASS!", exception.Message);
}