zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-06 07:16:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Thought the github api did not correctly add the first event in the list of 'add_events'.

Browse Source 
Got answer from GitHub that it is because the 'follow' event is no longer supported.
This commit is contained in:
Kristian Hald
2015-03-23 18:04:39 +01:00
parent 8f3827ee9b
commit 3cf54d291c
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs
View File

@@ -78,7 +78,7 @@ namespace Octokit.Tests.Integration.Clients
Assert.NotNull(hook.CreatedAt);
Assert.NotNull(hook.UpdatedAt);
// TODO: KHA - It seems that even though I provide 'false' to active the response states that it is active
// TODO: KristianHald - It seems that even though I provide 'false' to active, the response states that it is active. Reported to github
//Assert.Equal(false, hook.Active);
}
@@ -105,12 +105,11 @@ namespace Octokit.Tests.Integration.Clients
var editRepositoryHook = new EditRepositoryHook
{
AddEvents = new[] { "follow", "pull_request" }
AddEvents = new[] { "pull_request" }
};
var actualHook = await github.Repository.Hooks.Edit(_fixture.RepositoryOwner, _fixture.RepositoryName, _fixture.ExpectedHook.Id, editRepositoryHook);
// TODO: KHA - It seems that the first AddEvent is either not provided or correctly returned by github
//Assert.Equal(new[] { "delete", "follow", "pull_request" }.ToList(), actualHook.Events.ToList());
Assert.Equal(new[] { "delete", "pull_request" }.ToList(), actualHook.Events.ToList());
}
}