zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-04 03:16:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Fix]: The methods GetAllForCurrentWithTimestamps and GetAllForUserWithTimestamps now return timestamps.

Browse Source 
* Fix unit tests.

* Fix integration tests.

* Fix to use `AcceptHeaders.StarJson`.

---------

Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
This commit is contained in:
MareMare
2024-01-03 07:12:19 +09:00
committed by GitHub
parent f9c5b6992a
commit 3e92a697b4
3 changed files with 20 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests.Integration/Clients/StarredClientTests.cs
+8
View File
@@ -167,6 +167,8 @@ namespace Octokit.Tests.Integration.Clients
var repo = stars.FirstOrDefault(star => star.Repo.Owner.Login == _repositoryContext.RepositoryOwner && star.Repo.Name == _repositoryContext.RepositoryName);
Assert.NotNull(repo);
Assert.NotEqual(DateTimeOffset.MinValue, repo.StarredAt);
Assert.NotNull(repo.Repo);
}
[IntegrationTest]
@@ -232,6 +234,8 @@ namespace Octokit.Tests.Integration.Clients
var repo = stars.FirstOrDefault(star => star.Repo.Owner.Login == _repositoryContext.RepositoryOwner && star.Repo.Name == _repositoryContext.RepositoryName);
Assert.NotNull(repo);
Assert.NotEqual(DateTimeOffset.MinValue, repo.StarredAt);
Assert.NotNull(repo.Repo);
for (int i = 1; i < stars.Count; i++)
{
@@ -456,6 +460,8 @@ namespace Octokit.Tests.Integration.Clients
var star = stars.FirstOrDefault(repositoryStar => repositoryStar.Repo.Owner.Login == _repositoryContext.RepositoryOwner && repositoryStar.Repo.Name == _repositoryContext.RepositoryName);
Assert.NotNull(star);
Assert.NotEqual(DateTimeOffset.MinValue, star.StarredAt);
Assert.NotNull(star.Repo);
}
[IntegrationTest]
@@ -521,6 +527,8 @@ namespace Octokit.Tests.Integration.Clients
var repo = stars.FirstOrDefault(repository => repository.Repo.Owner.Login == _repositoryContext.RepositoryOwner && repository.Repo.Name == _repositoryContext.RepositoryName);
Assert.NotNull(repo);
Assert.NotEqual(DateTimeOffset.MinValue, repo.StarredAt);
Assert.NotNull(repo.Repo);
for (int i = 1; i < stars.Count; i++)
{
Octokit.Tests/Clients/StarredClientTests.cs
+8 -8
View File
@@ -99,7 +99,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForCurrentWithTimestamps();
connection.Received().GetAll<RepositoryStar>(endpoint, null, Args.ApiOptions);
connection.Received().GetAll<RepositoryStar>(endpoint, null, AcceptHeaders.StarJson, Args.ApiOptions);
}
[Fact]
@@ -118,7 +118,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForCurrentWithTimestamps(options);
connection.Received().GetAll<RepositoryStar>(endpoint, null, options);
connection.Received().GetAll<RepositoryStar>(endpoint, null, AcceptHeaders.StarJson, options);
}
[Fact]
@@ -132,7 +132,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForCurrentWithTimestamps(request);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), Args.ApiOptions);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), AcceptHeaders.StarJson, Args.ApiOptions);
}
[Fact]
@@ -153,7 +153,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForCurrentWithTimestamps(request, options);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), options);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), AcceptHeaders.StarJson, options);
}
[Fact]
@@ -250,7 +250,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForUserWithTimestamps("banana");
connection.Received().GetAll<RepositoryStar>(endpoint, null, Args.ApiOptions);
connection.Received().GetAll<RepositoryStar>(endpoint, null, AcceptHeaders.StarJson, Args.ApiOptions);
}
[Fact]
@@ -269,7 +269,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForUserWithTimestamps("banana", options);
connection.Received().GetAll<RepositoryStar>(endpoint, null, options);
connection.Received().GetAll<RepositoryStar>(endpoint, null, AcceptHeaders.StarJson, options);
}
[Fact]
@@ -283,7 +283,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForUserWithTimestamps("banana", starredRequest);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), Args.ApiOptions);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), AcceptHeaders.StarJson, Args.ApiOptions);
}
[Fact]
@@ -304,7 +304,7 @@ namespace Octokit.Tests.Clients
await client.GetAllForUserWithTimestamps("banana", starredRequest, options);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), options);
connection.Received().GetAll<RepositoryStar>(endpoint, Arg.Is<IDictionary<string, string>>(d => d.Count == 2 && d["direction"] == "asc"), AcceptHeaders.StarJson, options);
}
[Fact]
Octokit/Clients/StarredClient.cs
+4 -4
View File
@@ -177,7 +177,7 @@ namespace Octokit
{
Ensure.ArgumentNotNull(options, nameof(options));
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.Starred(), null, options);
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.Starred(), null, AcceptHeaders.StarJson, options);
}
/// <summary>
@@ -237,7 +237,7 @@ namespace Octokit
Ensure.ArgumentNotNull(request, nameof(request));
Ensure.ArgumentNotNull(options, nameof(options));
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.Starred(), request.ToParametersDictionary(), options);
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.Starred(), request.ToParametersDictionary(), AcceptHeaders.StarJson, options);
}
/// <summary>
@@ -293,7 +293,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(user, nameof(user));
Ensure.ArgumentNotNull(options, nameof(options));
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.StarredByUser(user), null, options);
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.StarredByUser(user), null, AcceptHeaders.StarJson, options);
}
/// <summary>
@@ -359,7 +359,7 @@ namespace Octokit
Ensure.ArgumentNotNull(request, nameof(request));
Ensure.ArgumentNotNull(options, nameof(options));
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.StarredByUser(user), request.ToParametersDictionary(), options);
return ApiConnection.GetAll<RepositoryStar>(ApiUrls.StarredByUser(user), request.ToParametersDictionary(), AcceptHeaders.StarJson, options);
}
/// <summary>