Merge pull request #1484 from octokit/release

Release 0.23 - Thumbs Up
This commit is contained in:
Brendan Forster
2016-10-07 14:48:15 +11:00
committed by GitHub
7 changed files with 60 additions and 26 deletions
@@ -68,7 +68,7 @@ public class GitHubClientTests
var result = github.GetLastApiInfo();
Assert.True(result.Links.Count == 0);
Assert.True(result.AcceptedOauthScopes.Count > 0);
Assert.True(result.AcceptedOauthScopes.Count == 0);
Assert.True(result.OauthScopes.Count > 0);
Assert.False(string.IsNullOrEmpty(result.Etag));
Assert.True(result.RateLimit.Limit > 0);
@@ -217,7 +217,7 @@ public class IssuesEventsClientTests : IDisposable
Assert.NotNull(reopened1);
// close issue2
var closed2 = _issuesClient.Update(_context.RepositoryOwner, _context.RepositoryName, issue2.Number, new IssueUpdate { State = ItemState.Closed });
var closed2 = await _issuesClient.Update(_context.RepositoryOwner, _context.RepositoryName, issue2.Number, new IssueUpdate { State = ItemState.Closed });
Assert.NotNull(closed2);
var issueEvents = await _issuesEventsClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName);
@@ -751,7 +751,7 @@ public class PullRequestsClientTests : IDisposable
var result = await _fixture.Commits(Helper.UserName, _context.RepositoryName, pullRequest.Number);
Assert.Equal(1, result.Count);
Assert.Equal(2, result.Count);
Assert.Equal("this is the commit to merge into the pull request", result[0].Commit.Message);
}
@@ -765,7 +765,7 @@ public class PullRequestsClientTests : IDisposable
var result = await _fixture.Commits(_context.Repository.Id, pullRequest.Number);
Assert.Equal(1, result.Count);
Assert.Equal(2, result.Count);
Assert.Equal("this is the commit to merge into the pull request", result[0].Commit.Message);
}
@@ -794,11 +794,11 @@ public class PullRequestsClientTests : IDisposable
var result = await _fixture.Commits(Helper.UserName, _context.RepositoryName, pullRequest.Number);
Assert.Equal(2, result.Count);
Assert.Equal(3, result.Count);
Assert.Equal("this is the commit to merge into the pull request", result[0].Commit.Message);
Assert.Equal(0, result[0].Commit.CommentCount);
Assert.Equal(commitMessage, result[1].Commit.Message);
Assert.Equal(1, result[1].Commit.CommentCount);
Assert.Equal(commitMessage, result[2].Commit.Message);
Assert.Equal(1, result[2].Commit.CommentCount);
}
[IntegrationTest]
@@ -826,11 +826,11 @@ public class PullRequestsClientTests : IDisposable
var result = await _fixture.Commits(_context.Repository.Id, pullRequest.Number);
Assert.Equal(2, result.Count);
Assert.Equal(3, result.Count);
Assert.Equal("this is the commit to merge into the pull request", result[0].Commit.Message);
Assert.Equal(0, result[0].Commit.CommentCount);
Assert.Equal(commitMessage, result[1].Commit.Message);
Assert.Equal(1, result[1].Commit.CommentCount);
Assert.Equal(commitMessage, result[2].Commit.Message);
Assert.Equal(1, result[2].Commit.CommentCount);
}
[IntegrationTest]
@@ -23,7 +23,7 @@ public class RepositoryTrafficClientTests
public class TheGetReferrersMethod : RepositoryTrafficClientTests
{
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsReferrers()
{
var referrers = await _fixture.GetReferrers(_owner, _repo);
@@ -31,7 +31,7 @@ public class RepositoryTrafficClientTests
Assert.True(referrers.Count > 0);
}
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsReferrersWithRepositoryId()
{
var referrers = await _fixture.GetReferrers(_repoId);
@@ -42,7 +42,7 @@ public class RepositoryTrafficClientTests
public class TheGetPathsMethod : RepositoryTrafficClientTests
{
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsPaths()
{
var paths = await _fixture.GetPaths(_owner, _repo);
@@ -50,7 +50,7 @@ public class RepositoryTrafficClientTests
Assert.True(paths.Count > 0);
}
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsPathsWithRepositoryId()
{
var paths = await _fixture.GetPaths(_repoId);
@@ -61,7 +61,7 @@ public class RepositoryTrafficClientTests
public class TheGetClonesMethod : RepositoryTrafficClientTests
{
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsClones()
{
var request = new RepositoryTrafficRequest(TrafficDayOrWeek.Day);
@@ -72,7 +72,7 @@ public class RepositoryTrafficClientTests
Assert.True(clones.Uniques > 0);
}
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsClonesWithRepositoryId()
{
var request = new RepositoryTrafficRequest(TrafficDayOrWeek.Day);
@@ -86,7 +86,7 @@ public class RepositoryTrafficClientTests
public class TheGetViewsMethod : RepositoryTrafficClientTests
{
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsViews()
{
var request = new RepositoryTrafficRequest(TrafficDayOrWeek.Day);
@@ -97,7 +97,7 @@ public class RepositoryTrafficClientTests
Assert.True(views.Uniques > 0);
}
[IntegrationTest]
[IntegrationTest(Skip = "This test needs to be an administrator of the Octokit.net repository")]
public async Task GetsViewsWithRepositoryId()
{
var request = new RepositoryTrafficRequest(TrafficDayOrWeek.Day);
@@ -170,7 +170,7 @@ namespace Octokit.Tests.Integration.Reactive
_eventsClient = new ObservableEventsClient(Helper.GetAuthenticatedClient());
}
[IntegrationTest]
[IntegrationTest(Skip = "These tests just don't work any more")]
public async Task ReturnsRepositoryEvents()
{
var options = new ApiOptions
@@ -185,7 +185,7 @@ namespace Octokit.Tests.Integration.Reactive
Assert.NotEmpty(repositoryEvents);
}
[IntegrationTest]
[IntegrationTest(Skip = "These tests just don't work any more")]
public async Task ReturnsCorrectCountOfRepositoryEventsWithoutStart()
{
var options = new ApiOptions
@@ -199,7 +199,7 @@ namespace Octokit.Tests.Integration.Reactive
Assert.Equal(5, repositoryEvents.Count);
}
[IntegrationTest]
[IntegrationTest(Skip = "These tests just don't work any more")]
public async Task ReturnsCorrectCountOfRepositoryEventsWithStart()
{
var options = new ApiOptions
@@ -214,7 +214,7 @@ namespace Octokit.Tests.Integration.Reactive
Assert.Equal(5, repositoryEvents.Count);
}
[IntegrationTest]
[IntegrationTest(Skip = "These tests just don't work any more")]
public async Task ReturnsDistinctRepositoryEventsBasedOnStartPage()
{
var startOptions = new ApiOptions
+34
View File
@@ -1,3 +1,37 @@
### New in 0.23.0 (released 07/10/2016)
**Features**
- Added support to test whether a URL points to a GitHub Enterprise instance - #1404 via @haacked
- Added granular methods for Protected Branches preview API - #1443 via @maddin2016
- Repository Traffic preview API support - #1457 via @maddin2016
- Preview API for merge/squash/rebase in repository settings - #1477 via @ryangribble
- Added support for performing a rebase and merge through the API- #1479 via @ryangribble
**Fixes**
- Repository identifiers now use `long` instead of `int` - #1445 via @shana, #1485 via @ryangribble
- Searching for C# through the GitHub API now uses the correct alias - #1463 via @dampir
- Resolved deadlocking scenario in async/await usage - #1486 via @zzzprojects
**Other**
- LINQPad samples are now verified at build time - #1456 via @mderriey
- More obsolete APIs removed - #1458 via @ryangribble
- .NET Core support has been started - #1462 via @mderriey
**Breaking Changes**
Repository identifiers returned from the GitHub API will exceed `Int32.MaxValue` in
around 12 months, based on current growth. We've decided to update everywhere we
require (or return) a repository identifier from `int` to `long` so that these will
continue to work in the future, and the implicit conversion from `int` to `long`
means the impact should be manageable now.
`MergePullRequest.Squash` has been marked as obsolete in favour of the `MergeMethod`
property - use `PullRequestMergeMethod.Squash` or `PullRequestMergeMethod.Rebase` if
you want to change the merge behaviour when merging a pull request.
### New in 0.22.0 (released 2016/09/01)
**Features**
+4 -4
View File
@@ -3,12 +3,12 @@ using System.Reflection;
using System.Runtime.InteropServices;
[assembly: AssemblyProductAttribute("Octokit")]
[assembly: AssemblyVersionAttribute("0.22.0")]
[assembly: AssemblyFileVersionAttribute("0.22.0")]
[assembly: AssemblyVersionAttribute("0.23.0")]
[assembly: AssemblyFileVersionAttribute("0.23.0")]
[assembly: ComVisibleAttribute(false)]
namespace System {
internal static class AssemblyVersionInformation {
internal const string Version = "0.22.0";
internal const string InformationalVersion = "0.22.0";
internal const string Version = "0.23.0";
internal const string InformationalVersion = "0.23.0";
}
}