zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-08 04:40:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Making the since parameter required

Browse Source 
Adding 💄 `Task.FromResult` to tests
This commit is contained in:
Henrik Andersson
2015-04-07 07:15:14 +10:00
parent ca01a2f2e8
commit 68840e317f
7 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs
+1 -1
View File
@@ -558,7 +558,7 @@ public class RepositoriesClientTests
{
var github = Helper.GetAuthenticatedClient();
var request = new PublicRepositoryRequest { Since = 32732250 };
var request = new PublicRepositoryRequest(32732250);
var repositories = await github.Repository.GetAllPublic(request);
Assert.NotNull(repositories);
Octokit.Tests.Integration/Reactive/ObservableRepositoriesClientTests.cs
+1 -4
View File
@@ -37,10 +37,7 @@ namespace Octokit.Tests.Integration
var github = Helper.GetAuthenticatedClient();
var client = new ObservableRepositoriesClient(github);
var request = new PublicRepositoryRequest
{
Since = 32732250
};
var request = new PublicRepositoryRequest(32732250);
var repositories = await client.GetAllPublic(request).ToArray();
Assert.NotEmpty(repositories);
Assert.Equal(32732252, repositories[0].Id);
Octokit.Tests/Clients/RepositoriesClientTests.cs
+2 -2
View File
@@ -282,7 +282,7 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new RepositoriesClient(connection);
client.GetAllPublic(new PublicRepositoryRequest { Since = 364 });
client.GetAllPublic(new PublicRepositoryRequest(364));
connection.Received()
.GetAll<Repository>(Arg.Is<Uri>(u => u.ToString() == "/repositories"),
@@ -295,7 +295,7 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new RepositoriesClient(connection);
client.GetAllPublic(new PublicRepositoryRequest { Since = 364 });
client.GetAllPublic(new PublicRepositoryRequest(364));
connection.Received()
.GetAll<Repository>(Arg.Is<Uri>(u => u.ToString() == "/repositories"),
Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs
+11 -7
View File
@@ -166,7 +166,7 @@ namespace Octokit.Tests.Reactive
var firstPageUrl = new Uri("/repositories", UriKind.Relative);
var secondPageUrl = new Uri("https://example.com/page/2");
var firstPageLinks = new Dictionary<string, Uri> { { "next", secondPageUrl } };
var firstPageResponse = new ApiResponse<List<Repository>>(
IApiResponse<List<Repository>> firstPageResponse = new ApiResponse<List<Repository>>(
CreateResponseWithApiInfo(firstPageLinks),
new List<Repository>
{
@@ -174,9 +174,10 @@ namespace Octokit.Tests.Reactive
new Repository(365),
new Repository(366)
});
var thirdPageUrl = new Uri("https://example.com/page/3");
var secondPageLinks = new Dictionary<string, Uri> { { "next", thirdPageUrl } };
var secondPageResponse = new ApiResponse<List<Repository>>
IApiResponse<List<Repository>> secondPageResponse = new ApiResponse<List<Repository>>
(
CreateResponseWithApiInfo(secondPageLinks),
new List<Repository>
@@ -185,24 +186,27 @@ namespace Octokit.Tests.Reactive
new Repository(368),
new Repository(369)
});
var lastPageResponse = new ApiResponse<List<Repository>>(
IApiResponse<List<Repository>> lastPageResponse = new ApiResponse<List<Repository>>(
new Response(),
new List<Repository>
{
new Repository(370)
});
var gitHubClient = Substitute.For<IGitHubClient>();
gitHubClient.Connection.Get<List<Repository>>(firstPageUrl,
Arg.Is<Dictionary<string, string>>(d => d.Count == 1
&& d["since"] == "364"), null)
.Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => firstPageResponse));
.Returns(Task.FromResult(firstPageResponse));
gitHubClient.Connection.Get<List<Repository>>(secondPageUrl, null, null)
.Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => secondPageResponse));
.Returns(Task.FromResult(secondPageResponse));
gitHubClient.Connection.Get<List<Repository>>(thirdPageUrl, null, null)
.Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => lastPageResponse));
.Returns(Task.FromResult(lastPageResponse));
var repositoriesClient = new ObservableRepositoriesClient(gitHubClient);
var results = await repositoriesClient.GetAllPublic(new PublicRepositoryRequest { Since = 364 }).ToArray();
var results = await repositoriesClient.GetAllPublic(new PublicRepositoryRequest(364)).ToArray();
Assert.Equal(7, results.Length);
gitHubClient.Connection.Received(1).Get<List<Repository>>(firstPageUrl,
Octokit/Clients/IRepositoriesClient.cs
+1 -1
View File
@@ -111,7 +111,7 @@ namespace Octokit
/// <summary>
/// Gets all public repositories since the integer ID of the last Repository that you’ve seen.
/// Gets all public repositories since the integer ID of the last Repository that you've seen.
/// </summary>
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/#list-all-public-repositories">API documentation</a> for more information.
Octokit/Clients/RepositoriesClient.cs
+1 -1
View File
@@ -189,7 +189,7 @@ namespace Octokit
}
/// <summary>
/// Gets all public repositories since the integer ID of the last Repository that you�ve seen.
/// Gets all public repositories since the integer ID of the last Repository that you've seen.
/// </summary>
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/#list-all-public-repositories">API documentation</a> for more information.
Octokit/Models/Request/PublicRepositoryRequest.cs
+4 -1
View File
@@ -11,8 +11,11 @@ namespace Octokit
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public class PublicRepositoryRequest : RequestParameters
{
public PublicRepositoryRequest()
public PublicRepositoryRequest(int since)
{
Ensure.ArgumentNotNull(since, "since");
Since = since;
}
public long Since { get; set; }