zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-03 03:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correcting return type in ObservableEventsClient

Browse Source
This commit is contained in:
Stanley Goldman
2016-10-09 14:23:56 -04:00
parent 10d263270c
commit 80615e5a92
3 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Reactive/Clients/IObservableEventsClient.cs
+4 -4
View File
@@ -76,7 +76,7 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
IObservable<Activity> GetAllIssuesForRepository(string owner, string name);
IObservable<IssueEvent> GetAllIssuesForRepository(string owner, string name);
/// <summary>
/// Gets all the issue events for a given repository
@@ -85,7 +85,7 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
IObservable<Activity> GetAllIssuesForRepository(long repositoryId);
IObservable<IssueEvent> GetAllIssuesForRepository(long repositoryId);
/// <summary>
/// Gets all the issue events for a given repository
@@ -96,7 +96,7 @@ namespace Octokit.Reactive
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Activity> GetAllIssuesForRepository(string owner, string name, ApiOptions options);
IObservable<IssueEvent> GetAllIssuesForRepository(string owner, string name, ApiOptions options);
/// <summary>
/// Gets all the issue events for a given repository
@@ -106,7 +106,7 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Activity> GetAllIssuesForRepository(long repositoryId, ApiOptions options);
IObservable<IssueEvent> GetAllIssuesForRepository(long repositoryId, ApiOptions options);
/// <summary>
/// Gets all the events for a given repository network
Octokit.Reactive/Clients/ObservableEventsClient.cs
+8 -8
View File
@@ -107,14 +107,14 @@ namespace Octokit.Reactive
}
/// <summary>
/// Gets all the events for a given repository
/// Gets all the issue events for a given repository
/// </summary>
/// <remarks>
/// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
public IObservable<Activity> GetAllIssuesForRepository(string owner, string name)
public IObservable<IssueEvent> GetAllIssuesForRepository(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
@@ -129,13 +129,13 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
public IObservable<Activity> GetAllIssuesForRepository(long repositoryId)
public IObservable<IssueEvent> GetAllIssuesForRepository(long repositoryId)
{
return GetAllIssuesForRepository(repositoryId, ApiOptions.None);
}
/// <summary>
/// Gets all the events for a given repository
/// Gets all the issue events for a given repository
/// </summary>
/// <remarks>
/// http://developer.github.com/v3/activity/events/#list-issue-events-for-a-repository
@@ -143,13 +143,13 @@ namespace Octokit.Reactive
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Activity> GetAllIssuesForRepository(string owner, string name, ApiOptions options)
public IObservable<IssueEvent> GetAllIssuesForRepository(string owner, string name, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(options, "options");
return _connection.GetAndFlattenAllPages<Activity>(ApiUrls.IssuesEvents(owner, name), options);
return _connection.GetAndFlattenAllPages<IssueEvent>(ApiUrls.IssuesEvents(owner, name), options);
}
/// <summary>
@@ -160,11 +160,11 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Activity> GetAllIssuesForRepository(long repositoryId, ApiOptions options)
public IObservable<IssueEvent> GetAllIssuesForRepository(long repositoryId, ApiOptions options)
{
Ensure.ArgumentNotNull(options, "options");
return _connection.GetAndFlattenAllPages<Activity>(ApiUrls.IssuesEvents(repositoryId), options);
return _connection.GetAndFlattenAllPages<IssueEvent>(ApiUrls.IssuesEvents(repositoryId), options);
}
/// <summary>
Octokit.Tests.Integration/Reactive/ObservableEventsClientTests.cs
+4 -4
View File
@@ -170,7 +170,7 @@ namespace Octokit.Tests.Integration.Reactive
_eventsClient = new ObservableEventsClient(Helper.GetAuthenticatedClient());
}
[IntegrationTest(Skip = "These tests just don't work any more")]
[IntegrationTest]
public async Task ReturnsRepositoryEvents()
{
var options = new ApiOptions
@@ -185,7 +185,7 @@ namespace Octokit.Tests.Integration.Reactive
Assert.NotEmpty(repositoryEvents);
}
[IntegrationTest(Skip = "These tests just don't work any more")]
[IntegrationTest]
public async Task ReturnsCorrectCountOfRepositoryEventsWithoutStart()
{
var options = new ApiOptions
@@ -199,7 +199,7 @@ namespace Octokit.Tests.Integration.Reactive
Assert.Equal(5, repositoryEvents.Count);
}
[IntegrationTest(Skip = "These tests just don't work any more")]
[IntegrationTest]
public async Task ReturnsCorrectCountOfRepositoryEventsWithStart()
{
var options = new ApiOptions
@@ -214,7 +214,7 @@ namespace Octokit.Tests.Integration.Reactive
Assert.Equal(5, repositoryEvents.Count);
}
[IntegrationTest(Skip = "These tests just don't work any more")]
[IntegrationTest]
public async Task ReturnsDistinctRepositoryEventsBasedOnStartPage()
{
var startOptions = new ApiOptions