zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-05 23:06:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Double quote issue labels in search API (#2084)

Browse Source
This commit is contained in:
Haytam Zanid
2020-02-09 16:38:59 +01:00
committed by GitHub
parent 9b136b1f41
commit 911dd4a9c3
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Octokit.Tests/Clients/SearchClientTests.cs
View File

@@ -962,7 +962,7 @@ namespace Octokit.Tests.Clients
connection.Received().Get<SearchIssuesResult>(
Arg.Is<Uri>(u => u.ToString() == "search/issues"),
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:bug"));
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:\"bug\""));
}
[Fact]
@@ -977,7 +977,7 @@ namespace Octokit.Tests.Clients
connection.Received().Get<SearchIssuesResult>(
Arg.Is<Uri>(u => u.ToString() == "search/issues"),
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:bug+label:feature"));
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+label:\"bug\"+label:\"feature\""));
}
[Fact]
@@ -1560,7 +1560,7 @@ namespace Octokit.Tests.Clients
connection.Received().Get<SearchIssuesResult>(
Arg.Is<Uri>(u => u.ToString() == "search/issues"),
Arg.Is<Dictionary<string, string>>(d => d["q"] ==
"something+label:bug+user:alfhenrik+repo:octokit/octokit.net"));
"something+label:\"bug\"+user:alfhenrik+repo:octokit/octokit.net"));
}
}

6
Octokit.Tests/Models/SearchIssuesRequestTests.cs
View File

@@ -114,9 +114,9 @@ public class SearchIssuesRequestTests
var request = new SearchIssuesRequest("test");
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("label:"));
request.Labels = new[] { "label1", "label2" };
Assert.Contains("label:label1", request.MergedQualifiers());
Assert.Contains("label:label2", request.MergedQualifiers());
request.Labels = new[] { "label1", "label 2" };
Assert.Contains("label:\"label1\"", request.MergedQualifiers());
Assert.Contains("label:\"label 2\"", request.MergedQualifiers());
}
[Fact]

2
Octokit/Models/Request/SearchIssuesRequest.cs
View File

@@ -328,7 +328,7 @@ namespace Octokit
if (Labels != null)
{
parameters.AddRange(Labels.Select(label => string.Format(CultureInfo.InvariantCulture, "label:{0}", label)));
parameters.AddRange(Labels.Select(label => string.Format(CultureInfo.InvariantCulture, "label:\"{0}\"", label)));
}
if (No.HasValue)