mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-05 03:30:34 +00:00
corrected return type from Add
This commit is contained in:
@@ -30,6 +30,6 @@ namespace Octokit.Reactive
|
||||
/// </remarks>
|
||||
/// <param name="emailAddresses">The email addresses to add.</param>
|
||||
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
|
||||
IObservable<string> Add(params string[] emailAddresses);
|
||||
IObservable<EmailAddress> Add(params string[] emailAddresses);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -44,7 +44,7 @@ namespace Octokit.Reactive
|
||||
/// </remarks>
|
||||
/// <param name="emailAddresses">The email addresses to add.</param>
|
||||
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
|
||||
public IObservable<string> Add(params string[] emailAddresses)
|
||||
public IObservable<EmailAddress> Add(params string[] emailAddresses)
|
||||
{
|
||||
return _client.Add(emailAddresses).ToObservable().SelectMany(a => a);
|
||||
}
|
||||
|
||||
@@ -30,6 +30,6 @@ namespace Octokit
|
||||
/// </remarks>
|
||||
/// <param name="emailAddresses">The email addresses to add.</param>
|
||||
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
|
||||
Task<IReadOnlyList<string>> Add(params string[] emailAddresses);
|
||||
Task<IReadOnlyList<EmailAddress>> Add(params string[] emailAddresses);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -41,22 +41,13 @@ namespace Octokit
|
||||
/// </remarks>
|
||||
/// <param name="emailAddresses">The email addresses to add.</param>
|
||||
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
|
||||
public Task<IReadOnlyList<string>> Add(params string[] emailAddresses)
|
||||
public Task<IReadOnlyList<EmailAddress>> Add(params string[] emailAddresses)
|
||||
{
|
||||
Ensure.ArgumentNotNull(emailAddresses, "emailAddresses");
|
||||
if (emailAddresses.Any(String.IsNullOrWhiteSpace))
|
||||
throw new ArgumentException("Cannot contain null, empty or whitespace values", "emailAddresses");
|
||||
|
||||
return ApiConnection.Post<IReadOnlyList<string>>(ApiUrls.Emails(), emailAddresses);
|
||||
}
|
||||
|
||||
public Task Delete(params string[] emailAddresses)
|
||||
{
|
||||
Ensure.ArgumentNotNull(emailAddresses, "emailAddresses");
|
||||
if (emailAddresses.Any(String.IsNullOrWhiteSpace))
|
||||
throw new ArgumentException("Cannot contain null, empty or whitespace values", "emailAddresses");
|
||||
|
||||
return ApiConnection.Delete(ApiUrls.Emails(), emailAddresses);
|
||||
return ApiConnection.Post<IReadOnlyList<EmailAddress>>(ApiUrls.Emails(), emailAddresses);
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user