corrected return type from Add

This commit is contained in:
Brendan Forster
2014-07-08 10:24:53 +09:30
parent 23f1548653
commit 97995a769a
4 changed files with 5 additions and 14 deletions
@@ -30,6 +30,6 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="emailAddresses">The email addresses to add.</param>
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
IObservable<string> Add(params string[] emailAddresses);
IObservable<EmailAddress> Add(params string[] emailAddresses);
}
}
@@ -44,7 +44,7 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="emailAddresses">The email addresses to add.</param>
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
public IObservable<string> Add(params string[] emailAddresses)
public IObservable<EmailAddress> Add(params string[] emailAddresses)
{
return _client.Add(emailAddresses).ToObservable().SelectMany(a => a);
}
+1 -1
View File
@@ -30,6 +30,6 @@ namespace Octokit
/// </remarks>
/// <param name="emailAddresses">The email addresses to add.</param>
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
Task<IReadOnlyList<string>> Add(params string[] emailAddresses);
Task<IReadOnlyList<EmailAddress>> Add(params string[] emailAddresses);
}
}
+2 -11
View File
@@ -41,22 +41,13 @@ namespace Octokit
/// </remarks>
/// <param name="emailAddresses">The email addresses to add.</param>
/// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
public Task<IReadOnlyList<string>> Add(params string[] emailAddresses)
public Task<IReadOnlyList<EmailAddress>> Add(params string[] emailAddresses)
{
Ensure.ArgumentNotNull(emailAddresses, "emailAddresses");
if (emailAddresses.Any(String.IsNullOrWhiteSpace))
throw new ArgumentException("Cannot contain null, empty or whitespace values", "emailAddresses");
return ApiConnection.Post<IReadOnlyList<string>>(ApiUrls.Emails(), emailAddresses);
}
public Task Delete(params string[] emailAddresses)
{
Ensure.ArgumentNotNull(emailAddresses, "emailAddresses");
if (emailAddresses.Any(String.IsNullOrWhiteSpace))
throw new ArgumentException("Cannot contain null, empty or whitespace values", "emailAddresses");
return ApiConnection.Delete(ApiUrls.Emails(), emailAddresses);
return ApiConnection.Post<IReadOnlyList<EmailAddress>>(ApiUrls.Emails(), emailAddresses);
}
}
}