Move INotificationsClient to under IActivitiesClient

per #1015.

Top level client obsoleted.

Octokit.Reactive/Clients/IObservableActivitiesClient.cs

@@ -6,5 +6,6 @@
         IObservableWatchedClient Watching { get; }
         IObservableStarredClient Starring { get; }
         IObservableFeedsClient Feeds { get; }
+        IObservableNotificationsClient Notifications { get; }
     }
 }

Octokit.Reactive/Clients/ObservableActivitiesClient.cs

@@ -10,6 +10,7 @@
             Watching = new ObservableWatchedClient(client);
             Starring = new ObservableStarredClient(client);
             Feeds = new ObservableFeedsClient(client);
+            Notifications = new ObservableNotificationsClient(client);
         }
         public IObservableEventsClient Events { get; private set; }
 
@@ -18,5 +19,6 @@
         public IObservableStarredClient Starring { get; private set; }
 
         public IObservableFeedsClient Feeds { get; private set; }
+        public IObservableNotificationsClient Notifications { get; private set; }
     }
 }

Octokit.Reactive/Clients/ObservableNotificationsClient.cs

@@ -15,7 +15,7 @@ namespace Octokit.Reactive
             Ensure.ArgumentNotNull(client, "client");
 
             _connection = client.Connection;
-            _notificationsClient = client.Notification;
+            _notificationsClient = client.Activity.Notifications;
         }
 
         /// <summary>

Octokit.Reactive/IObservableGitHubClient.cs

@@ -16,6 +16,7 @@
         IObservableReleasesClient Release { get; }
         IObservableSshKeysClient SshKey { get; }
         IObservableUsersClient User { get; }
+        [System.Obsolete("The Notifications API belongs under the Activities client")]
         IObservableNotificationsClient Notification { get; }
         IObservableGitDatabaseClient GitDatabase { get; }
         IObservableSearchClient Search { get; }

Octokit/Clients/ActivitiesClient.cs

@@ -19,6 +19,7 @@
             Starring = new StarredClient(apiConnection);
             Watching = new WatchedClient(apiConnection);
             Feeds = new FeedsClient(apiConnection);
+            Notifications = new NotificationsClient(apiConnection);
         }
 
         /// <summary>
@@ -37,5 +38,9 @@
         /// Client for the Feeds API
         /// </summary>
         public IFeedsClient Feeds { get; private set; }
+        /// <summary>
+        /// Client for the Notifications API
+        /// </summary>
+        public INotificationsClient Notifications { get; private set; }
     }
 }

Octokit/Clients/IActivitiesClient.cs

@@ -27,5 +27,10 @@
         /// Client for the Feeds API
         /// </summary>
         IFeedsClient Feeds { get; }
+
+        /// <summary>
+        /// Client for the Notifications API
+        /// </summary>
+        INotificationsClient Notifications { get; }
     }
 }

Octokit/IGitHubClient.cs

@@ -116,6 +116,7 @@
         /// <remarks>
         /// Refer to the API docmentation for more information: https://developer.github.com/v3/activity/notifications/
         /// </remarks>
+        [System.Obsolete("The Notifications API belongs under the Activities client")]
         INotificationsClient Notification { get; }
 
         /// <summary>