zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-06 20:13:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not attempt to json serialize stream body

Browse Source
This commit is contained in:
Haacked
2013-10-06 22:01:42 -07:00
parent be7a14539e
commit 9f1626e484
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Http/JsonHttpPipelineTests.cs
+13 -1
View File
@@ -1,7 +1,7 @@
using System;
using System.IO;
using Octokit.Http;
using Xunit;
using Xunit.Extensions;
namespace Octokit.Tests.Http
{
@@ -55,6 +55,18 @@ namespace Octokit.Tests.Http
Assert.Equal(json, request.Body);
}
[Fact]
public void LeavesStreamBodyAlone()
{
var stream = new MemoryStream();
var request = new Request { Body = stream };
var jsonPipeline = new JsonHttpPipeline();
jsonPipeline.SerializeRequest(request);
Assert.Same(stream, request.Body);
}
[Fact]
public void LeavesNullBodyAlone()
{
Octokit/Http/JsonHttpPipeline.cs
+2 -1
View File
@@ -1,4 +1,5 @@
using System;
using System.IO;
using System.Net.Http;
namespace Octokit.Http
@@ -35,7 +36,7 @@ namespace Octokit.Http
request.Headers["Accept"] = "application/vnd.github.manifold-preview; charset=utf-8";
if (request.Method == HttpMethod.Get || request.Body == null) return;
if (request.Body is string) return;
if (request.Body is string || request.Body is Stream) return;
request.Body = _serializer.Serialize(request.Body);
}