zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-05-29 09:22:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use AcceptHeaders.ReactionsPreview instead of local string

Browse Source
This commit is contained in:
Henrik Andersson
2016-06-15 16:32:09 +10:00
parent dcc54991de
commit b38ca031ef
2 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs
+2 -7
View File
@@ -7,9 +7,6 @@ namespace Octokit.Reactive
{
public class ObservableIssueCommentsClient : IObservableIssueCommentsClient
{
//TODO: Remove this once PR #1335 has been merged
public const string ReactionsPreview = "application/vnd.github.squirrel-girl-preview";
readonly IIssueCommentsClient _client;
readonly IConnection _connection;
@@ -66,8 +63,7 @@ namespace Octokit.Reactive
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(options, "options");
//TODO: Use AcceptHeaders.ReactionsPreview once PR #1335 has been merged
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(owner, name), null, ReactionsPreview, options);
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(owner, name), null, AcceptHeaders.ReactionsPreview, options);
}
/// <summary>
@@ -101,8 +97,7 @@ namespace Octokit.Reactive
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(options, "options");
//TODO: Use AcceptHeaders.ReactionsPreview once PR #1335 has been merged
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(owner, name, number), null, ReactionsPreview, options);
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(owner, name, number), null, AcceptHeaders.ReactionsPreview, options);
}
/// <summary>
Octokit/Clients/IssueCommentsClient.cs
+3 -9
View File
@@ -11,9 +11,6 @@ namespace Octokit
/// </remarks>
public class IssueCommentsClient : ApiClient, IIssueCommentsClient
{
//TODO: Remove this once PR #1335 has been merged
public const string ReactionsPreview = "application/vnd.github.squirrel-girl-preview";
/// <summary>
/// Instantiates a new GitHub Issue Comments API client.
/// </summary>
@@ -35,8 +32,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
//TODO: Use AcceptHeaders.ReactionsPreview once PR #1335 has been merged
return ApiConnection.Get<IssueComment>(ApiUrls.IssueComment(owner, name, id), null, ReactionsPreview);
return ApiConnection.Get<IssueComment>(ApiUrls.IssueComment(owner, name, id), null, AcceptHeaders.ReactionsPreview);
}
/// <summary>
@@ -68,8 +64,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(options, "options");
//TODO: Use AcceptHeaders.ReactionsPreview once PR #1335 has been merged
return ApiConnection.GetAll<IssueComment>(ApiUrls.IssueComments(owner, name), null, ReactionsPreview, options);
return ApiConnection.GetAll<IssueComment>(ApiUrls.IssueComments(owner, name), null, AcceptHeaders.ReactionsPreview, options);
}
/// <summary>
@@ -102,8 +97,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNull(options, "options");
//TODO: Use AcceptHeaders.ReactionsPreview once PR #1335 has been merged
return ApiConnection.GetAll<IssueComment>(ApiUrls.IssueComments(owner, name, number), null, ReactionsPreview, options);
return ApiConnection.GetAll<IssueComment>(ApiUrls.IssueComments(owner, name, number), null, AcceptHeaders.ReactionsPreview, options);
}
/// <summary>