zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-03 11:05:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make IResponse.Headers a readonly dictionary

Browse Source
This commit is contained in:
Haacked
2015-01-01 22:12:02 -08:00
parent aace9902b9
commit c2d51570fd
4 changed files with 12 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Http/ConnectionTests.cs
+4 -7
View File
@@ -111,9 +111,9 @@ namespace Octokit.Tests.Http
string headerKey,
string otpHeaderValue)
{
var headers = new Dictionary<string, string> { { headerKey, otpHeaderValue } };
var httpClient = Substitute.For<IHttpClient>();
IResponse response = new Response { StatusCode = HttpStatusCode.Unauthorized };
response.Headers[headerKey] = otpHeaderValue;
IResponse response = new Response(HttpStatusCode.Unauthorized, null, headers, "application/json");
httpClient.Send(Args.Request, Args.CancellationToken).Returns(Task.FromResult(response));
var connection = new Connection(new ProductHeaderValue("OctokitTests"),
_exampleUri,
@@ -138,12 +138,9 @@ namespace Octokit.Tests.Http
string otpHeaderValue,
TwoFactorType expectedFactorType)
{
var headers = new Dictionary<string, string> { { headerKey, otpHeaderValue } };
IResponse response = new Response(HttpStatusCode.Unauthorized, null, headers, "application/json");
var httpClient = Substitute.For<IHttpClient>();
IResponse response = new Response
{
StatusCode = HttpStatusCode.Unauthorized,
};
response.Headers[headerKey] = otpHeaderValue;
httpClient.Send(Args.Request, Args.CancellationToken).Returns(Task.FromResult(response));
var connection = new Connection(new ProductHeaderValue("OctokitTests"),
_exampleUri,
Octokit/Http/ApiResponse.cs
+2 -4
View File
@@ -1,6 +1,4 @@
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Collections.Generic;
using System.Net;
namespace Octokit.Internal
@@ -17,7 +15,7 @@ namespace Octokit.Internal
var body = response.Body is T ? (T)response.Body : default(T);
HttpResponse = response;
Headers = new ReadOnlyDictionary<string, string>(response.Headers);
Headers = response.Headers;
Body = body;
ApiInfo = response.ApiInfo;
StatusCode = response.StatusCode;
Octokit/Http/IResponse.cs
+1 -1
View File
@@ -18,7 +18,7 @@ namespace Octokit
public interface IResponse
{
object Body { get; }
IDictionary<string, string> Headers { get; }
IReadOnlyDictionary<string, string> Headers { get; }
ApiInfo ApiInfo { get; }
HttpStatusCode StatusCode { get; }
string ContentType { get; }
Octokit/Http/Response.cs
+5 -7
View File
@@ -1,8 +1,6 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Net;
using System.Net.Http;
using Octokit.Internal;
namespace Octokit.Internal
@@ -17,7 +15,7 @@ namespace Octokit.Internal
{
Ensure.ArgumentNotNull(headers, "headers");
Headers = headers;
Headers = new ReadOnlyDictionary<string, string>(headers);
ApiInfo = ApiInfoParser.ParseResponseHeaders(headers);
}
@@ -27,13 +25,13 @@ namespace Octokit.Internal
StatusCode = statusCode;
Body = body;
Headers = headers;
Headers = new ReadOnlyDictionary<string, string>(headers);
ApiInfo = ApiInfoParser.ParseResponseHeaders(headers);
ContentType = contentType;
}
public object Body { get; set; }
public IDictionary<string, string> Headers { get; private set; }
public IReadOnlyDictionary<string, string> Headers { get; private set; }
public ApiInfo ApiInfo { get; private set; }
public HttpStatusCode StatusCode { get; set; }
public string ContentType { get; private set; }