Return Uri to appease convention tests

This commit is contained in:
Haacked
2014-04-22 15:03:17 -07:00
parent 14d7580765
commit cc404b739c
2 changed files with 20 additions and 3 deletions
@@ -15,11 +15,28 @@ namespace Octokit.Reactive
_client = client;
}
public IObservable<Uri> GetGitHubLoginUrl(OauthLoginRequest request)
/// <summary>
/// Gets the URL used in the first step of the web flow. The Web application should redirect to this URL.
/// </summary>
/// <param name="request">Parameters to the Oauth web flow login url</param>
/// <returns></returns>
public Uri GetGitHubLoginUrl(OauthLoginRequest request)
{
return Observable.Return(_client.Oauth.GetGitHubLoginUrl(request));
return _client.Oauth.GetGitHubLoginUrl(request);
}
/// <summary>
/// Makes a request to get an access token using the code returned when GitHub.com redirects back from the URL
/// <see cref="GetGitHubLoginUrl">GitHub login url</see> to the application.
/// </summary>
/// <remarks>
/// If the user accepts your request, GitHub redirects back to your site with a temporary code in a code
/// parameter as well as the state you provided in the previous step in a state parameter. If the states dont
/// match, the request has been created by a third party and the process should be aborted. Exchange this for
/// an access token using this method.
/// </remarks>
/// <param name="request"></param>
/// <returns></returns>
public IObservable<OauthToken> CreateAccessToken(OauthTokenRequest request)
{
return _client.Oauth.CreateAccessToken(request).ToObservable();