zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-06 07:16:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change "IssueId" to long (#2890)

Browse Source 
* Change "IssueId" to `long`

* Change "Id" to `long` in ctor

* Change from `int` to `long` for issue id in "NewPullRequest"
This commit is contained in:
Michael Lehto
2024-02-23 01:38:23 +01:00
committed by GitHub
parent 40041f2e2e
commit d27d1f0a22
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs
View File

@@ -453,7 +453,7 @@ public class ProjectCardsClientTests
return result; return result;
} }
private static async Task<ProjectCard> CreateIssueCardHelper(IGitHubClient githubClient, int issueId, int columnId) private static async Task<ProjectCard> CreateIssueCardHelper(IGitHubClient githubClient, long issueId, int columnId)
{ {
var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue); var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue);
var result = await githubClient.Repository.Project.Card.Create(columnId, newCard); var result = await githubClient.Repository.Project.Card.Create(columnId, newCard);

2
Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs
View File

@@ -441,7 +441,7 @@ public class ObservableProjectCardsClientTests
return result; return result;
} }
private static async Task<ProjectCard> CreateIssueCardHelper(IObservableGitHubClient githubClient, int issueId, int columnId) private static async Task<ProjectCard> CreateIssueCardHelper(IObservableGitHubClient githubClient, long issueId, int columnId)
{ {
var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue); var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue);
var result = await githubClient.Repository.Project.Card.Create(columnId, newCard); var result = await githubClient.Repository.Project.Card.Create(columnId, newCard);

4
Octokit/Models/Request/NewPullRequest.cs
View File

@@ -32,7 +32,7 @@ namespace Octokit
/// <param name="issueId">The number of an existing issue to convert into a pull request.</param> /// <param name="issueId">The number of an existing issue to convert into a pull request.</param>
/// <param name="head">The branch (or git ref where your changes are implemented. In other words, the source branch/ref</param> /// <param name="head">The branch (or git ref where your changes are implemented. In other words, the source branch/ref</param>
/// <param name="baseRef">The base (or git ref) reference you want your changes pulled into. In other words, the target branch/ref</param> /// <param name="baseRef">The base (or git ref) reference you want your changes pulled into. In other words, the target branch/ref</param>
public NewPullRequest(int issueId, string head, string baseRef) public NewPullRequest(long issueId, string head, string baseRef)
{ {
Ensure.ArgumentNotNullOrEmptyString(head, nameof(head)); Ensure.ArgumentNotNullOrEmptyString(head, nameof(head));
Ensure.ArgumentNotNullOrEmptyString(baseRef, nameof(baseRef)); Ensure.ArgumentNotNullOrEmptyString(baseRef, nameof(baseRef));
@@ -50,7 +50,7 @@ namespace Octokit
/// <summary> /// <summary>
/// The number of an existing issue to convert into a pull request (required if <see cref="Title"/> not provided). /// The number of an existing issue to convert into a pull request (required if <see cref="Title"/> not provided).
/// </summary> /// </summary>
public int? IssueId { get; private set; } public long? IssueId { get; private set; }
/// <summary> /// <summary>
/// The branch (or git ref) you want your changes pulled into (required). /// The branch (or git ref) you want your changes pulled into (required).

4
Octokit/Models/Response/Issue.cs
View File

@@ -12,7 +12,7 @@ namespace Octokit
{ {
public Issue() { } public Issue() { }
public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList<Label> labels, User assignee, IReadOnlyList<User> assignees, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt, int id, string nodeId, bool locked, Repository repository, ReactionSummary reactions, LockReason? activeLockReason, ItemStateReason? stateReason) public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList<Label> labels, User assignee, IReadOnlyList<User> assignees, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt, long id, string nodeId, bool locked, Repository repository, ReactionSummary reactions, LockReason? activeLockReason, ItemStateReason? stateReason)
{ {
Id = id; Id = id;
NodeId = nodeId; NodeId = nodeId;
@@ -45,7 +45,7 @@ namespace Octokit
/// <summary> /// <summary>
/// The internal Id for this issue (not the issue number) /// The internal Id for this issue (not the issue number)
/// </summary> /// </summary>
public int Id { get; private set; } public long Id { get; private set; }
/// <summary> /// <summary>
/// GraphQL Node Id /// GraphQL Node Id