zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-05 03:30:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

drop unnecessary awaits and specify ConfigureAwait otherwise for other core clients

Browse Source
This commit is contained in:
Brendan Forster
2016-04-06 20:09:59 -04:00
parent cc834b1385
commit d3c43b77a9
6 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit/Clients/PullRequestsClient.cs
+1 -1
View File
@@ -118,7 +118,7 @@ namespace Octokit
try
{
return await ApiConnection.Put<PullRequestMerge>(ApiUrls.MergePullRequest(owner, name, number), mergePullRequest);
return await ApiConnection.Put<PullRequestMerge>(ApiUrls.MergePullRequest(owner, name, number), mergePullRequest).ConfigureAwait(false);
}
catch (ApiException ex)
{
Octokit/Clients/RepositoriesClient.cs
+1 -1
View File
@@ -87,7 +87,7 @@ namespace Octokit
{
try
{
return await ApiConnection.Post<Repository>(url, newRepository);
return await ApiConnection.Post<Repository>(url, newRepository).ConfigureAwait(false);
}
catch (ApiValidationException e)
{
Octokit/Clients/RepositoryContentsClient.cs
+1 -1
View File
@@ -259,7 +259,7 @@ namespace Octokit
var endpoint = ApiUrls.RepositoryArchiveLink(owner, name, archiveFormat, reference);
var response = await Connection.Get<byte[]>(endpoint, timeout);
var response = await Connection.Get<byte[]>(endpoint, timeout).ConfigureAwait(false);
return response.Body;
}
Octokit/Clients/StatisticsClient.cs
+6 -6
View File
@@ -39,13 +39,13 @@ namespace Octokit
/// <param name="repositoryName">The name of the repository</param>
/// <param name="cancellationToken">A token used to cancel this potentially long running request</param>
/// <returns>A list of <see cref="Contributor"/></returns>
public async Task<IReadOnlyList<Contributor>> GetContributors(string owner, string repositoryName, CancellationToken cancellationToken)
public Task<IReadOnlyList<Contributor>> GetContributors(string owner, string repositoryName, CancellationToken cancellationToken)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");
var endpoint = "repos/{0}/{1}/stats/contributors".FormatUri(owner, repositoryName);
return await ApiConnection.GetQueuedOperation<Contributor>(endpoint, cancellationToken);
return ApiConnection.GetQueuedOperation<Contributor>(endpoint, cancellationToken);
}
/// <summary>
@@ -72,7 +72,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");
var endpoint = "repos/{0}/{1}/stats/commit_activity".FormatUri(owner, repositoryName);
var activity = await ApiConnection.GetQueuedOperation<WeeklyCommitActivity>(endpoint, cancellationToken);
var activity = await ApiConnection.GetQueuedOperation<WeeklyCommitActivity>(endpoint, cancellationToken).ConfigureAwait(false);
return new CommitActivity(activity);
}
@@ -100,7 +100,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");
var endpoint = "repos/{0}/{1}/stats/code_frequency".FormatUri(owner, repositoryName);
var rawFrequencies = await ApiConnection.GetQueuedOperation<long[]>(endpoint, cancellationToken);
var rawFrequencies = await ApiConnection.GetQueuedOperation<long[]>(endpoint, cancellationToken).ConfigureAwait(false);
return new CodeFrequency(rawFrequencies);
}
@@ -128,7 +128,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");
var endpoint = "repos/{0}/{1}/stats/participation".FormatUri(owner, repositoryName);
var result = await ApiConnection.GetQueuedOperation<Participation>(endpoint, cancellationToken);
var result = await ApiConnection.GetQueuedOperation<Participation>(endpoint, cancellationToken).ConfigureAwait(false);
return result.FirstOrDefault();
}
@@ -156,7 +156,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");
var endpoint = "repos/{0}/{1}/stats/punch_card".FormatUri(owner, repositoryName);
var punchCardData = await ApiConnection.GetQueuedOperation<int[]>(endpoint, cancellationToken);
var punchCardData = await ApiConnection.GetQueuedOperation<int[]>(endpoint, cancellationToken).ConfigureAwait(false);
return new PunchCard(punchCardData);
}
}
Octokit/Clients/TeamsClient.cs
+7 -7
View File
@@ -137,7 +137,7 @@ namespace Octokit
try
{
response = await ApiConnection.Get<Dictionary<string, string>>(endpoint);
response = await ApiConnection.Get<Dictionary<string, string>>(endpoint).ConfigureAwait(false);
}
catch (NotFoundException)
{
@@ -208,7 +208,7 @@ namespace Octokit
try
{
response = await ApiConnection.Put<Dictionary<string, string>>(endpoint, RequestBody.Empty);
response = await ApiConnection.Put<Dictionary<string, string>>(endpoint, RequestBody.Empty).ConfigureAwait(false);
}
catch (NotFoundException)
{
@@ -242,7 +242,7 @@ namespace Octokit
try
{
var httpStatusCode = await ApiConnection.Connection.Delete(endpoint);
var httpStatusCode = await ApiConnection.Connection.Delete(endpoint).ConfigureAwait(false);
return httpStatusCode == HttpStatusCode.NoContent;
}
@@ -268,7 +268,7 @@ namespace Octokit
try
{
var response = await ApiConnection.Connection.GetResponse<string>(endpoint);
var response = await ApiConnection.Connection.GetResponse<string>(endpoint).ConfigureAwait(false);
return response.HttpResponse.StatusCode == HttpStatusCode.NoContent;
}
catch (NotFoundException)
@@ -333,7 +333,7 @@ namespace Octokit
try
{
var httpStatusCode = await ApiConnection.Connection.Put(endpoint);
var httpStatusCode = await ApiConnection.Connection.Put(endpoint).ConfigureAwait(false);
return httpStatusCode == HttpStatusCode.NoContent;
}
catch (NotFoundException)
@@ -356,7 +356,7 @@ namespace Octokit
try
{
var httpStatusCode = await ApiConnection.Connection.Delete(endpoint);
var httpStatusCode = await ApiConnection.Connection.Delete(endpoint).ConfigureAwait(false);
return httpStatusCode == HttpStatusCode.NoContent;
}
@@ -385,7 +385,7 @@ namespace Octokit
try
{
var response = await ApiConnection.Connection.GetResponse<string>(endpoint);
var response = await ApiConnection.Connection.GetResponse<string>(endpoint).ConfigureAwait(false);
return response.HttpResponse.StatusCode == HttpStatusCode.NoContent;
}
catch (NotFoundException)
Octokit/Clients/UserAdministrationClient.cs
+3 -3
View File
@@ -95,7 +95,7 @@ namespace Octokit
var endpoint = ApiUrls.UserAdministrationAuthorization(login);
var response = ((HttpStatusCode)await Connection.Delete(endpoint));
var response = await Connection.Delete(endpoint).ConfigureAwait(false);
if (response != HttpStatusCode.NoContent)
{
throw new ApiException("Invalid Status Code returned. Expected a 204", response);
@@ -196,7 +196,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(login, "login");
var endpoint = ApiUrls.UserAdministration(login);
var response = ((HttpStatusCode)await Connection.Delete(endpoint));
var response = await Connection.Delete(endpoint).ConfigureAwait(false);
if (response != HttpStatusCode.NoContent)
{
throw new ApiException("Invalid Status Code returned. Expected a 204", response);
@@ -219,7 +219,7 @@ namespace Octokit
Ensure.ArgumentNotNull(keyId, "keyId");
var endpoint = ApiUrls.UserAdministrationPublicKeys(keyId);
var response = ((HttpStatusCode)await Connection.Delete(endpoint));
var response = await Connection.Delete(endpoint).ConfigureAwait(false);
if (response != HttpStatusCode.NoContent)
{
throw new ApiException("Invalid Status Code returned. Expected a 204", response);