Merge pull request #1058 from RobPethick/dev-PutReleaseOnIRepositoryFromIGitHubClient

Dev put release on iRepository from iGitHub client
This commit is contained in:
Brendan Forster
2016-01-12 16:43:33 +10:30
11 changed files with 55 additions and 17 deletions
@@ -324,6 +324,14 @@ namespace Octokit.Reactive
///</remarks>
IObservableRepositoryCommitsClient Commit { get; }
/// <summary>
/// Access GitHub's Releases API.
/// </summary>
/// <remarks>
/// Refer to the API docmentation for more information: https://developer.github.com/v3/repos/releases/
/// </remarks>
IObservableReleasesClient Release { get; }
/// <summary>
/// Client for managing pull requests.
/// </summary>
@@ -14,7 +14,7 @@ namespace Octokit.Reactive
{
Ensure.ArgumentNotNull(client, "client");
_client = client.Release;
_client = client.Repository.Release;
_connection = client.Connection;
}
@@ -37,6 +37,7 @@ namespace Octokit.Reactive
Commits = new ObservableRepositoryCommitsClient(client);
#pragma warning restore CS0618 // Type or member is obsolete
Commit = new ObservableRepositoryCommitsClient(client);
Release = new ObservableReleasesClient(client);
DeployKeys = new ObservableRepositoryDeployKeysClient(client);
Content = new ObservableRepositoryContentsClient(client);
Merging = new ObservableMergingClient(client);
@@ -469,6 +470,14 @@ namespace Octokit.Reactive
///</remarks>
public IObservableRepositoryCommitsClient Commit { get; private set; }
/// <summary>
/// Access GitHub's Releases API.
/// </summary>
/// <remarks>
/// Refer to the API docmentation for more information: https://developer.github.com/v3/repos/releases/
/// </remarks>
public IObservableReleasesClient Release { get; private set; }
/// <summary>
/// Client for managing pull requests.
/// </summary>
@@ -15,6 +15,7 @@ namespace Octokit.Reactive
IObservablePullRequestsClient PullRequest { get; }
IObservableRepositoriesClient Repository { get; }
IObservableGistsClient Gist { get; }
[Obsolete("Use Repository.Release instead")]
IObservableReleasesClient Release { get; }
IObservableSshKeysClient SshKey { get; }
IObservableUsersClient User { get; }
+2 -2
View File
@@ -42,7 +42,6 @@ namespace Octokit.Reactive
Repository = new ObservableRepositoriesClient(gitHubClient);
SshKey = new ObservableSshKeysClient(gitHubClient);
User = new ObservableUsersClient(gitHubClient);
Release = new ObservableReleasesClient(gitHubClient);
Git = new ObservableGitDatabaseClient(gitHubClient);
Gist = new ObservableGistsClient(gitHubClient);
Search = new ObservableSearchClient(gitHubClient);
@@ -62,7 +61,8 @@ namespace Octokit.Reactive
public IObservablePullRequestsClient PullRequest { get; private set; }
public IObservableRepositoriesClient Repository { get; private set; }
public IObservableGistsClient Gist { get; private set; }
public IObservableReleasesClient Release { get; private set; }
[Obsolete("Use Repository.Release instead")]
public IObservableReleasesClient Release { get { return Repository.Release; } }
public IObservableSshKeysClient SshKey { get; private set; }
public IObservableUsersClient User { get; private set; }
public IObservableNotificationsClient Notification { get; private set; }
@@ -20,7 +20,7 @@ public class ReleasesClientTests
public TheGetReleasesMethod()
{
var github = Helper.GetAuthenticatedClient();
_releaseClient = github.Release;
_releaseClient = github.Repository.Release;
_context = github.CreateRepositoryContext("public-repo").Result;
}
@@ -84,7 +84,7 @@ public class ReleasesClientTests
public TheEditMethod()
{
_github = Helper.GetAuthenticatedClient();
_releaseClient = _github.Release;
_releaseClient = _github.Repository.Release;
_context = _github.CreateRepositoryContext("public-repo").Result;
}
@@ -143,7 +143,7 @@ public class ReleasesClientTests
public TheUploadAssetMethod()
{
_github = Helper.GetAuthenticatedClient();
_releaseClient = _github.Release;
_releaseClient = _github.Repository.Release;
_context = _github.CreateRepositoryContext("public-repo").Result;
}
@@ -52,7 +52,7 @@ namespace Octokit.Tests.Reactive
client.Get("fake", "repo", 1);
gitHubClient.Release.Received(1).Get("fake", "repo", 1);
gitHubClient.Repository.Release.Received(1).Get("fake", "repo", 1);
}
[Fact]
@@ -78,7 +78,7 @@ namespace Octokit.Tests.Reactive
releasesClient.Create("fake", "repo", data);
gitHubClient.Release.Received(1).Create("fake", "repo", data);
gitHubClient.Repository.Release.Received(1).Create("fake", "repo", data);
}
[Fact]
@@ -105,7 +105,7 @@ namespace Octokit.Tests.Reactive
releasesClient.Edit("fake", "repo", 1, data);
gitHubClient.Release.Received(1).Edit("fake", "repo", 1, data);
gitHubClient.Repository.Release.Received(1).Edit("fake", "repo", 1, data);
}
[Fact]
@@ -132,7 +132,7 @@ namespace Octokit.Tests.Reactive
client.Delete("fake", "repo", 1);
gitHubClient.Release.Received(1).Delete("fake", "repo", 1);
gitHubClient.Repository.Release.Received(1).Delete("fake", "repo", 1);
}
[Fact]
@@ -186,7 +186,7 @@ namespace Octokit.Tests.Reactive
releasesClient.UploadAsset(release, upload);
gitHubClient.Release.Received(1).UploadAsset(release, upload);
gitHubClient.Repository.Release.Received(1).UploadAsset(release, upload);
}
[Fact]
@@ -212,7 +212,7 @@ namespace Octokit.Tests.Reactive
client.GetAsset("fake", "repo", 1);
gitHubClient.Release.Received(1).GetAsset("fake", "repo", 1);
gitHubClient.Repository.Release.Received(1).GetAsset("fake", "repo", 1);
}
[Fact]
@@ -238,7 +238,7 @@ namespace Octokit.Tests.Reactive
client.EditAsset("fake", "repo", 1, data);
gitHubClient.Release.Received(1).EditAsset("fake", "repo", 1, data);
gitHubClient.Repository.Release.Received(1).EditAsset("fake", "repo", 1, data);
}
[Fact]
+8
View File
@@ -270,6 +270,14 @@ namespace Octokit
///</remarks>
IRepositoryCommitsClient Commit { get; }
/// <summary>
/// Access GitHub's Releases API.
/// </summary>
/// <remarks>
/// Refer to the API docmentation for more information: https://developer.github.com/v3/repos/releases/
/// </remarks>
IReleasesClient Release { get; }
/// <summary>
/// Client for GitHub's Repository Merging API
/// </summary>
+9
View File
@@ -40,6 +40,7 @@ namespace Octokit
Commits = new RepositoryCommitsClient(apiConnection);
#pragma warning restore CS0618 // Type or member is obsolete
Commit = new RepositoryCommitsClient(apiConnection);
Release = new ReleasesClient(apiConnection);
DeployKeys = new RepositoryDeployKeysClient(apiConnection);
Merging = new MergingClient(apiConnection);
Content = new RepositoryContentsClient(apiConnection);
@@ -390,6 +391,14 @@ namespace Octokit
///</remarks>
public IRepositoryCommitsClient Commit { get; private set; }
/// <summary>
/// Access GitHub's Releases API.
/// </summary>
/// <remarks>
/// Refer to the API docmentation for more information: https://developer.github.com/v3/repos/releases/
/// </remarks>
public IReleasesClient Release { get; private set; }
/// <summary>
/// Client for GitHub's Repository Merging API
/// </summary>
+5 -3
View File
@@ -92,7 +92,6 @@ namespace Octokit
PullRequest = new PullRequestsClient(apiConnection);
Repository = new RepositoriesClient(apiConnection);
Gist = new GistsClient(apiConnection);
Release = new ReleasesClient(apiConnection);
User = new UsersClient(apiConnection);
SshKey = new SshKeysClient(apiConnection);
Git = new GitDatabaseClient(apiConnection);
@@ -215,14 +214,17 @@ namespace Octokit
/// </remarks>
public IGistsClient Gist { get; private set; }
// TODO: this should be under Repositories to align with the API docs
/// <summary>
/// Access GitHub's Releases API.
/// </summary>
/// <remarks>
/// Refer to the API docmentation for more information: https://developer.github.com/v3/repos/releases/
/// </remarks>
public IReleasesClient Release { get; private set; }
[Obsolete("Use Repository.Release instead")]
public IReleasesClient Release
{
get { return Repository.Release; }
}
// TODO: this should be under Users to align with the API docs
// TODO: this should be named PublicKeys to align with the API docs
+2 -1
View File
@@ -2,7 +2,7 @@
namespace Octokit
{
/// <summary>
/// <summary>
/// A Client for the GitHub API v3. You can read more about the api here: http://developer.github.com.
/// </summary>
public interface IGitHubClient : IApiInfoProvider
@@ -91,6 +91,7 @@ namespace Octokit
/// <remarks>
/// Refer to the API docmentation for more information: https://developer.github.com/v3/repos/releases/
/// </remarks>
[Obsolete("Use Repository.Release instead")]
IReleasesClient Release { get; }
// TODO: this should be under Users to align with the API docs