zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-02 02:45:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

added new unit tests

Browse Source
This commit is contained in:
Alexander Efremov
2016-06-12 23:44:39 +07:00
parent 4ab2075d8c
commit ddf0531d44
2 changed files with 433 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Clients/ReleasesClientTests.cs
+206 -15
View File
@@ -6,7 +6,7 @@ using Xunit;
namespace Octokit.Tests.Clients
{
public class ReleasesClientTests
public class ReleasesClientTests
{
public class TheCtor
{
@@ -34,6 +34,20 @@ namespace Octokit.Tests.Clients
Args.ApiOptions);
}
[Fact]
public async Task RequestsCorrectUrlWithRepositoryId()
{
var client = Substitute.For<IApiConnection>();
var releasesClient = new ReleasesClient(client);
await releasesClient.GetAll(1);
client.Received().GetAll<Release>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases"),
null,
"application/vnd.github.v3",
Args.ApiOptions);
}
[Fact]
public async Task RequestsCorrectUrlWithApiOptions()
{
@@ -55,16 +69,42 @@ namespace Octokit.Tests.Clients
options);
}
[Fact]
public async Task RequestsCorrectUrlWithRepositoryIdWithApiOptions()
{
var client = Substitute.For<IApiConnection>();
var releasesClient = new ReleasesClient(client);
var options = new ApiOptions
{
PageSize = 1,
PageCount = 1,
StartPage = 1
};
await releasesClient.GetAll(1, options);
client.Received().GetAll<Release>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases"),
null,
"application/vnd.github.v3",
options);
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var releasesClient = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetAll(null, "name"));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetAll("", "name"));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetAll("owner", null));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetAll("owner", ""));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetAll(null, "name", ApiOptions.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetAll("owner", null, ApiOptions.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetAll("owner", "name", null));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetAll(1, null));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetAll("", "name"));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetAll("owner", ""));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetAll("", "name", ApiOptions.None));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetAll("owner", "", ApiOptions.None));
}
@@ -83,14 +123,26 @@ namespace Octokit.Tests.Clients
connection.Received().Get<Release>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/1"));
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
await client.Get(1, 1);
connection.Received().Get<Release>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/1"));
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var releasesClient = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Get(null, "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Get("", "name", 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Get("owner", null, 1));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Get("", "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Get("owner", "", 1));
}
}
@@ -108,14 +160,26 @@ namespace Octokit.Tests.Clients
connection.Received().Get<Release>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/latest"));
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
await client.GetLatest(1);
connection.Received().Get<Release>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/latest"));
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var releasesClient = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetLatest(null, "name"));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetLatest("", "name"));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.GetLatest("owner", null));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetLatest("", "name"));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.GetLatest("owner", ""));
}
}
@@ -135,16 +199,36 @@ namespace Octokit.Tests.Clients
"application/vnd.github.v3");
}
[Fact]
public async Task RequestsCorrectUrlWithRepositoryId()
{
var client = Substitute.For<IApiConnection>();
var releasesClient = new ReleasesClient(client);
var data = new NewRelease("fake-tag");
await releasesClient.Create(1, data);
client.Received().Post<Release>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases"),
data,
"application/vnd.github.v3");
}
[Fact]
public async Task EnsuresArgumentsNotNull()
{
var releasesClient = new ReleasesClient(Substitute.For<IApiConnection>());
Assert.Throws<ArgumentNullException>(() => new NewRelease(null));
var data = new NewRelease("fake-tag");
Assert.Throws<ArgumentNullException>(() => new NewRelease(null));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Create(null, "name", data));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Create("owner", null, data));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Create("owner", "name", null));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Create(1, null));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Create("", "name", data));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Create("owner", "", data));
}
}
@@ -162,6 +246,19 @@ namespace Octokit.Tests.Clients
connection.Received().Patch<Release>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/1"), data);
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var releasesClient = new ReleasesClient(connection);
var data = new ReleaseUpdate { TagName = "fake-tag" };
await releasesClient.Edit(1, 1, data);
connection.Received().Patch<Release>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/1"), data);
}
[Fact]
public async Task EnsuresNonNullArguments()
{
@@ -169,10 +266,14 @@ namespace Octokit.Tests.Clients
var releaseUpdate = new ReleaseUpdate { TagName = "tag" };
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Edit(null, "name", 1, releaseUpdate));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Edit("", "name", 1, releaseUpdate));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Edit("owner", null, 1, releaseUpdate));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Edit("owner", "", 1, releaseUpdate));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Edit("owner", "name", 1, null));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.Edit(1, 1, null));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Edit("", "name", 1, releaseUpdate));
await Assert.ThrowsAsync<ArgumentException>(() => releasesClient.Edit("owner", "", 1, releaseUpdate));
}
}
@@ -189,14 +290,26 @@ namespace Octokit.Tests.Clients
connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/1"));
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
await client.Delete(1, 1);
connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/1"));
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var client = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Delete(null, "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.Delete("", "name", 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Delete("owner", null, 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.Delete("", "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.Delete("owner", "", 1));
}
}
@@ -217,6 +330,20 @@ namespace Octokit.Tests.Clients
Args.ApiOptions);
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
await client.GetAllAssets(1, 1);
connection.Received().GetAll<ReleaseAsset>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/1/assets"),
null,
"application/vnd.github.v3",
Args.ApiOptions);
}
[Fact]
public async Task RequestsTheCorrectUrlWithApiOptions()
{
@@ -238,6 +365,27 @@ namespace Octokit.Tests.Clients
"application/vnd.github.v3", options);
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryIdWithApiOptions()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
var options = new ApiOptions
{
StartPage = 1,
PageCount = 1,
PageSize = 1
};
await client.GetAllAssets(1, 1, options);
connection.Received().GetAll<ReleaseAsset>(
Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/1/assets"),
null,
"application/vnd.github.v3", options);
}
[Fact]
public async Task EnsuresNonNullArguments()
{
@@ -246,10 +394,12 @@ namespace Octokit.Tests.Clients
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets(null, "name", 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets("owner", null, 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets("owner", null, 1, ApiOptions.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets(null, "name", 1, ApiOptions.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets("owner", null, 1, ApiOptions.None));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets("owner", "name", 1, null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllAssets(1, 1, null));
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllAssets("", "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllAssets("owner", "", 1));
}
@@ -276,12 +426,13 @@ namespace Octokit.Tests.Clients
}
[Fact]
public async Task EnsuresArgumentsNotNull()
public async Task EnsuresNonNullArguments()
{
var releasesClient = new ReleasesClient(Substitute.For<IApiConnection>());
var release = new Release("https://uploads.github.com/anything");
var uploadData = new ReleaseAssetUpload("good", "good/good", Stream.Null, null);
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.UploadAsset(null, uploadData));
await Assert.ThrowsAsync<ArgumentNullException>(() => releasesClient.UploadAsset(release, null));
}
@@ -317,14 +468,26 @@ namespace Octokit.Tests.Clients
connection.Received().Get<ReleaseAsset>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/assets/1"));
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
await client.GetAsset(1, 1);
connection.Received().Get<ReleaseAsset>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/assets/1"));
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var client = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAsset(null, "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAsset("", "name", 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAsset("owner", null, 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAsset("", "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAsset("owner", "", 1));
}
}
@@ -344,16 +507,32 @@ namespace Octokit.Tests.Clients
data);
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
var data = new ReleaseAssetUpdate("asset");
await client.EditAsset(1, 1, data);
connection.Received().Patch<ReleaseAsset>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/assets/1"),
data);
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var client = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.EditAsset(null, "name", 1, new ReleaseAssetUpdate("name")));
await Assert.ThrowsAsync<ArgumentException>(() => client.EditAsset("", "name", 1, new ReleaseAssetUpdate("name")));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.EditAsset("owner", null, 1, new ReleaseAssetUpdate("name")));
await Assert.ThrowsAsync<ArgumentException>(() => client.EditAsset("owner", "", 1, new ReleaseAssetUpdate("name")));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.EditAsset("owner", "name", 1, null));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.EditAsset(1, 1, null));
await Assert.ThrowsAsync<ArgumentException>(() => client.EditAsset("", "name", 1, new ReleaseAssetUpdate("name")));
await Assert.ThrowsAsync<ArgumentException>(() => client.EditAsset("owner", "", 1, new ReleaseAssetUpdate("name")));
}
}
@@ -370,14 +549,26 @@ namespace Octokit.Tests.Clients
connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/releases/assets/1"));
}
[Fact]
public async Task RequestsTheCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new ReleasesClient(connection);
await client.DeleteAsset(1, 1);
connection.Received().Delete(Arg.Is<Uri>(u => u.ToString() == "repositories/1/releases/assets/1"));
}
[Fact]
public async Task EnsuresNonNullArguments()
{
var client = new ReleasesClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.DeleteAsset(null, "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.DeleteAsset("", "name", 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.DeleteAsset("owner", null, 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.DeleteAsset("", "name", 1));
await Assert.ThrowsAsync<ArgumentException>(() => client.DeleteAsset("owner", "", 1));
}
}
Octokit.Tests/Reactive/ObservableReleasesClientTests.cs
+227 -18
View File
@@ -32,6 +32,56 @@ namespace Octokit.Tests.Reactive
new Uri("repos/fake/repo/releases", UriKind.Relative), Args.EmptyDictionary, null);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.GetAll(1);
gitHubClient.Connection.Received(1).Get<List<Release>>(
new Uri("repositories/1/releases", UriKind.Relative), Args.EmptyDictionary, null);
}
[Fact]
public void RequestsTheCorrectUrlWithApiOptions()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
var options = new ApiOptions
{
PageCount = 1,
PageSize = 1,
StartPage = 1
};
client.GetAll("fake", "repo", options);
gitHubClient.Connection.Received(1).Get<List<Release>>(
new Uri("repos/fake/repo/releases", UriKind.Relative), Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryIdWithApiOptions()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
var options = new ApiOptions
{
PageCount = 1,
PageSize = 1,
StartPage = 1
};
client.GetAll(1, options);
gitHubClient.Connection.Received(1).Get<List<Release>>(
new Uri("repositories/1/releases", UriKind.Relative), Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
}
[Fact]
public void EnsuresNonNullArguments()
{
@@ -39,13 +89,23 @@ namespace Octokit.Tests.Reactive
Assert.Throws<ArgumentNullException>(() => releasesClient.GetAll(null, "name"));
Assert.Throws<ArgumentNullException>(() => releasesClient.GetAll("owner", null));
Assert.Throws<ArgumentNullException>(() => releasesClient.GetAll(null, "name", ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => releasesClient.GetAll("owner", null, ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => releasesClient.GetAll("owner", "name", null));
Assert.Throws<ArgumentNullException>(() => releasesClient.GetAll(1, null));
Assert.Throws<ArgumentException>(() => releasesClient.GetAll("", "name"));
Assert.Throws<ArgumentException>(() => releasesClient.GetAll("owner", ""));
Assert.Throws<ArgumentException>(() => releasesClient.GetAll("", "name", ApiOptions.None));
Assert.Throws<ArgumentException>(() => releasesClient.GetAll("owner", "", ApiOptions.None));
}
}
public class TheGetReleaseMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsTheCorrectUrl()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
@@ -55,21 +115,34 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).Get("fake", "repo", 1);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.Get(1, 1);
gitHubClient.Repository.Release.Received(1).Get(1, 1);
}
[Fact]
public void EnsuresNonNullArguments()
{
var releasesClient = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => releasesClient.Get(null, "name", 1));
Assert.Throws<ArgumentException>(() => releasesClient.Get("", "name", 1));
Assert.Throws<ArgumentNullException>(() => releasesClient.Get("owner", null, 1));
Assert.Throws<ArgumentException>(() => releasesClient.Get("", "name", 1));
Assert.Throws<ArgumentException>(() => releasesClient.Get("owner", "", 1));
}
}
public class TheGetLatestReleaseMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsTheCorrectUrl()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
@@ -79,21 +152,34 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).GetLatest("fake", "repo");
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.GetLatest(1);
gitHubClient.Repository.Release.Received(1).GetLatest(1);
}
[Fact]
public void EnsuresNonNullArguments()
{
var releasesClient = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => releasesClient.GetLatest(null, "name"));
Assert.Throws<ArgumentException>(() => releasesClient.GetLatest("", "name"));
Assert.Throws<ArgumentNullException>(() => releasesClient.GetLatest("owner", null));
Assert.Throws<ArgumentException>(() => releasesClient.GetLatest("", "name"));
Assert.Throws<ArgumentException>(() => releasesClient.GetLatest("owner", ""));
}
}
public class TheCreateReleaseMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsTheCorrectUrl()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var releasesClient = new ObservableReleasesClient(gitHubClient);
@@ -104,6 +190,18 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).Create("fake", "repo", data);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var releasesClient = new ObservableReleasesClient(gitHubClient);
var data = new NewRelease("fake-tag");
releasesClient.Create(1, data);
gitHubClient.Repository.Release.Received(1).Create(1, data);
}
[Fact]
public void EnsuresArgumentsNotNull()
{
@@ -111,9 +209,15 @@ namespace Octokit.Tests.Reactive
var data = new NewRelease("fake-tag");
Assert.Throws<ArgumentNullException>(() => new NewRelease(null));
Assert.Throws<ArgumentNullException>(() => releasesClient.Create(null, "name", data));
Assert.Throws<ArgumentNullException>(() => releasesClient.Create("owner", null, data));
Assert.Throws<ArgumentNullException>(() => releasesClient.Create("owner", "name", null));
Assert.Throws<ArgumentNullException>(() => releasesClient.Create(1, null));
Assert.Throws<ArgumentException>(() => releasesClient.Create("", "name", data));
Assert.Throws<ArgumentException>(() => releasesClient.Create("owner", "", data));
}
}
@@ -131,17 +235,33 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).Edit("fake", "repo", 1, data);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var releasesClient = new ObservableReleasesClient(gitHubClient);
var data = new ReleaseUpdate { TagName = "fake-tag" };
releasesClient.Edit(1, 1, data);
gitHubClient.Repository.Release.Received(1).Edit(1, 1, data);
}
[Fact]
public void EnsuresNonNullArguments()
{
var releasesClient = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
var update = new ReleaseUpdate { TagName = "tag" };
Assert.Throws<ArgumentNullException>(() => releasesClient.Edit(null, "name", 1, update));
Assert.Throws<ArgumentException>(() => releasesClient.Edit("", "name", 1, update));
Assert.Throws<ArgumentNullException>(() => releasesClient.Edit("owner", null, 1, update));
Assert.Throws<ArgumentException>(() => releasesClient.Edit("owner", "", 1, update));
Assert.Throws<ArgumentNullException>(() => releasesClient.Edit("owner", "name", 1, null));
Assert.Throws<ArgumentNullException>(() => releasesClient.Edit(1, 1, null));
Assert.Throws<ArgumentException>(() => releasesClient.Edit("", "name", 1, update));
Assert.Throws<ArgumentException>(() => releasesClient.Edit("owner", "", 1, update));
}
}
@@ -158,14 +278,26 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).Delete("fake", "repo", 1);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.Delete(1, 1);
gitHubClient.Repository.Release.Received(1).Delete(1, 1);
}
[Fact]
public void EnsuresNonNullArguments()
{
var client = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.Delete(null, "name", 1));
Assert.Throws<ArgumentException>(() => client.Delete("", "name", 1));
Assert.Throws<ArgumentNullException>(() => client.Delete("owner", null, 1));
Assert.Throws<ArgumentException>(() => client.Delete("", "name", 1));
Assert.Throws<ArgumentException>(() => client.Delete("owner", "", 1));
}
}
@@ -184,6 +316,18 @@ namespace Octokit.Tests.Reactive
new Uri("repos/fake/repo/releases/1/assets", UriKind.Relative), Args.EmptyDictionary, null);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.GetAllAssets(1, 1);
gitHubClient.Connection.Received(1).Get<List<ReleaseAsset>>(
new Uri("repositories/1/releases/1/assets", UriKind.Relative), Args.EmptyDictionary, null);
}
[Fact]
public void RequestsTheCorrectUrlWithApiOptions()
{
@@ -200,10 +344,33 @@ namespace Octokit.Tests.Reactive
};
client.GetAllAssets("fake", "repo", 1, options);
gitHubClient.Connection.Received(1).Get<List<ReleaseAsset>>(
Arg.Is<Uri>(u => u.ToString() == expectedUrl),
Arg.Is<IDictionary<string, string>>(dictionary => dictionary.Count == 2),
Arg.Is<Uri>(u => u.ToString() == expectedUrl),
Arg.Is<IDictionary<string, string>>(dictionary => dictionary.Count == 2),
null);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryIdWithApiOptions()
{
var expectedUrl = "repositories/1/releases/1/assets";
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
var options = new ApiOptions
{
StartPage = 1,
PageCount = 1,
PageSize = 1
};
client.GetAllAssets(1, 1, options);
gitHubClient.Connection.Received(1).Get<List<ReleaseAsset>>(
Arg.Is<Uri>(u => u.ToString() == expectedUrl),
Arg.Is<IDictionary<string, string>>(dictionary => dictionary.Count == 2),
null);
}
@@ -212,13 +379,15 @@ namespace Octokit.Tests.Reactive
{
var client = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets("owner", null, 1));
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets(null, "name", 1));
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets("owner", null, 1));
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets(null, "name", 1, ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets("owner", null, 1, ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets("owner", "name", 1, null));
Assert.Throws<ArgumentNullException>(() => client.GetAllAssets(1, 1, null));
Assert.Throws<ArgumentException>(() => client.GetAllAssets("", "name", 1));
Assert.Throws<ArgumentException>(() => client.GetAllAssets("owner", "", 1));
}
@@ -227,7 +396,7 @@ namespace Octokit.Tests.Reactive
public class TheUploadReleaseAssetMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsTheCorrectUrl()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var releasesClient = new ObservableReleasesClient(gitHubClient);
@@ -256,7 +425,7 @@ namespace Octokit.Tests.Reactive
public class TheGetAssetMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsTheCorrectUrl()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
@@ -266,14 +435,26 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).GetAsset("fake", "repo", 1);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.GetAsset(1, 1);
gitHubClient.Repository.Release.Received(1).GetAsset(1, 1);
}
[Fact]
public void EnsuresNonNullArguments()
{
var client = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.GetAsset(null, "name", 1));
Assert.Throws<ArgumentException>(() => client.GetAsset("", "name", 1));
Assert.Throws<ArgumentNullException>(() => client.GetAsset("owner", null, 1));
Assert.Throws<ArgumentException>(() => client.GetAsset("", "name", 1));
Assert.Throws<ArgumentException>(() => client.GetAsset("owner", "", 1));
}
}
@@ -292,16 +473,31 @@ namespace Octokit.Tests.Reactive
gitHubClient.Repository.Release.Received(1).EditAsset("fake", "repo", 1, data);
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
var data = new ReleaseAssetUpdate("asset");
client.EditAsset(1, 1, data);
gitHubClient.Repository.Release.Received(1).EditAsset(1, 1, data);
}
[Fact]
public void EnsuresNonNullArguments()
{
var client = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.EditAsset(null, "name", 1, new ReleaseAssetUpdate("name")));
Assert.Throws<ArgumentException>(() => client.EditAsset("", "name", 1, new ReleaseAssetUpdate("name")));
Assert.Throws<ArgumentNullException>(() => client.EditAsset("owner", null, 1, new ReleaseAssetUpdate("name")));
Assert.Throws<ArgumentException>(() => client.EditAsset("owner", "", 1, new ReleaseAssetUpdate("name")));
Assert.Throws<ArgumentNullException>(() => client.EditAsset("owner", "name", 1, null));
Assert.Throws<ArgumentNullException>(() => client.EditAsset(1, 1, null));
Assert.Throws<ArgumentException>(() => client.EditAsset("", "name", 1, new ReleaseAssetUpdate("name")));
Assert.Throws<ArgumentException>(() => client.EditAsset("owner", "", 1, new ReleaseAssetUpdate("name")));
}
}
@@ -319,14 +515,27 @@ namespace Octokit.Tests.Reactive
new Uri("repos/fake/repo/releases/assets/1", UriKind.Relative));
}
[Fact]
public void RequestsTheCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableReleasesClient(gitHubClient);
client.DeleteAsset(1, 1);
gitHubClient.Connection.Delete(
new Uri("repositories/1/releases/assets/1", UriKind.Relative));
}
[Fact]
public void EnsuresNonNullArguments()
{
var client = new ObservableReleasesClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.DeleteAsset(null, "name", 1));
Assert.Throws<ArgumentException>(() => client.DeleteAsset("", "name", 1));
Assert.Throws<ArgumentNullException>(() => client.DeleteAsset("owner", null, 1));
Assert.Throws<ArgumentException>(() => client.DeleteAsset("", "name", 1));
Assert.Throws<ArgumentException>(() => client.DeleteAsset("owner", "", 1));
}
}