added unit tests

Octokit.Tests/Clients/MergingClientTests.cs

@@ -10,7 +10,7 @@ namespace Octokit.Tests.Clients
         public class TheCreateMethod
         {
             [Fact]
-            public void PostsToTheCorrectUrl()
+            public void RequestsTheCorrectUrl()
             {
                 var connection = Substitute.For<IApiConnection>();
                 var client = new MergingClient(connection);
@@ -27,6 +27,24 @@ namespace Octokit.Tests.Clients
                                             && nm.CommitMessage == "some mergingMessage"));
             }
 
+            [Fact]
+            public void RequestsTheCorrectUrlWithRepositoryId()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new MergingClient(connection);
+
+                var newMerge = new NewMerge("baseBranch", "shaToMerge")
+                {
+                    CommitMessage = "some mergingMessage"
+                };
+                client.Create(1, newMerge);
+
+                connection.Received().Post<Merge>(Arg.Is<Uri>(u => u.ToString() == "repositories/1/merges"),
+                    Arg.Is<NewMerge>(nm => nm.Base == "baseBranch"
+                                            && nm.Head == "shaToMerge"
+                                            && nm.CommitMessage == "some mergingMessage"));
+            }
+
             [Fact]
             public async Task EnsuresNonNullArguments()
             {
@@ -36,6 +54,7 @@ namespace Octokit.Tests.Clients
                 await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(null, "name", newMerge));
                 await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", null, newMerge));
                 await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", "name", null));
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(1, null));
                 await Assert.ThrowsAsync<ArgumentException>(() => client.Create("", "name", newMerge));
                 await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", newMerge));
                 await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", null));

Octokit.Tests/Octokit.Tests.csproj

@@ -201,6 +201,7 @@
     <Compile Include="Reactive\Enterprise\ObservableEnterpriseSearchIndexingClientTests.cs" />
     <Compile Include="Reactive\Enterprise\ObservableEnterpriseOrganizationClientTests.cs" />
     <Compile Include="Reactive\Enterprise\ObservableEnterpriseLicenseClientTests.cs" />
+    <Compile Include="Reactive\ObservableMergingClientTests.cs" />
     <Compile Include="Reactive\ObservableAssigneesClientTests.cs" />
     <Compile Include="Reactive\ObservableAuthorizationsClientTests.cs" />
     <Compile Include="Reactive\ObservableBlobClientTests.cs" />

Octokit.Tests/Reactive/ObservableMergingClientTests.cs

@@ -0,0 +1,68 @@
+using System;
+using System.Threading.Tasks;
+using NSubstitute;
+using Octokit.Reactive;
+using Xunit;
+
+namespace Octokit.Tests.Clients
+{
+    public class ObservableMergingClientTests
+    {
+        public class TheCreateMethod
+        {
+            [Fact]
+            public void RequestsTheCorrectUrl()
+            {
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                var client = new ObservableMergingClient(gitHubClient);
+
+                var newMerge = new NewMerge("baseBranch", "shaToMerge")
+                {
+                    CommitMessage = "some mergingMessage"
+                };
+                client.Create("owner", "repo", newMerge);
+
+                gitHubClient.Repository.Merging.Received(1).Create("owner", "repo", newMerge);
+            }
+
+            [Fact]
+            public void RequestsTheCorrectUrlWithRepositoryId()
+            {
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                var client = new ObservableMergingClient(gitHubClient);
+
+                var newMerge = new NewMerge("baseBranch", "shaToMerge")
+                {
+                    CommitMessage = "some mergingMessage"
+                };
+                client.Create(1, newMerge);
+
+                gitHubClient.Repository.Merging.Received(1).Create(1, newMerge);
+            }
+
+            [Fact]
+            public async Task EnsuresNonNullArguments()
+            {
+                var client = new ObservableMergingClient(Substitute.For<IGitHubClient>());
+
+                var newMerge = new NewMerge("baseBranch", "shaToMerge") { CommitMessage = "some mergingMessage" };
+                Assert.Throws<ArgumentNullException>(() => client.Create(null, "name", newMerge));
+                Assert.Throws<ArgumentNullException>(() => client.Create("owner", null, newMerge));
+                Assert.Throws<ArgumentNullException>(() => client.Create("owner", "name", null));
+                Assert.Throws<ArgumentNullException>(() => client.Create(1, null));
+                Assert.Throws<ArgumentException>(() => client.Create("", "name", newMerge));
+                Assert.Throws<ArgumentException>(() => client.Create("owner", "", newMerge));
+                Assert.Throws<ArgumentException>(() => client.Create("owner", "", null));
+            }
+        }
+
+        public class TheCtor
+        {
+            [Fact]
+            public void EnsuresNonNullArguments()
+            {
+                Assert.Throws<ArgumentNullException>(() => new ObservableMergingClient(null));
+            }
+        }
+    }
+}