zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-07 20:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update IssueEvent ID field from int to long (#2060)

Browse Source
This commit is contained in:
Steve Desmond
2020-01-19 17:54:46 -05:00
committed by Brendan Forster
parent a05d49e81d
commit e9409e0cb5
7 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Reactive/Clients/IObservableIssuesEventsClient.cs
+4 -4
View File
@@ -103,10 +103,10 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The event id</param>
/// <param name="eventId">The event id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<IssueEvent> Get(string owner, string name, int number);
IObservable<IssueEvent> Get(string owner, string name, long eventId);
/// <summary>
/// Gets a single event
@@ -115,9 +115,9 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/events/#get-a-single-event
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The event id</param>
/// <param name="eventId">The event id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<IssueEvent> Get(long repositoryId, int number);
IObservable<IssueEvent> Get(long repositoryId, long eventId);
}
}
Octokit.Reactive/Clients/ObservableIssuesEventsClient.cs
+6 -6
View File
@@ -157,13 +157,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The event id</param>
public IObservable<IssueEvent> Get(string owner, string name, int number)
/// <param name="eventId">The event id</param>
public IObservable<IssueEvent> Get(string owner, string name, long eventId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, eventId).ToObservable();
}
/// <summary>
@@ -173,10 +173,10 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/events/#get-a-single-event
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The event id</param>
public IObservable<IssueEvent> Get(long repositoryId, int number)
/// <param name="eventId">The event id</param>
public IObservable<IssueEvent> Get(long repositoryId, long eventId)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, eventId).ToObservable();
}
}
}
Octokit.Tests.Integration/Clients/IssuesEventsClientTests.cs
+2 -2
View File
@@ -402,7 +402,7 @@ public class IssuesEventsClientTests : IDisposable
var closed = await _issuesClient.Update(_context.RepositoryOwner, _context.RepositoryName, issue.Number, new IssueUpdate { State = ItemState.Closed });
Assert.NotNull(closed);
var issueEvents = await _issuesEventsClient.GetAllForRepository(_context.RepositoryOwner, _context.RepositoryName);
int issueEventId = issueEvents[0].Id;
var issueEventId = issueEvents[0].Id;
var issueEventLookupById = await _issuesEventsClient.Get(_context.RepositoryOwner, _context.RepositoryName, issueEventId);
@@ -418,7 +418,7 @@ public class IssuesEventsClientTests : IDisposable
var closed = await _issuesClient.Update(_context.RepositoryOwner, _context.RepositoryName, issue.Number, new IssueUpdate { State = ItemState.Closed });
Assert.NotNull(closed);
var issueEvents = await _issuesEventsClient.GetAllForRepository(_context.Repository.Id);
int issueEventId = issueEvents[0].Id;
var issueEventId = issueEvents[0].Id;
var issueEventLookupById = await _issuesEventsClient.Get(_context.Repository.Id, issueEventId);
Octokit/Clients/IIssuesEventsClient.cs
+4 -4
View File
@@ -104,10 +104,10 @@ namespace Octokit
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The event id</param>
/// <param name="eventId">The event id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
Task<IssueEvent> Get(string owner, string name, int number);
Task<IssueEvent> Get(string owner, string name, long eventId);
/// <summary>
/// Gets a single event
@@ -116,9 +116,9 @@ namespace Octokit
/// http://developer.github.com/v3/issues/events/#get-a-single-event
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The event id</param>
/// <param name="eventId">The event id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
Task<IssueEvent> Get(long repositoryId, int number);
Task<IssueEvent> Get(long repositoryId, long eventId);
}
}
Octokit/Clients/IssuesEventsClient.cs
+6 -6
View File
@@ -149,13 +149,13 @@ namespace Octokit
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The event id</param>
public Task<IssueEvent> Get(string owner, string name, int number)
/// <param name="eventId">The event id</param>
public Task<IssueEvent> Get(string owner, string name, long eventId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return ApiConnection.Get<IssueEvent>(ApiUrls.IssuesEvent(owner, name, number));
return ApiConnection.Get<IssueEvent>(ApiUrls.IssuesEvent(owner, name, eventId));
}
/// <summary>
@@ -165,10 +165,10 @@ namespace Octokit
/// http://developer.github.com/v3/issues/events/#get-a-single-event
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The event id</param>
public Task<IssueEvent> Get(long repositoryId, int number)
/// <param name="eventId">The event id</param>
public Task<IssueEvent> Get(long repositoryId, long eventId)
{
return ApiConnection.Get<IssueEvent>(ApiUrls.IssuesEvent(repositoryId, number));
return ApiConnection.Get<IssueEvent>(ApiUrls.IssuesEvent(repositoryId, eventId));
}
}
}
Octokit/Helpers/ApiUrls.cs
+2 -2
View File
@@ -838,7 +838,7 @@ namespace Octokit
/// <param name="name">The name of the repository</param>
/// <param name="id">The event id</param>
/// <returns></returns>
public static Uri IssuesEvent(string owner, string name, int id)
public static Uri IssuesEvent(string owner, string name, long id)
{
return "repos/{0}/{1}/issues/events/{2}".FormatUri(owner, name, id);
}
@@ -2971,7 +2971,7 @@ namespace Octokit
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The event id</param>
/// <returns>The <see cref="Uri"/> that returns the issue/pull request event and issue info for the specified event.</returns>
public static Uri IssuesEvent(long repositoryId, int id)
public static Uri IssuesEvent(long repositoryId, long id)
{
return "repositories/{0}/issues/events/{1}".FormatUri(repositoryId, id);
}
Octokit/Models/Response/IssueEvent.cs
+2 -2
View File
@@ -9,7 +9,7 @@ namespace Octokit
{
public IssueEvent() { }
public IssueEvent(int id, string nodeId, string url, User actor, User assignee, Label label, EventInfoState @event, string commitId, DateTimeOffset createdAt, Issue issue, string commitUrl)
public IssueEvent(long id, string nodeId, string url, User actor, User assignee, Label label, EventInfoState @event, string commitId, DateTimeOffset createdAt, Issue issue, string commitUrl)
{
Id = id;
NodeId = nodeId;
@@ -27,7 +27,7 @@ namespace Octokit
/// <summary>
/// The id of the issue/pull request event.
/// </summary>
public int Id { get; protected set; }
public long Id { get; protected set; }
/// <summary>
/// GraphQL Node Id