dat code review feedback

This commit is contained in:
Brendan's Test Account
2014-03-21 11:12:57 +13:00
parent db50ac6a5b
commit ea9b0d27b0
5 changed files with 12 additions and 9 deletions
@@ -25,4 +25,4 @@ namespace Octokit.Reactive
return _client.Repository.Commits.Compare(owner, name, @base, head).ToObservable();
}
}
}
}
+1 -1
View File
@@ -22,7 +22,7 @@ namespace Octokit
public Task<CompareResult> Compare(string owner, string name, string @base, string head)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "repositoryName");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNullOrEmptyString(@base, "base");
Ensure.ArgumentNotNullOrEmptyString(head, "head");
+8 -3
View File
@@ -1053,15 +1053,20 @@ namespace Octokit
/// Returns the <see cref="Uri"/> for comparing two commits.
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="repositoryName">The name of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="base">The base commit</param>
/// <param name="head">The head commit</param>
/// <returns></returns>
public static Uri RepoCompare(string owner, string repositoryName, string @base, string head)
public static Uri RepoCompare(string owner, string name, string @base, string head)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNullOrEmptyString(@base, "base");
Ensure.ArgumentNotNullOrEmptyString(head, "head");
var encodedBase = @base.UriEncode();
var encodedHead = head.UriEncode();
return "repos/{0}/{1}/compare/{2}...{3}".FormatUri(owner, repositoryName, encodedBase, encodedHead);
return "repos/{0}/{1}/compare/{2}...{3}".FormatUri(owner, name, encodedBase, encodedHead);
}
/// <summary>
+1 -3
View File
@@ -1,7 +1,5 @@
using System;
using System.Collections.Generic;
using System.Collections.Generic;
using System.Diagnostics;
using System.Globalization;
namespace Octokit
{
+1 -1
View File
@@ -16,4 +16,4 @@ namespace Octokit
public string HtmlUrl { get; set; }
public IReadOnlyList<GitReference> Parents { get; set; }
}
}
}