Merge pull request #90 from octokit/haacked/namespace-cleanup

Namespace cleanup

Octokit.Reactive/Clients/ObservableAuthorizationsClient.cs

@@ -1,9 +1,9 @@
 using System;
 using System.Reactive;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Helpers;
+using Octokit.Reactive.Internal;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableAuthorizationsClient : IObservableAuthorizationsClient
     {

Octokit.Reactive/Clients/ObservableMiscellaneousClient.cs

@@ -1,7 +1,7 @@
 using System;
 using System.Reactive.Threading.Tasks;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableMiscellaneousClient : IObservableMiscellaneousClient
     {

Octokit.Reactive/Clients/ObservableOrganizationsClient.cs

@@ -1,8 +1,8 @@
 using System;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Helpers;
+using Octokit.Reactive.Internal;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableOrganizationsClient : IObservableOrganizationsClient
     {

Octokit.Reactive/Clients/ObservableReleasesClient.cs

@@ -1,8 +1,8 @@
 using System;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Helpers;
+using Octokit.Reactive.Internal;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableReleasesClient : IObservableReleasesClient
     {

Octokit.Reactive/Clients/ObservableRepositoriesClient.cs

@@ -1,9 +1,9 @@
 using System;
 using System.Reactive;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Helpers;
+using Octokit.Reactive.Internal;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableRepositoriesClient : IObservableRepositoriesClient
     {

Octokit.Reactive/Clients/ObservableSshKeysClient.cs

@@ -1,9 +1,9 @@
 using System;
 using System.Reactive;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Helpers;
+using Octokit.Reactive.Internal;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableSshKeysClient : IObservableSshKeysClient
     {

Octokit.Reactive/Clients/ObservableUsersClient.cs

@@ -1,8 +1,8 @@
 using System;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Helpers;
+using Octokit.Reactive.Internal;
 
-namespace Octokit.Reactive.Clients
+namespace Octokit.Reactive
 {
     public class ObservableUsersClient : IObservableUsersClient
     {

Octokit.Reactive/Helpers/ConnectionExtensions.cs

@@ -3,7 +3,7 @@ using System.Collections.Generic;
 using System.Reactive.Linq;
 using System.Reactive.Threading.Tasks;
 
-namespace Octokit.Reactive.Helpers
+namespace Octokit.Reactive.Internal
 {
     internal static class ConnectionExtensions
     {

Octokit.Reactive/Helpers/ObservableExtensions.cs

@@ -5,7 +5,7 @@ using System.Reactive;
 using System.Reactive.Concurrency;
 using System.Reactive.Disposables;
 
-namespace Octokit.Reactive.Helpers
+namespace Octokit.Reactive.Internal
 {
     public static class ObservableExtensions
     {

Octokit.Reactive/IObservableAuthorizationsClient.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Reactive;
 
@@ -15,7 +14,7 @@ namespace Octokit.Reactive
         /// details.
         /// </remarks>
         /// <returns>An <see cref="Authorization"/></returns>
-        [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate", 
+        [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate",
             Justification = "It's an API call, so it's not a property.")]
         IObservable<Authorization> GetAll();
 
@@ -92,7 +91,7 @@ namespace Octokit.Reactive
         /// <param name="authorizationUpdate">The changes to make to the authorization</param>
         /// <returns></returns>
         IObservable<Authorization> Update(int id, AuthorizationUpdate authorizationUpdate);
-        
+
         /// <summary>
         /// Deletes an <see cref="Authorization"/>.
         /// </summary>

Octokit.Reactive/IObservableGitHubClient.cs

@@ -1,6 +1,4 @@
-using Octokit.Internal;
-
-namespace Octokit.Reactive
+namespace Octokit.Reactive
 {
     public interface IObservableGitHubClient
     {

Octokit.Reactive/IObservableMiscellaneousClient.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 
 namespace Octokit.Reactive
@@ -9,6 +8,7 @@ namespace Octokit.Reactive
         [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate",
             Justification = "Makes a network request")]
         IObservable<IReadOnlyDictionary<string, Uri>> GetEmojis();
+
         IObservable<string> RenderRawMarkdown(string markdown);
     }
 }

Octokit.Reactive/IObservableOrganizationsClient.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 
 namespace Octokit.Reactive

Octokit.Reactive/IObservableSshKeysClient.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.Reactive;
 

Octokit.Reactive/ObservableGitHubClient.cs

@@ -1,5 +1,4 @@
 using Octokit.Internal;
-using Octokit.Reactive.Clients;
 
 namespace Octokit.Reactive
 {
@@ -21,7 +20,11 @@ namespace Octokit.Reactive
             Release = new ObservableReleasesClient(gitHubClient);
         }
 
-        public IConnection Connection { get { return _gitHubClient.Connection; }}
+        public IConnection Connection
+        {
+            get { return _gitHubClient.Connection; }
+        }
+
         public IObservableAuthorizationsClient Authorization { get; private set; }
         public IObservableMiscellaneousClient Miscellaneous { get; private set; }
         public IObservableOrganizationsClient Organization { get; private set; }

Octokit.Reactive/Octokit.Reactive.csproj

@@ -82,6 +82,9 @@
     <Compile Include="..\Octokit\Helpers\Ensure.cs">
       <Link>Helpers\Ensure.cs</Link>
     </Compile>
+    <Compile Include="..\SolutionInfo.cs">
+      <Link>Properties\SolutionInfo.cs</Link>
+    </Compile>
     <Compile Include="Clients\ObservableAuthorizationsClient.cs" />
     <Compile Include="Clients\ObservableMiscellaneousClient.cs" />
     <Compile Include="Clients\ObservableOrganizationsClient.cs" />
@@ -117,6 +120,7 @@
       <Name>Octokit</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Import Project="..\packages\Microsoft.Bcl.Build.1.0.10\tools\Microsoft.Bcl.Build.targets" Condition="Exists('..\packages\Microsoft.Bcl.Build.1.0.10\tools\Microsoft.Bcl.Build.targets')" />
   <Target Name="EnsureBclBuildImported" BeforeTargets="BeforeBuild" Condition="'$(BclBuildImported)' == ''">

Octokit.Reactive/Properties/AssemblyInfo.cs

@@ -1,36 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
 
-// General Information about an assembly is controlled through the following 
-// set of attributes. Change these attribute values to modify the information
-// associated with an assembly.
 [assembly: AssemblyTitle("Octokit.Reactive")]
-[assembly: AssemblyDescription("")]
-[assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("")]
-[assembly: AssemblyProduct("Octokit.Reactive")]
-[assembly: AssemblyCopyright("Copyright ©  2013")]
-[assembly: AssemblyTrademark("")]
-[assembly: AssemblyCulture("")]
-
-// Setting ComVisible to false makes the types in this assembly not visible 
-// to COM components.  If you need to access a type in this assembly from 
-// COM, set the ComVisible attribute to true on that type.
-[assembly: ComVisible(false)]
-
-// The following GUID is for the ID of the typelib if this project is exposed to COM
-[assembly: Guid("aed1a054-7d2c-4490-a16b-648964b4f128")]
-
-// Version information for an assembly consists of the following four values:
-//
-//      Major Version
-//      Minor Version 
-//      Build Number
-//      Revision
-//
-// You can specify all the values or you can default the Build and Revision Numbers 
-// by using the '*' as shown below:
-// [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyDescription("An IObservable based GitHub API client library for .NET using Reactive Extensions")]

Octokit.Tests.Integration/Reactive/ObservableRepositoriesClientTests.cs

@@ -1,6 +1,6 @@
 using System.Reactive.Linq;
 using System.Threading.Tasks;
-using Octokit.Reactive.Clients;
+using Octokit.Reactive;
 using Xunit;
 
 namespace Octokit.Tests.Integration

Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs

@@ -4,8 +4,7 @@ using System.Reactive.Linq;
 using System.Threading.Tasks;
 using NSubstitute;
 using Octokit.Internal;
-using Octokit.Reactive.Clients;
-
+using Octokit.Reactive;
 using Xunit;
 
 namespace Octokit.Tests.Reactive

Octokit.sln

@@ -22,6 +22,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Meta", "Meta", "{397C742D-2
 		CONTRIBUTING.md = CONTRIBUTING.md
 		LICENSE.txt = LICENSE.txt
 		README.md = README.md
+		SolutionInfo.cs = SolutionInfo.cs
 	EndProjectSection
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "OctokitRT", "Octokit\OctokitRT.csproj", "{C8BC13B6-3FA3-4716-827D-E7706F976FE1}"

Octokit/Octokit.csproj

@@ -78,6 +78,10 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="..\SolutionInfo.cs">
+      <Link>Properties\SolutionInfo.cs</Link>
+    </Compile>
+    <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Exceptions\TwoFactorChallengeFailedException.cs" />
     <Compile Include="Exceptions\TwoFactorRequiredException.cs" />
     <Compile Include="Helpers\ApiUrls.cs" />
@@ -172,7 +176,6 @@
     <Compile Include="Models\SshKeyUpdate.cs" />
     <Compile Include="Models\User.cs" />
     <Compile Include="Models\UserUpdate.cs" />
-    <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Helpers\StringExtensions.cs" />
     <Compile Include="Clients\RepositoriesClient.cs" />
     <Compile Include="SimpleJson.cs" />

Octokit/OctokitRT.csproj

@@ -99,6 +99,9 @@
     <Prefer32Bit>true</Prefer32Bit>
   </PropertyGroup>
   <ItemGroup>
+    <Compile Include="..\SolutionInfo.cs">
+      <Link>Properties\SolutionInfo.cs</Link>
+    </Compile>
     <Compile Include="ApiExtensions.cs" />
     <Compile Include="Authentication\AnonymousAuthenticator.cs" />
     <Compile Include="Authentication\Authenticator.cs" />

Octokit/Properties/AssemblyInfo.cs

@@ -1,43 +1,4 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
-
-// General Information about an assembly is controlled through the following 
-// set of attributes. Change these attribute values to modify the information
-// associated with an assembly.
 
 [assembly: AssemblyTitle("Octokit")]
-[assembly: AssemblyDescription("A .NET client library for the GitHub API")]
-[assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("Microsoft")]
-[assembly: AssemblyProduct("Octokit")]
-[assembly: AssemblyCopyright("Copyright © Microsoft 2012")]
-[assembly: AssemblyTrademark("")]
-[assembly: AssemblyCulture("")]
-[assembly: InternalsVisibleTo("Octokit.Tests")]
-[assembly: InternalsVisibleTo("OctokitRT.Tests")]
-
-// Setting ComVisible to false makes the types in this assembly not visible 
-// to COM components.  If you need to access a type in this assembly from 
-// COM, set the ComVisible attribute to true on that type.
-
-[assembly: ComVisible(false)]
-
-// The following GUID is for the ID of the typelib if this project is exposed to COM
-
-[assembly: Guid("ef83c56b-1c49-43c0-92fd-282adc4f0743")]
-
-// Version information for an assembly consists of the following four values:
-//
-//      Major Version
-//      Minor Version 
-//      Build Number
-//      Revision
-//
-// You can specify all the values or you can default the Build and Revision Numbers 
-// by using the '*' as shown below:
-// [assembly: AssemblyVersion("1.0.*")]
-
-[assembly: AssemblyVersion("0.9.0.0")]
-[assembly: AssemblyFileVersion("0.9.0.0")]
-[assembly: AssemblyInformationalVersion("0.9.0.0")]
+[assembly: AssemblyDescription("A Task based GitHub API client library for .NET")]

SolutionInfo.cs

@@ -0,0 +1,25 @@
+using System;
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+
+[assembly: AssemblyVersion(SolutionInfo.Version + ".0")]
+[assembly: AssemblyInformationalVersion(SolutionInfo.Version)]
+[assembly: AssemblyFileVersion(SolutionInfo.Version + ".0")]
+
+[assembly: ComVisible(false)]
+
+[assembly: AssemblyConfiguration("")]
+[assembly: AssemblyCompany("GitHub")]
+[assembly: AssemblyProduct("Octokit")]
+[assembly: AssemblyCopyright("Copyright © GitHub 2013")]
+[assembly: AssemblyTrademark("")]
+[assembly: AssemblyCulture("")]
+[assembly: InternalsVisibleTo("Octokit.Tests")]
+[assembly: InternalsVisibleTo("OctokitRT.Tests")]
+[assembly: CLSCompliant(false)]
+
+class SolutionInfo
+{
+    public const string Version = "0.1.0";
+}