fix language with spaces giving wrong results (#2038)

This commit is contained in:
Jose de Jesus Medina
2019-11-13 05:31:24 -08:00
committed by Brendan Forster
parent f61654a74b
commit fd6bca910c
9 changed files with 18 additions and 18 deletions
+10 -10
View File
@@ -200,13 +200,13 @@ namespace Octokit.Tests.Clients
{
var connection = Substitute.For<IApiConnection>();
var client = new SearchClient(connection);
//get users who have mostly repos where language is Ruby
//get users who have mostly repos where language is Literate Haskell
var request = new SearchUsersRequest("github");
request.Language = Language.Ruby;
request.Language = Language.LiterateHaskell;
client.SearchUsers(request);
connection.Received().Get<SearchUsersResult>(
Arg.Is<Uri>(u => u.ToString() == "search/users"),
Arg.Is<Dictionary<string, string>>(d => d["q"] == "github+language:Ruby"));
Arg.Is<Dictionary<string, string>>(d => d["q"] == "github+language:\"Literate Haskell\""));
}
[Fact]
@@ -462,12 +462,12 @@ namespace Octokit.Tests.Clients
{
var connection = Substitute.For<IApiConnection>();
var client = new SearchClient(connection);
//get repos who's language is Ruby
//get repos who's language is Literate Haskell
var request = new SearchRepositoriesRequest("github");
request.Language = Language.Ruby;
request.Language = Language.LiterateHaskell;
client.SearchRepo(request);
connection.Received().Get<SearchRepositoryResult>(Arg.Is<Uri>(u => u.ToString() == "search/repositories"),
Arg.Is<Dictionary<string, string>>(d => d["q"] == "github+language:ruby"));
Arg.Is<Dictionary<string, string>>(d => d["q"] == "github+language:\"Literate Haskell\""));
}
[Fact]
@@ -986,13 +986,13 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new SearchClient(connection);
var request = new SearchIssuesRequest("something");
request.Language = Language.CSharp;
request.Language = Language.LiterateHaskell;
client.SearchIssues(request);
connection.Received().Get<SearchIssuesResult>(
Arg.Is<Uri>(u => u.ToString() == "search/issues"),
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+language:CSharp"));
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+language:\"Literate Haskell\""));
}
[Fact]
@@ -1682,13 +1682,13 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new SearchClient(connection);
var request = new SearchCodeRequest("something");
request.Language = Language.CSharp;
request.Language = Language.LiterateHaskell;
client.SearchCode(request);
connection.Received().Get<SearchCodeResult>(
Arg.Is<Uri>(u => u.ToString() == "search/code"),
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+language:CSharp"));
Arg.Is<Dictionary<string, string>>(d => d["q"] == "something+language:\"Literate Haskell\""));
}
[Fact]
@@ -68,7 +68,7 @@ public class SearchIssuesRequestExclusionsTests
request.Language = Language.CSharp;
Assert.Contains("-language:CSharp", request.MergedQualifiers());
Assert.Contains("-language:\"CSharp\"", request.MergedQualifiers());
}
[Fact]
@@ -156,7 +156,7 @@ public class SearchIssuesRequestTests
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("language:"));
request.Language = Language.CSharp;
Assert.Contains("language:CSharp", request.MergedQualifiers());
Assert.Contains("language:\"CSharp\"", request.MergedQualifiers());
}
[Fact]
@@ -31,7 +31,7 @@ public class SearchRepositoryRequestTests
{
var request = new SearchRepositoriesRequest() { Language = Language.CPlusPlus };
var result = request.MergedQualifiers();
Assert.Contains(result, x => string.Equals(x, "language:cpp"));
Assert.Contains(result, x => string.Equals(x, "language:\"cpp\""));
}
}
}
+1 -1
View File
@@ -169,7 +169,7 @@ namespace Octokit
if (Language != null)
{
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:{0}", Language.ToParameter()));
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:\"{0}\"", Language.ToParameter()));
}
if (Forks != null)
@@ -338,7 +338,7 @@ namespace Octokit
if (Language != null)
{
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:{0}", Language.ToParameter()));
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:\"{0}\"", Language.ToParameter()));
}
if (Is != null)
@@ -170,7 +170,7 @@ namespace Octokit
if (Language != null)
{
parameters.Add(string.Format(CultureInfo.InvariantCulture, "-language:{0}", Language.ToParameter()));
parameters.Add(string.Format(CultureInfo.InvariantCulture, "-language:\"{0}\"", Language.ToParameter()));
}
if (Status.HasValue)
@@ -148,7 +148,7 @@ namespace Octokit
if (Language != null)
{
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:{0}", Language.ToParameter()));
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:\"{0}\"", Language.ToParameter()));
}
if (User.IsNotBlank())
+1 -1
View File
@@ -117,7 +117,7 @@ namespace Octokit
if (Language != null)
{
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:{0}", Language));
parameters.Add(string.Format(CultureInfo.InvariantCulture, "language:\"{0}\"", Language.ToParameter()));
}
if (Created != null)