PullRequestCommit Author and Committer fields were mistakenly typed with
Committer when they should be of type User.
Previously the types of properties were:
* `PullRequestCommit.Author/Committer`: `Committer`
* `Commit.Author/Committer`: `Committer`
Correct types should be:
* `PullRequestCommit.Author/Committer`: `User`
* `Commit.Author/Committer`: `Committer`
These fields always fail to deserialize in the API calls but produce no
errors, only objects with default values.
* ChecksClient ctor takes IApiConnection interface
Instead of requiring the concrete implementation type
* Ensure all clients nested under GitHubClient have a concrete implementation with a matching ctor.
An api client ctor should take either an IConnection or IApiConnection interface as argument.
* Update OAuth Token operations to new APIs
Per ['Deprecating OAuth Application API'](https://developer.github.com/changes/2020-02-14-deprecating-oauth-app-endpoint/)
the HTTP API endpoints called by CheckApplicationAuthentication,
ResetApplicationAuthentication and RevokeApplicationAuthentication are
being deprecated.
This PR updates those APIs to call the new HTTP API endpoints as
documented at the above link.
* Details
Amend CheckApplicationAuthentication, ResetApplicationAuthentication and
RevokeApplicationAuthentication to create an object containing the OAuth
access token and to call the single arg version of
ApiUrls.ApplicationAuthorization. The object is used as the request
body.
Amend CheckApplicationAuthentication to use POST.
Amend ResetApplicationAuthentication to use PATCH.
Remove the two arg version of ApiUrls.ApplicationAuthorization as it is
no longer called. Amend the single arg version to use the new API path.
Amend unit tests to account for the above changes.
* Update unit tests to check request payload
Add a check to the unit tests to verify that the request payload
contains an access_token field with the expected value.
* drop mentions of net45 from core
* Bump System.Reactive from 3.1.0 to 4.3.2
Bumps [System.Reactive](https://github.com/dotnet/reactive) from 3.1.0 to 4.3.2.
- [Release notes](https://github.com/dotnet/reactive/releases)
- [Commits](https://github.com/dotnet/reactive/compare/v3.1.0...rxnet-v4.3.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* upgrade from net452 to net46 in test projects
* drop netstandard1.1 support
* correct this test reference
* add necessary dependency for test project
* add new dependency needed for integration tests
* upload net462 code coverage
* upgrade environment for validating linqpad examples
* bump linqpad to latest 5.x release
Co-authored-by: Brendan Forster <brendan@github.com>
* add failing integration test for timestamp
* make the test pass by encoding the value
* generalize this pattern for now
* update tests to reflect change in date formatting
