Commit Graph

4746 Commits

Author SHA1 Message Date
Brendan Forster
ac8ac6fa5b restore helper function 2019-09-22 20:51:15 -03:00
Brendan Forster
0c3fbeb51f tidy up tests 2019-09-22 20:51:15 -03:00
Brendan Forster
92e3ca79bd fix failing convention tests 2019-09-22 20:51:15 -03:00
Brendan Forster
6719e5af4f fix bad rebase 2019-09-22 20:51:15 -03:00
Ryan Gribble
8efec60901 remove accidental change 2019-09-22 20:51:15 -03:00
Ryan Gribble
fb85a7a4bf Add integration tests for observable client 2019-09-22 20:51:15 -03:00
Ryan Gribble
1e9079b50b Temporarily skip test broken due to serializer change 2019-09-22 20:51:15 -03:00
Ryan Gribble
4ef04e0a41 Unit tests for observable methods 2019-09-22 20:51:15 -03:00
Ryan Gribble
1c6f70ad63 Implement observable methods 2019-09-22 20:51:15 -03:00
Ryan Gribble
e08ac388ff Add unit tests for authorized keys methods and fix convention test 2019-09-22 20:51:15 -03:00
Ryan Gribble
266b9a62e8 Fixup URLs and Xml comments 2019-09-22 20:51:15 -03:00
Ryan Gribble
1415dc3bef Rework request object to be the correct structure so SimpleJsonSerializer can be used to serialize it. Remove MaintenanceDate class and just pass in the Date/string for when
Still need to use UrlFormEncoding rather than json in the POST body though...
2019-09-22 20:51:15 -03:00
Ryan Gribble
e0d5a74e16 move GHE endpoint fixup inside ApiUrls methods 2019-09-22 20:51:15 -03:00
Ryan Gribble
835e15737a make internal and tidy up URL concatenation 2019-09-22 20:51:14 -03:00
Ryan Gribble
cd503f2c67 Json deserializer always returns an object even when no fields were present, but other calling code was expecting a null to be returned if deserialization failed.
Deserializer now only instantiates object when at least 1 field was found, otherwise null is returned
2019-09-22 20:51:14 -03:00
Ryan Gribble
f5359cdf7c Fixup integration tests for AuthorizedKeys 2019-09-22 20:51:14 -03:00
Ryan Gribble
58e304ed17 The Delete method actually returns a response so need to implement Delete<T>() in Connection and ApiConnection classes 2019-09-22 20:51:14 -03:00
Ryan Gribble
257fe4429a key needs to be specified as a request object with an "authorized_key" parameter. Also the management console API wants it as a URL parameter rather than as a json body payload
Fix UriExtension ApplyParameter() to be able to apply parameters to non absolute URLs
2019-09-22 20:51:14 -03:00
Ryan Gribble
a665ecd104 Implement AuthorizedManagementKey GetAll() Add() Delete() 2019-09-22 20:51:14 -03:00
Ryan Gribble
0c3c4ead6d Initial implementation of ManagementConsole - maintenance mode 2019-09-22 20:34:40 -03:00
Brendan Forster
7c31109099 bring tests from unrelated PR into this project (#2013) 2019-09-22 18:56:37 -03:00
Brendan Forster
c78b3cf21a tidy up new tests (#2012) 2019-09-22 17:27:30 -03:00
Brendan Forster
8cd0b341dd Begin implementation of Enterprise ManagementConsole API, redux (#2010)
* Initial implementation of ManagementConsole - maintenance mode

* Add environment var support for management console password for integration tests

* Add reactive client and unit tests

* Update some xmlDoc

* I think this is a better way to setup the underlying baseUri on IConneciton, to achieve managemet console access rather than requiring a specific GitHubClient that cant call normal API's
Instead, the management client methods can check the base Url and if it contains /api/v3/ they can set their relative endpoint Uri to include a leading "/" which will cause the /api/v3/ to be removed.

* Update EnterpriseClient.cs

Fix xml comments

* Update IEnterpriseClient.cs

Fix xml comments

* Still trying to get the xmDoc perfect, thanks app veyor :)

* XmlDoc'ing my way to success

* Add specific test attribute for management console tests

* check chronic string empty/null

* Use helper's password field in test

* Tidy up maintenance mode tests by using a context/destructor to manage the initial/end state of maintenance mode

* make internal and tidy up URL concatenation

* move GHE endpoint fixup inside ApiUrls methods

* Rework request object to be the correct structure so SimpleJsonSerializer can be used to serialize it.  Remove MaintenanceDate class and just pass in the Date/string for when
Still need to use UrlFormEncoding rather than json in the POST body though...

* Create abstract base class for FormUrlEncoded parameters (similar to existing RequetParameters) and inherit from it in UpdateMaintenanceRequest

* Fix maintenance context logic - destructor should always turn maintenance OFF regardless of initial requested state

* Fix xml comment

* Fix Xml comment

* Those pesky xml comments!

* Fine, I give up!

* Fix string.Format

* fix bad rebase

* fix failing convention tests

* restore missing whitespace

* writing some docs

* some edits

* edit
2019-09-22 15:09:56 -03:00
Henrik Andersson
fafbf33b78 Implement Draft Pull Requests (#2009)
* Add draft PR preview header

* Add Draft property to models

* Update pull requests client and tests to use draft PR accept header

* Update observable pull requests client and tests to use draft PR accept header

* Add integration tests to create and retrieve draft pull requests
2019-09-22 13:38:56 -03:00
Brendan Forster
d955d7facd never email notification on success or error 2019-09-21 13:21:15 -03:00
Henrik Andersson
9e5a76886f Add ability to specify 'since' request parameter to issue comments (#2008)
* Update issue comments client to allow returning comments 'since' a specific date

* Update observable issue comments client to allow returning comments 'since' a specific date

* Add test cases to cover newly added methods
2019-09-21 13:17:14 -03:00
Henrik Andersson
63a4deae35 Add missing ID property to Milestone (#2007)
* Add Id property to Milestone model

* Exclude Riders workspace directory
2019-09-21 13:14:20 -03:00
Brendan Forster
ae10ba3cab add netstandard2.0 output (#2006) 2019-09-20 11:07:20 -03:00
Brendan Forster
eb65e090ca next batch of test cleanup (#2004) 2019-09-20 10:41:04 -03:00
Brendan Forster
89423fd69a no need to build and run tests against net46 (#2005) 2019-09-20 09:23:36 -03:00
Stanley Goldman
f70c402d78 Generate code coverage output with coverlet (#1866)
* add support for Codecov reporting on Windows
2019-09-17 09:49:44 -03:00
Brendan Forster
60e60ca384 generated a net46-compatible binary alongside net45 (#2001) 2019-09-17 09:04:02 -03:00
dependabot-preview[bot]
539a609a40 Bump xunit.runner.visualstudio from 2.3.0-beta4-build3742 to 2.4.1 (#1999)
Bumps [xunit.runner.visualstudio](https://github.com/xunit/xunit) from 2.3.0-beta4-build3742 to 2.4.1.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](https://github.com/xunit/xunit/commits/2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-17 08:33:49 -03:00
dependabot-preview[bot]
52080085a8 Bump Microsoft.NET.Test.Sdk from 15.0.0 to 16.2.0 (#2000)
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 15.0.0 to 16.2.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v15.0.0...v16.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-17 08:25:07 -03:00
Brendan Forster
ca95d571ed add license metadata to package outputs (#1998) v0.34.0 2019-09-16 21:35:13 -03:00
Brendan Forster
45bc5eced7 autofix tests based on feedback from xunit analyzers (#1997) 2019-09-16 19:46:40 -03:00
dependabot-preview[bot]
61bd1d1018 Bump NSubstitute from 3.1.0 to 4.2.1 (#1993)
* Bump NSubstitute from 3.1.0 to 4.2.1

Bumps NSubstitute from 3.1.0 to 4.2.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* fix failing tests
2019-09-16 19:12:56 -03:00
dependabot-preview[bot]
c23652a347 Bump GitHubJwt from 0.0.2 to 0.0.3 (#1991)
Bumps [GitHubJwt](https://github.com/adriangodong/githubjwt) from 0.0.2 to 0.0.3.
- [Release notes](https://github.com/adriangodong/githubjwt/releases)
- [Commits](https://github.com/adriangodong/githubjwt/compare/0.0.2...0.0.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-16 14:07:16 -03:00
Brendan Forster
785dcdfa18 update agents to use non-EOL version of Ubuntu and .NET core 2.2 (#1996) 2019-09-16 13:47:37 -03:00
Brendan Forster
6433b9123e fix timezone offset handling (#1988)
* port tests to use DateTimeOffset

* drop the whitespace when emitting DateTimeOffset values

* tidy up stale regions
2019-09-16 10:27:27 -03:00
dependabot-preview[bot]
ef7fe2680e Bump xunit from 2.2.0 to 2.4.1 (#1995)
Bumps [xunit](https://github.com/xunit/xunit) from 2.2.0 to 2.4.1.
- [Release notes](https://github.com/xunit/xunit/releases)
- [Commits](https://github.com/xunit/xunit/compare/2.2...2.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-16 10:06:20 -03:00
dependabot-preview[bot]
d482ce90bf Bump SourceLink.Create.GitHub from 2.8.2 to 2.8.3 (#1992)
Bumps [SourceLink.Create.GitHub](https://github.com/ctaggart/SourceLink) from 2.8.2 to 2.8.3.
- [Release notes](https://github.com/ctaggart/SourceLink/releases)
- [Commits](https://github.com/ctaggart/SourceLink/compare/2.8.2...2.8.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-09-16 10:05:30 -03:00
Henrik Andersson
4f0519ee13 Add a warning to the statistics client about caching (#1954)
* Add a warning to the statistics client about caching

* Simplify note about caching and direct users to the API docs

Also update to use summary instead of remarks

* Merge the summary sections as the 2nd section is ignored in VS

* squash duplicate summary tags together

* Also squash these lines
2019-09-16 09:40:12 -03:00
Jan Klass
1f01b22de5 Fix typo (#1985) v0.33.0 2019-09-04 08:41:13 -03:00
Mattias Karlsson
01d5c8721c (build) Updated Cake.Frosting to version 0.34.1 (#1978)
* (build) Updated Cake.Frosting to version 0.34.1

* Update GritVersion from 3.6.2 to 5.0.0
2019-08-01 11:10:32 -03:00
Greg Ingram
8fcb731343 Update README.md (#1971)
Fixed spelling
2019-07-22 14:34:50 -03:00
Ryan Gribble
9f005c438e add SubmittedAt field to PullRequestReview (#1964) 2019-06-17 07:26:06 +10:00
Ben McMorran
70fe726954 Correctly support language filter in repo search (#1951)
* Correctly support language filter in repo search

* Fix failing client test

* Use the correct language code for C++
2019-04-01 13:55:07 +10:00
Patrick
d16ac98d00 DateRange does not include time #1904 (#1905)
* DateRange does not include time #1904

* DateRange does not include time #1904

* DateRange does not include time #1904

* DateRange does not include time #1904

* DateRange does not include time #1904

* Requested changed by ryangribble

* Update to Obselete Attribute messages

#1904 #1905
2019-03-19 21:03:14 +10:00
Henrik Andersson
8ff9163c99 Updated link to the ScriptCs.Octokit repo (#1953) 2019-03-10 19:25:54 +10:00