* add node_id to Deployments payloads (Deployment and DeploymentStatus and Account/User/Organization)
* add node_id to gist responses
* add node_id to Git Blob
* add node_id to Git Commit response
* add node_id to GitReference response
* add node_id to everything that inherits GitReference
* add node_id to Issue
* add node_id to IssueComment/IssueEvent
* add node_id to Label
* add node_id to Milestone
* add node_id to Project/ProjectCard/ProjectColumn
* add node_id to Reaction
* add node_id to Release/ReleaseAsset
* add node_id to Team
* add node_id to Repository.RepositoryContributor/RepositoryInvitation/RepositoryTag
* add node_id to Commit related responses
* Add node_id to PullRequest related responses
* Add node_id to any response models it was found to be missing, based on auditing integration test responses
* remove unused test variable that was using a response ctor
* fix tests that need to handle node_id now
* Committer is a request object as well as response, so make nodeId optional
* fix test
* Added a convention test to detect a model constructor exposing all properties
* add ctors to classes where they are missing
* rename ctor parameters that dont match properties
* add missing parameters to existing ctors
* add specific PunchCard ctor to allow mocking, and update test to resolve call ambiguity
* Added base class properties to the convention test
Added member exclusion attribute
* Updated newly offending classes
2 excludes and 2 ctors
* rename exclusion attribute to be a bit shorter
* Add release notes
* Fix failing integration test
* Run FormatCode build task to tidy up whitespace
* Remove "UnkownUser" from release notes contributors
* Added StringEnum<TEnum>
* Added tests
* Make sure the serializer can work with StringEnum
* Use StringEnum for EventInfo.Event
* Add convention test to assert that all Response models use StringEnum<> to wrap enum properties
* Add Stringnum<> to all response types failing convention test
* Handle StringEnum to Enum conversion when Issue response model populates IssueUpdate request model
* Fix unit test
* Refactor SimpleJsonSerializer to expose the DeserializeEnum strategy so it can be used in StringEnum class
* Need to expose/use SerializeEnum functionality too, so we use the correct string representation of enum values that have custom properties (eg ReactionType Plus1 to "+1")
* fix unit tests, since the string is now the "correct" upstream api value
* Add a couple of tests for the Enum serialize/deserialize when underscores, hyphens and custom property attributes are present
* Compare parsed values for equality
* add convention test to ensure enum members all have Parameter property set
* update test to cover implicit conversions too
* this test should work but fails at the moment due to magic hyphen removal in deserializer causing a one way trip from utf-8 to EncodingType.Utf8 with no way to get back
* (unsuccesfully) expand event info test to try to catch more cases of unknown event types
* fix broken integration test while im here
* Fixed build errors after .NET Core merge
* Value -> StringValue, ParsedValue -> Value
* Don't allow StringValue to be null
* Ignore enums not used in request/response models
* Added ParameterAttribute to almost all enum values
* Ignore Language enum
* Fix failing tests
* Fix milestone sort parameter and tests
* whitespace
* fix milestone unit tests
* Fix StringEnum.Equals ... This could've been embarrassing!
* Change SimpleJsonSerializer Enum handling to only use `[Parameter()]` attributes (no more magic removal of hyphen/underscores from strings)
* Tidy up this integration test while im here
* Only test request/response enums in convention test
* Keep skipping Language
* Remove unused method
* Remove excluded enum types
* Removed unnecessary ParameterAttributes
* Remove unused enum
* Add StringEnum test for string-comparison of two invalid values
* Bring back IssueCommentSort and use it in IssueCommentRequest
This reverts commit 38a4a291d1476ef8c992fe0f76956974b6f32a49.
* Use assembly instead of namespace for Octokit check
* Add failing test to reproduce the issue where only the first enum paramter/value was added to the cache
* Fix deserializer enum cache to include all enum members rather than only the first member encountered
* Use a static SimpleJsonSerializer in StringEnum
* Remove serializer instance in StringEnum
* Add some documentation on StringEnum<TEnum>
* Fix parameter value to resolve failing integration test
* Add convention test to ensure 'Url' properties are of type string
Closes#1582
* Change 'Url' properties from Uri to string
Global Find/Replace FTW!
* fix compilation errors in the integration tests project
* Extend 'Url' properties type check to request models
* Stick to convention tests naming convention
* Remove unused using directives in models
Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files
* Update exception message wording
* empty commit to trigger a new build - hopefully Travis passes
* add convention test to ensure request models have Uri 'Url' properties
* make request models 'Url' properties Uri
fix typo in convention test name
* revert some request models 'Url' properties as `string`
see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728
* Change test so that all model types must have 'Url' properties of type string
- Filter test input to only get types which have 'Url' properties
- Merge response and request model types tests into one
- Unparameterize the exception since we only check for the string type now
* Fix string.Format tokens
If this PR doesn't get rebased, it'll be my wall of shame FOREVER!
* and then it's even more embarrassing when the commit message says rebased but you really meant squashed
* Remove exclusion of `Release` from request models
* add reactions to issue response payload
* add reactions to commit comment payload
* add reactions to review comment payload
* create tests for issue client
* tests for commitcomment client
* tests for pull request review comment
* change observable tests
* simplify strings
* remove unnecessary clients
* change integration tests to retrieve all reaction types
* create integration test for issue comment client
* fix merge conflicts
* fix merge conflicts
* gets tests passing again
* fix some reaction integration tests
* Fixup unit tests wth preview accepts header
Also applied preview header to a couple of repositoryId based calls that were added by another PR
* Fixup unit tests wth preview accepts header
Also applied preview header to a couple of repositoryId based calls that were added by another PR
* Rework reaction payload tests for IssueComments to handle Get, GetAllForIssue and GetAllForRepository calls
* [WIP] reaction payload tests
* Rework reaction payload tests for IssueComments to handle Get, GetAllForIssue and GetAllForRepository calls
* Rework reaction payload tests for Issues client
* Rework reaction payload tests for PullRequestReviews client
* Rework reaction payload tests for CommitComments client
* Revert "[WIP] reaction payload tests"
This reverts commit a6179b0f21a3ddfe36bfd3ae5eafae0e69b52252.
Ehsan Mirsaeedi