Commit Graph

33 Commits

Author SHA1 Message Date
Victor
6c43183837 fix: comment id model update to long instead of int
* #2927: comment id model update to long instead of int

* #2927: code review fixes (1)

* #2927: code review fixes (2)

* #2927: comment id model update to long instead of int: unit tests fix

* #2927: code review fixes

* Fixed most names of parameters

---------

Co-authored-by: Victor Vorobyev <victor@myrtle-sa.com>
Co-authored-by: Brian C. Arnold <brian.arnold@spiderrock.net>
2024-06-10 08:12:08 -05:00
Tom Longhurst
cd1835326b Fix xUnit Warnings (#2906)
* Fix xUnit Warnings

* Fix

* Fix formatting in AsyncPaginationExtensionGenerator.cs

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
2024-04-15 13:19:26 -07:00
Chris Simpson
5fe3ea82f0 tests: Updates and fixes for tests, changing master to main and adding flaky tests marker (#2511) 2022-07-25 10:36:09 -05:00
Ryan Gribble
db74c3b4ad Fix async tests (#1631)
* Fix up Assert.ThrowsAsync tests to actually await the call

* ... and it even picked up a missing null check... pay day!
2017-07-23 09:03:10 +10:00
Ryan Gribble
3c818934b8 Release v0.24 - A Sight For Sore Eyes (#1539)
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
2017-01-17 18:56:55 +10:00
Brandon Everett
155073b138 [WIP] Rename Comment to ReviewComment (#1520)
* obsolete comment and add ReviewComment

* obsolete PullRequest.Comment and change to ReviewComment

* update ObservablePullRequestClient and interface to use ReviewComment

* fixed formatting issues
have Comment return new ReviewComment
2016-12-31 19:21:40 +10:00
Andreia Gaita
9e958bf998 Make Repository Id a long, it's going to grow... 2016-09-15 02:15:11 +02:00
Martin Scholz
72e30a7f90 Add reactions to issue, commit comment and review payload (#1405)
* add reactions to issue response payload

* add reactions to commit comment payload

* add reactions to review comment payload

* create tests for issue client

* tests for commitcomment client

* tests for pull request review comment

* change observable tests

* simplify strings

* remove unnecessary clients

* change integration tests to retrieve all reaction types

* create integration test for issue comment client

* fix merge conflicts

* fix merge conflicts

* gets tests passing again

* fix some reaction integration tests

* Fixup unit tests wth preview accepts header
Also applied preview header to a couple of repositoryId based calls that were added by another PR

* Fixup unit tests wth preview accepts header
Also applied preview header to a couple of repositoryId based calls that were added by another PR

* Rework reaction payload tests for IssueComments to handle Get, GetAllForIssue and GetAllForRepository calls

* [WIP] reaction payload tests

* Rework reaction payload tests for IssueComments to handle Get, GetAllForIssue and GetAllForRepository calls

* Rework reaction payload tests for Issues client

* Rework reaction payload tests for PullRequestReviews client

* Rework reaction payload tests for CommitComments client

* Revert "[WIP] reaction payload tests"

This reverts commit a6179b0f21a3ddfe36bfd3ae5eafae0e69b52252.
2016-07-08 20:29:08 +10:00
Alexander Efremov
5af04e32c8 added new integration tests 2016-06-17 00:31:21 +07:00
aedampir@gmail.com
188d6b9a30 added integration tests 2016-05-26 15:06:25 +07:00
aedampir@gmail.com
f1896888c6 Redundant commas in object initializer were removed. 2016-04-22 17:30:37 +07:00
Robert Pethick
ffc0b35608 Switch GitDatabase->Git on IGitHubProvider 2015-12-24 17:01:37 +00:00
Brendan Forster
80719c0033 aaaand format the code 2015-11-04 13:38:51 -08:00
William Barbosa
1cb1258eb6 Refactors tests up to PullRequestsClientTests 2015-09-27 01:19:58 -03:00
Henrik Andersson
189ae42c3a Update tests 2015-03-24 00:12:54 +10:00
Haacked
a94051d6b0 Repository name is required when creating a repo
I was trying to create a repository and I wasn't sure which parameters
were required. Following our philosophy of exposing required parameters
in the constructor, I change the `NewRepository` object to take in a
repository name and to make that property readonly.
2015-03-19 16:25:03 -07:00
Brendan Forster
28e8372922 extract helper method for setting up GitHubClient 2015-01-04 10:03:45 +09:30
Haacked
1b4d02b142 Ensure no async void methods
Added self tests to find async void methods. It found some cases where
we passed an async lambda to a method that did not accept Action<Task>
or Func<Task>. I fixed those tests.
2014-11-07 16:05:53 -08:00
Brendan Forster
67247a050c use the correct refs as the api validation is shouty shouty 2014-10-04 10:10:46 -03:00
Brendan Forster
e8cd8addc7 investigating why the order of these tests is weird 2014-07-10 15:41:46 +09:30
Brendan Forster
69bc413655 i hate myself 2014-07-10 15:19:30 +09:30
Brendan Forster
5ad166ac1a making this an inner class 2014-07-10 14:45:45 +09:30
Brendan Forster
ffebd59f62 deprecate some properties 2014-07-10 14:42:27 +09:30
Brendan Forster
5676b62e09 added test around how timestamps work 2014-07-10 14:38:58 +09:30
Brendan Forster
12fca5f83d get to the created comment in the test 2014-07-10 14:34:34 +09:30
Brendan Forster
820ae69b71 dropped mention of PullRequest to be consistent with other areas 2014-07-10 14:19:05 +09:30
Brendan Forster
3da59c2150 simplify test setup and teardown 2014-07-10 14:14:37 +09:30
Brendan Forster
ae1f79688e 💄 tidy up test code a bit 2014-07-10 13:50:21 +09:30
Gabriel Weyer
f23ddf81f9 Finalized integration testing for review comments 2014-05-04 10:46:35 +10:00
Gabriel Weyer
7223518239 Trying to get things to work again 2014-05-03 11:56:36 +10:00
Gabriel Weyer
68aee77b18 Replaced forking by branching 2013-12-30 14:15:46 +11:00
Gabriel Weyer
6590d227e3 Added blob and tree creation to review comments integration tests 2013-12-09 10:34:32 +11:00
Gabriel Weyer
895cfc116b Fixed the Integration project that I broke 2013-12-09 10:10:24 +11:00