zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-03 11:05:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

dropped mention of PullRequest to be consistent with other areas

Browse Source
This commit is contained in:
Brendan Forster
2014-07-10 14:19:05 +09:30
parent 3da59c2150
commit 820ae69b71
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs
+1 -1
View File
@@ -102,7 +102,7 @@ public class PullRequestReviewCommentsClientTests : IDisposable
await CreateComments(commentsToCreate, position, pullRequest.RepoName, pullRequest.PullRequestCommitId, pullRequest.PullRequestNumber);
var pullRequestComments = await _client.GetForPullRequest(Helper.UserName, pullRequest.RepoName, pullRequest.PullRequestNumber);
var pullRequestComments = await _client.GetAll(Helper.UserName, pullRequest.RepoName, pullRequest.PullRequestNumber);
AssertComments(pullRequestComments, commentsToCreate, position);
}
Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs
+5 -5
View File
@@ -89,7 +89,7 @@ public class PullRequestReviewCommentsClientTests
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewCommentsClient(connection);
client.GetForPullRequest("fakeOwner", "fakeRepoName", 7);
client.GetAll("fakeOwner", "fakeRepoName", 7);
connection.Received().GetAll<PullRequestReviewComment>(Arg.Is<Uri>(u => u.ToString() == "repos/fakeOwner/fakeRepoName/pulls/7/comments"));
}
@@ -100,10 +100,10 @@ public class PullRequestReviewCommentsClientTests
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewCommentsClient(connection);
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetForPullRequest(null, "name", 1));
await AssertEx.Throws<ArgumentException>(async () => await client.GetForPullRequest("", "name", 1));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetForPullRequest("owner", null, 1));
await AssertEx.Throws<ArgumentException>(async () => await client.GetForPullRequest("owner", "", 1));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll(null, "name", 1));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("", "name", 1));
await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll("owner", null, 1));
await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("owner", "", 1));
}
}
Octokit/Clients/IPullRequestReviewCommentsClient.cs
+1 -1
View File
@@ -13,7 +13,7 @@ namespace Octokit
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <returns>The list of <see cref="PullRequestReviewComment"/>s for the specified pull request</returns>
Task<IReadOnlyList<PullRequestReviewComment>> GetForPullRequest(string owner, string name, int number);
Task<IReadOnlyList<PullRequestReviewComment>> GetAll(string owner, string name, int number);
/// <summary>
/// Gets a list of the pull request review comments in a specified repository.
Octokit/Clients/PullRequestReviewCommentsClient.cs
+1 -1
View File
@@ -19,7 +19,7 @@ namespace Octokit
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <returns>The list of <see cref="PullRequestReviewComment"/>s for the specified pull request</returns>
public Task<IReadOnlyList<PullRequestReviewComment>> GetForPullRequest(string owner, string name, int number)
public Task<IReadOnlyList<PullRequestReviewComment>> GetAll(string owner, string name, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");