Commit Graph

35 Commits

Author SHA1 Message Date
Victor
6c43183837 fix: comment id model update to long instead of int
* #2927: comment id model update to long instead of int

* #2927: code review fixes (1)

* #2927: code review fixes (2)

* #2927: comment id model update to long instead of int: unit tests fix

* #2927: code review fixes

* Fixed most names of parameters

---------

Co-authored-by: Victor Vorobyev <victor@myrtle-sa.com>
Co-authored-by: Brian C. Arnold <brian.arnold@spiderrock.net>
2024-06-10 08:12:08 -05:00
Chris Simpson
2f7bd00dd6 feat: Removing accept header previews (#2515) 2022-08-01 09:37:23 -05:00
Brendan Forster
dc2f6ff001 first pass at cleaning up attributes (#2157) 2020-03-18 09:02:11 -03:00
Brendan Forster
5de5258257 add attribute for tracking preview usage in the codebase (#2128) 2020-03-07 10:40:15 -04:00
Brendan Forster
f96885654f add metadata to each client action (#2124) 2020-03-04 21:10:38 -04:00
Brendan Forster
ce5ea64428 migrate to dotnet-format tool (#2016)
* migrate to new dotnet-format tool in build script (run on local build)
* reformat code
2019-09-24 11:34:50 -03:00
Henrik Andersson
9e5a76886f Add ability to specify 'since' request parameter to issue comments (#2008)
* Update issue comments client to allow returning comments 'since' a specific date

* Update observable issue comments client to allow returning comments 'since' a specific date

* Add test cases to cover newly added methods
2019-09-21 13:17:14 -03:00
Itai Bar-Haim
4e804f61a6 Prefer using nameof(x) over literal "x" (#1781)
* updated XML docs and added some missing bits.

* prefer nameof(x) over literal "x"
2018-03-07 20:43:10 +10:00
Ryan Gribble
3c818934b8 Release v0.24 - A Sight For Sore Eyes (#1539)
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
2017-01-17 18:56:55 +10:00
Park June Chul
cf0edddc30 Fix IssueCommentClient #1500 (#1501)
* Make GetAllForRepo to accept optional args

* Fix tests

* add missing interfaces

* fix tests

* Fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* fix tests

* fix

* fix tests

* fix tests
2017-01-07 23:42:05 +10:00
Andreia Gaita
9e958bf998 Make Repository Id a long, it's going to grow... 2016-09-15 02:15:11 +02:00
aedampir@gmail.com
44b0f4039d ID -> Id 2016-07-17 16:29:32 +07:00
Martin Scholz
72e30a7f90 Add reactions to issue, commit comment and review payload (#1405)
* add reactions to issue response payload

* add reactions to commit comment payload

* add reactions to review comment payload

* create tests for issue client

* tests for commitcomment client

* tests for pull request review comment

* change observable tests

* simplify strings

* remove unnecessary clients

* change integration tests to retrieve all reaction types

* create integration test for issue comment client

* fix merge conflicts

* fix merge conflicts

* gets tests passing again

* fix some reaction integration tests

* Fixup unit tests wth preview accepts header
Also applied preview header to a couple of repositoryId based calls that were added by another PR

* Fixup unit tests wth preview accepts header
Also applied preview header to a couple of repositoryId based calls that were added by another PR

* Rework reaction payload tests for IssueComments to handle Get, GetAllForIssue and GetAllForRepository calls

* [WIP] reaction payload tests

* Rework reaction payload tests for IssueComments to handle Get, GetAllForIssue and GetAllForRepository calls

* Rework reaction payload tests for Issues client

* Rework reaction payload tests for PullRequestReviews client

* Rework reaction payload tests for CommitComments client

* Revert "[WIP] reaction payload tests"

This reverts commit a6179b0f21a3ddfe36bfd3ae5eafae0e69b52252.
2016-07-08 20:29:08 +10:00
aedampir@gmail.com
d1c89b1ffa removed <returns> tags 2016-07-07 03:33:00 +07:00
Alexander Efremov
60e9733c91 cleared <retruns> tags 2016-06-17 05:59:45 +07:00
aedampir@gmail.com
eb8e5b1cfc added new overloads 2016-06-15 20:01:39 +07:00
aedampir@gmail.com
7d65a8db4e added XML docs 2016-06-15 20:01:39 +07:00
Henrik Andersson
b38ca031ef Use AcceptHeaders.ReactionsPreview instead of local string 2016-06-15 16:36:18 +10:00
Henrik Andersson
5010538d68 Add Reactions property to IssueComment object 2016-06-15 16:20:01 +10:00
Elhamer
9c77ebf009 Add ApiOption overloads to methods on IIssueCommentsClient (#1267) 2016-04-14 14:07:19 +10:00
Gabriel Weyer
c98c865aff Fixed XML comment: it's an issue comment, not an issue 2015-12-23 12:24:49 +11:00
Gabriel Weyer
cbd9e76cb2 Issue comments are identified by Id instead of Number 2015-12-23 12:17:04 +11:00
Henrik Andersson
78e76be7d9 Update clients 2015-03-24 00:11:52 +10:00
Brendan Forster
7dc70a2192 💄 using statements, incorrect docs, deprecated Octokit.Response namespace 2014-03-08 16:33:46 +11:00
Peter MacNaughton
889b4484f3 Implemented Delete for IssueCommentsClient 2014-01-21 10:52:46 -07:00
Tomasz Pęczek
52032d38ca Fix for creating comments for issue
Attempt to create a comment for issue results in "400 Bad Request"
(Problems parsing JSON) because request contains the comment body as
plain text.

In order to resolve the issue the Create and Update methods has been
changed to use BodyWrapper.
2013-12-16 00:41:35 +01:00
Haacked
c96b00650e Add comments to concrete types
We now have a build task that copies comments from interface to
implementation.
2013-12-11 14:22:39 -08:00
Peter MacNaughton
f46eabe69a Instatiate is not a word! Fixed typo
Also expanded the IGitDatabaseClient summary
2013-12-04 00:19:16 -07:00
Peter MacNaughton
3b7488c4da API client constructors documented 2013-12-02 22:09:04 -07:00
pltaylor
138b98901b Fix up NetCore45 2013-11-04 14:14:22 -05:00
pltaylor
8d2c2c5895 Create ObservableIssueCommentsClient 2013-11-04 13:57:52 -05:00
pltaylor
d98961188d Fix some of the tests 2013-11-04 13:57:46 -05:00
pltaylor
304a53379b Create the functions to work with issue comments. 2013-11-04 13:57:44 -05:00
pltaylor
2e85180c1d Fix outputs to be IssueComment 2013-11-04 13:57:43 -05:00
pltaylor
9bf0df499d Add IssueComment class and bare bones IssueCommentsClass
Also rename IIssuesCommentClass to IISsueCommentsClass
2013-11-04 13:57:42 -05:00